From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753562AbcGSQgd (ORCPT ); Tue, 19 Jul 2016 12:36:33 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:58410 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753175AbcGSQgb (ORCPT ); Tue, 19 Jul 2016 12:36:31 -0400 Subject: Re: [PATCH V3 01/10] Documentation: dt-bindings: mailbox: tegra: Add binding for HSP mailbox To: Joseph Lo References: <20160719091723.30919-1-josephl@nvidia.com> Cc: Thierry Reding , Alexandre Courbot , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Mark Rutland , Peter De Schrijver , Matthew Longnecker , devicetree@vger.kernel.org, Jassi Brar , linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , Sivaram Nair From: Stephen Warren Message-ID: <578E570B.8060404@wwwdotorg.org> Date: Tue, 19 Jul 2016 10:36:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160719091723.30919-1-josephl@nvidia.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/19/2016 03:17 AM, Joseph Lo wrote: > Add DT binding for the Hardware Synchronization Primitives (HSP). The > HSP is designed for the processors to share resources and communicate > together. It provides a set of hardware synchronization primitives for > interprocessor communication. So the interprocessor communication (IPC) > protocols can use hardware synchronization primitive, when operating > between two processors not in an SMP relationship. Acked-by: Stephen Warren A couple of nits below that you might want to fix up when posting the final version of the series; your call. > diff --git a/include/dt-bindings/mailbox/tegra186-hsp.h b/include/dt-bindings/mailbox/tegra186-hsp.h > + */ > + > + > +#ifndef _DT_BINDINGS_MAILBOX_TEGRA186_HSP_H Nit: There are 2 blank lines there. > +#endif /* _DT_BINDINGS_MAILBOX_TEGRA186_HSP_H */ Nit: Personally I hate "filename" comments on the #endif, since it's just one more place to update if the file moves or is copied.