From: Adrian Hunter <adrian.hunter@intel.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Georgi Djakov <georgi.djakov@linaro.org>
Cc: ulf.hansson@linaro.org, iivanov.xz@gmail.com,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci-msm: Do not reset the controller if no card in the slot
Date: Wed, 20 Jul 2016 13:57:19 +0300 [thread overview]
Message-ID: <578F590F.1070706@intel.com> (raw)
In-Reply-To: <20160718174619.GI13516@tuxbot>
On 18/07/16 20:46, Bjorn Andersson wrote:
> On Fri 24 Jun 09:24 PDT 2016, Georgi Djakov wrote:
>
>> The controller does not clear the "reset bit" when it is reset without
>> a card in the slot. Because of this, the following error message is seen
>> while booting with no plugged SD card.
>>
>> mmc1: Reset 0x1 never completed.
>>
>> Add the SDHCI_QUIRK_NO_CARD_NO_RESET quirk to avoid this.
>>
>> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
>> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
>
> Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Be aware that SDHCI_QUIRK_NO_CARD_NO_RESET is not well implemented. It can
result in ->get_cd() being called under spinlock which could be a problem if
a card detect GPIO is used and might sleep. On the other hand, if you are
not using a card detect GPIO then it shouldn't be a problem.
Otherwise:
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> Regards,
> Bjorn
>
>> ---
>> drivers/mmc/host/sdhci-msm.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
>> index ac5700233e12..c613137ae91e 100644
>> --- a/drivers/mmc/host/sdhci-msm.c
>> +++ b/drivers/mmc/host/sdhci-msm.c
>> @@ -477,6 +477,7 @@ static const struct sdhci_ops sdhci_msm_ops = {
>>
>> static const struct sdhci_pltfm_data sdhci_msm_pdata = {
>> .quirks = SDHCI_QUIRK_BROKEN_CARD_DETECTION |
>> + SDHCI_QUIRK_NO_CARD_NO_RESET |
>> SDHCI_QUIRK_SINGLE_POWER_WRITE,
>> .ops = &sdhci_msm_ops,
>> };
>
next prev parent reply other threads:[~2016-07-20 11:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 16:24 [PATCH] mmc: sdhci-msm: Do not reset the controller if no card in the slot Georgi Djakov
2016-07-18 17:46 ` Bjorn Andersson
2016-07-20 10:57 ` Adrian Hunter [this message]
2016-07-23 9:37 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578F590F.1070706@intel.com \
--to=adrian.hunter@intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=georgi.djakov@linaro.org \
--cc=iivanov.xz@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).