From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753379AbcGTLCG (ORCPT ); Wed, 20 Jul 2016 07:02:06 -0400 Received: from mga14.intel.com ([192.55.52.115]:7815 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751510AbcGTLB4 (ORCPT ); Wed, 20 Jul 2016 07:01:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,393,1464678000"; d="scan'208";a="737139383" Subject: Re: [PATCH] mmc: sdhci-msm: Do not reset the controller if no card in the slot To: Bjorn Andersson , Georgi Djakov References: <1466785499-7563-1-git-send-email-georgi.djakov@linaro.org> <20160718174619.GI13516@tuxbot> Cc: ulf.hansson@linaro.org, iivanov.xz@gmail.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <578F590F.1070706@intel.com> Date: Wed, 20 Jul 2016 13:57:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160718174619.GI13516@tuxbot> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/07/16 20:46, Bjorn Andersson wrote: > On Fri 24 Jun 09:24 PDT 2016, Georgi Djakov wrote: > >> The controller does not clear the "reset bit" when it is reset without >> a card in the slot. Because of this, the following error message is seen >> while booting with no plugged SD card. >> >> mmc1: Reset 0x1 never completed. >> >> Add the SDHCI_QUIRK_NO_CARD_NO_RESET quirk to avoid this. >> >> Signed-off-by: Ivan T. Ivanov >> Signed-off-by: Georgi Djakov > > Tested-by: Bjorn Andersson Be aware that SDHCI_QUIRK_NO_CARD_NO_RESET is not well implemented. It can result in ->get_cd() being called under spinlock which could be a problem if a card detect GPIO is used and might sleep. On the other hand, if you are not using a card detect GPIO then it shouldn't be a problem. Otherwise: Acked-by: Adrian Hunter > > Regards, > Bjorn > >> --- >> drivers/mmc/host/sdhci-msm.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c >> index ac5700233e12..c613137ae91e 100644 >> --- a/drivers/mmc/host/sdhci-msm.c >> +++ b/drivers/mmc/host/sdhci-msm.c >> @@ -477,6 +477,7 @@ static const struct sdhci_ops sdhci_msm_ops = { >> >> static const struct sdhci_pltfm_data sdhci_msm_pdata = { >> .quirks = SDHCI_QUIRK_BROKEN_CARD_DETECTION | >> + SDHCI_QUIRK_NO_CARD_NO_RESET | >> SDHCI_QUIRK_SINGLE_POWER_WRITE, >> .ops = &sdhci_msm_ops, >> }; >