From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751190AbcGTQbd (ORCPT <rfc822;w@1wt.eu>);
	Wed, 20 Jul 2016 12:31:33 -0400
Received: from foss.arm.com ([217.140.101.70]:43444 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752388AbcGTQbY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 20 Jul 2016 12:31:24 -0400
Subject: Re: [PATCH v15 04/10] arm64: Kprobes with single stepping support
To: Catalin Marinas <catalin.marinas@arm.com>
References: <1467995754-32508-1-git-send-email-dave.long@linaro.org>
 <1467995754-32508-5-git-send-email-dave.long@linaro.org>
 <578FA238.3050206@arm.com>
 <20160720162827.GF25890@e104818-lin.cambridge.arm.com>
Cc: David Long <dave.long@linaro.org>, Huang Shijie <shijie.huang@arm.com>,
        James Morse <james.morse@arm.com>, Pratyush Anand <panand@redhat.com>,
        Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com>,
        Will Deacon <will.deacon@arm.com>, William Cohen <wcohen@redhat.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Steve Capper <steve.capper@linaro.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Li Bin <huawei.libin@huawei.com>, Jisheng Zhang <jszhang@marvell.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Vladimir Murzin <Vladimir.Murzin@arm.com>,
        Petr Mladek <pmladek@suse.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Jens Wiklander <jens.wiklander@linaro.org>,
        Robin Murphy <robin.murphy@arm.com>, Mark Brown <broonie@kernel.org>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Dave P Martin <Dave.Martin@arm.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        yalin wang <yalin.wang2010@gmail.com>, Yang Shi <yang.shi@linaro.org>,
        Zi Shen Lim <zlim.lnx@gmail.com>,
        John Blackwood <john.blackwood@ccur.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>,
        Adam Buchbinder <adam.buchbinder@gmail.com>,
        Christoffer Dall <christoffer.dall@linaro.org>
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <578FA754.7050208@arm.com>
Date: Wed, 20 Jul 2016 17:31:16 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.7.0
MIME-Version: 1.0
In-Reply-To: <20160720162827.GF25890@e104818-lin.cambridge.arm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20/07/16 17:28, Catalin Marinas wrote:
> On Wed, Jul 20, 2016 at 05:09:28PM +0100, Marc Zyngier wrote:
>> +static inline unsigned long min_stack_size(unsigned long addr)
>> +{
>> +	unsigned long size;
>> +	struct kprobe_ctlblk *ctl;
>> +
>> +	if (on_irq_stack(addr, raw_smp_processor_id()))
>> +		size = IRQ_STACK_PTR(raw_smp_processor_id()) - addr;
>> +	else
>> +		size = (unsigned long)current_thread_info() + THREAD_START_SP - addr;
>> +
>> +	return min(size, sizeof(ctl->jprobes_stack));
>> +}
> 
> We could drop the local ctl pointer:
> 
> 	return min(size, sizeof(((struct kprobe_ctlblk *)0)->jprobes_stack));
> 
> If you add a log, I'll push the patch on top of the kprobes branch.

Sure, I'll write that now.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...