From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755471AbcGTWQB (ORCPT ); Wed, 20 Jul 2016 18:16:01 -0400 Received: from mail-sn1nam02on0103.outbound.protection.outlook.com ([104.47.36.103]:18489 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754665AbcGTWP5 (ORCPT ); Wed, 20 Jul 2016 18:15:57 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=waiman.long@hpe.com; Message-ID: <578FF813.3040901@hpe.com> Date: Wed, 20 Jul 2016 18:15:47 -0400 From: Waiman Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12 MIME-Version: 1.0 To: Christoph Lameter CC: Tejun Heo , Alexander Viro , Jan Kara , Jeff Layton , "J. Bruce Fields" , , , Ingo Molnar , Peter Zijlstra , Andi Kleen , Dave Chinner , Boqun Feng , Scott J Norton , Douglas Hatch Subject: Re: [PATCH v3 1/4] lib/dlock-list: Distributed and lock-protected lists References: <1468604383-40362-1-git-send-email-Waiman.Long@hpe.com> <1468604383-40362-2-git-send-email-Waiman.Long@hpe.com> <20160718233803.GN3078@mtj.duckdns.org> <578E7497.30602@hpe.com> In-Reply-To: <578E7497.30602@hpe.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [72.71.243.182] X-ClientProxiedBy: CY1PR14CA0033.namprd14.prod.outlook.com (10.163.13.171) To CS1PR84MB0311.NAMPRD84.PROD.OUTLOOK.COM (10.162.190.29) X-MS-Office365-Filtering-Correlation-Id: ab1da15a-24f9-47b9-3bed-08d3b0eb6aa9 X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0311;2:BXwOf//YZY4MTwYNPeBNdR2YyB1gAsOgfH9fJI44XZEkq9M3u0LcSt3zlKB5JmWiEaEU1DQZnvo3zMIDGYyfX1I8Y7vLmmLg71z859Drq1gF9L3yQ8BQ1QJpm2qMoHH+KQ6oCtpxjDzwfVLUgUOcE4c1rwh8Tqe1MZVVxKgflbjzQH7Ra9lnHv+groS/3MaN;3:AIgS/xzQvlRGn92lSdL+AE/PvqCAJ6vy1FKjVRQQLk+xyGFEws07k6m29ONWh364qAj+GAEgFSqCuUgMB1oaPw15ifeOzdpVJ9DlzcMYE5XbvXjxXLCQiOi0dAWi0CzY;25:hJrhmOsjPzUrYsqZNsD6zao6bpuLlcZdOcf2T8CfjYtpcK7gv2t4Sabo73lgYNgCUTGR48t8BegeXD+zzMIK0jg7d2QSYWOVXvqzQKnjgzBKhO19KoBiEmcT36ORmF49c3za8tZg79Hf0vIzPm48Dcn70XXzfgqlyeOpmfKvGVxlN/IhwOgV6pt2AtiBcsxUU9dI7WanmQCaPPqWwCh4MEoCnz+Oqj/q/d9DNF9dUdvjFWoNJ/o6FljHc62CQgER628xdvPafzo0BCo9QeVzsigj3PT4yKdkmECg3ESF4bHu7rw36dNEEOevmaw+MVkXQweJ5mQmGgiIhBE5fr/QGBUPfj2ZZVfBtn/dFczXsJxQ5KRLMOd5r4cv9+ChxF9SN3ytp3w9z/9+KQYG3dzu3kNl5OGeGVOIrHJiAw2XkyI=;31:xDb+ohGh/9fqqkNG7LXdgH3cLDdOTM7MduwSEh/nA0LNZh51rx83XS/KRGbXtRh9+0u5r0spQx39eZW2CkUWb2H16A9lIfQaTmVltxSP4SJ4lFxaxJpH5EhpjgF/w+a+2rH8g8bz3g8AZFxKCvN3S5zU0OGAONFPvkzfovSxEhdbyISF9maDkPCaTO6IbzOHtjQd0kMIo+y1cETPaHExCQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0311; X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0311;20:ZlLApDOwLppqL51hZKtxcB1B/1QPHSslDAeaUe+c2MyPh4uYtxtTA3K3/7E2sVOU10g/QRd2OBtwLoSqywLhUl4YTaLYFCAcQ6Q7xNvACHqFBlvc/z+F+G3n/RuL6SBXgoZ36FNDNYGONE31d/8A4jPPBfnTo0aTS76j7OCqIKSZ1Y72j89x7phVhSWgf0k22ng26o71jImKY4lHZl4/fc08+lQRf+qhDKLseLaGNwdkwYgy+iIW2kZcbFrMaydqznX+bmT2d5fdv4I4hQ5AqfzPlVH/M7TADHCWryEIjcBvpoJE2lbA3do20eOQbU6lUq77OccCgDLCgQRJC/Bi4yLIBx7/WIuByL3Aa8rJR8i4Upjh3jVJl3C92n7NcAwahCDClUXlvNl4OUlbtF5Wzagxez/0jvgpeW/THupN1RalAfk1UBLRj5bbwa/hGjcrk2M7VQvW15yCkS2z+DqRhQEecG0hT0sFelMTMpcaBKLjJMk4PioouSmKsOtUlJnR;4:rvbQZYHWyBCGPdbpoYj1c28cwohDiv9bLxNtXUM6Gza6tRIu5y6GNoQwN4Nnqfit7eXdUuwK1265Mz0GKhca2DvPvUksvw8J54s5s38trrNt+GLYnQF1PeLbiqWNiDLWCYuoWRmZcQKdns5FlFp8uhWLZdhVlBBXUSoCmm9MRXBWOusSqLrev6zr8rwSRhGix4MFBwkJB5vqzPII0hbE0mwuidL3thecNANaWboIENlvYFmYtgL3c03NnoeAUg/Bkik+rB/DQAgD2BrOKzjecsc57vapzsgl8Yt7ClFrhbN/4FkBwYc+acBJTRWREP6bmziFDMTyDzyDUC9XLRDCMlSx8npmQcf7JrX4m8DKsblA17/lVFaYQVIx+ehCNEZlucy7OZE3ZMcS1+G/Frkrgg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:CS1PR84MB0311;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0311; X-Forefront-PRVS: 000947967F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(377454003)(199003)(24454002)(76104003)(189002)(97736004)(33656002)(189998001)(65806001)(81156014)(65956001)(92566002)(66066001)(117156001)(68736007)(586003)(3846002)(81166006)(6116002)(54356999)(230700001)(110136002)(50466002)(59896002)(47776003)(36756003)(86362001)(42186005)(23756003)(106356001)(64126003)(305945005)(2950100001)(7736002)(77096005)(105586002)(7846002)(4326007)(87266999)(76176999)(2906002)(8676002)(80316001)(50986999)(65816999)(4001350100001)(83506001)(101416001)(93886004);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0311;H:[192.168.142.174];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;CS1PR84MB0311;23:fJQxGnMXHYy86m7T7TVe+oaVzcfkY9b5WhxyT47?= =?iso-8859-1?Q?/79nsD+Mtrr6QzimvDu+fHrnZgeBGAHuWFQu1D4Rj3MN7QTqzq00vIyLC1?= =?iso-8859-1?Q?X6DWS4Lfifc/TMDL7zWwc5lS13tereyTjtroTGsldQ0c0CU6UhlAluKj3J?= =?iso-8859-1?Q?2pizSCdcuSNdvvAxVZSjCJGe+zZ9PwdjwPCNCfjp60veKrnqEINX5tVklF?= =?iso-8859-1?Q?mdcfY2w8vCIfYCK2ZomHKGq0S9MSRhdgEogOh5bLCObQ8qfhaPVh5rvyKk?= =?iso-8859-1?Q?nzAvv9qX7fQe0pp8SCK4WgUfStxjXD5z6NyafWIwBVvNOEnRZWMNLwaB6L?= =?iso-8859-1?Q?HGc4fWUgML/BQXH0qpe6xyFOchRHapqlrWHfGSQSKNjW+neXAbW/ZHf3zO?= =?iso-8859-1?Q?8KtlfIRGtECiHIRH/HhpioOxOO5O7sshqOjTp93LAtBLU6DRU0tkFkwYso?= =?iso-8859-1?Q?sj7CFwl9wfqt6cl3EfEc9J5rI/Hdz2ZXQ+eN5CHP3F5cQHa1mhRhQdorij?= =?iso-8859-1?Q?WZv33yPWdcO5dCFJFq6qnysVmAZalgGiz18V9VNdP7ErMW6+GrpyZZJWEw?= =?iso-8859-1?Q?q5ucprqsKSrj9MU28q/mzriMDGfH10SYbQs6Qx755yHMkXddXxXWOXoU4l?= =?iso-8859-1?Q?5tMGwj33ztDcF8CDICQ6q2qMQzedcs67Np3m9U6bKpPE7pazef83Ijs026?= =?iso-8859-1?Q?MW9U2UhMI/AMz+x72lrP4oUQPvXmGUfec3B5ygi8h1cUGpPUgIEtYLmEEk?= =?iso-8859-1?Q?zMcVeLSg0RYUJdHOFF3pEjj77bCQhbfEkIxPF8FQdMf8GJO4C8sHuV0Qw9?= =?iso-8859-1?Q?uA+6v9sNwble8aFarNDDV1drQsJ4zFACrvArHv5mBezBy0PuxYG8WLS9GV?= =?iso-8859-1?Q?Lzn66Y58Td4TqPx1kvx1DOHxy/ETuXqAe+i1iNmJhds+nncfUmD3JXYVoI?= =?iso-8859-1?Q?8X5hpXwh3ZsGUkSs6G41aTpV8XLSdKEachcNkci1nXpfovsp0Fj9h24uPt?= =?iso-8859-1?Q?4D8icl7MaASCvWlD3X+nZVnyuONRk+ehUo1/HcFpaEKEUaidZsbTcFPuVA?= =?iso-8859-1?Q?F1auDFkrlXHpq1G6E+MOXMgdd8KwQmn7v7Uzv23FrXZ6LlvPHwPXOidL2Z?= =?iso-8859-1?Q?HNEPllDF+/01AP2g2c2bC3r5uclvep7Z1FMdgDu12hTCX6GFJGX9xobYO8?= =?iso-8859-1?Q?L96CAP5SeW7soIej2bK91V0YxyrlDPpO3kp9Mn88Qbr4zlAGpFg6Ua5eeU?= =?iso-8859-1?Q?33SqJXGr/yNXGbb5xuW2LAKsdUNVtyHa5iP8/rbHOvU9fYzbeyNgQT1YT4?= =?iso-8859-1?Q?gJ9+Tb4smwj6BM+v7/uq9AwVCVqeFj7mkWpB2rEj9SMXQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0311;6:YjjHzDUgomNXw90qPpB72BH86uwUhPz+9J5lnU3ub5DUhpEbh1LaF5Fwr9dDGd3WF0WwH7+9K7WR6rg3kVO2c/1rTrmrj2x2uAZit8EPiXE4OCUgCx9sbqxi41Y/fQz+BrJvSMTEPmASh2K1HfZoASS8y8Bd7LbGo7myBB2eOVMCOpB9CEU8sDrG+HMZh0RtFJNvkGRcuY9JAO3vQ07WEhQ1QjrUqEA9iacmLnkJqFGS1ykQFVNpgUk64xLfKPnEv3QN+6I1YknjsuBB6/KBOYyZuH2iLFyRELqZgf0bvrmuHLCfZzd6Q32mx6JUpgBJusAv3uvMkeDRz3tI8BZqoA==;5:Bfd7qyAyMi6gr8WX+yb6XhWIn+kAslVSbeaHPrwPpiCc0kgI6SBNSMA8gKCoFtXP5S7Nfqn8Pn+uuoqHb/7yX2CFYjkuWXCjtCRWZJBSsHs0cSCBHDIDq3VqKe+BOw90mh/YHQWg8Se7CqI6uJpkfg==;24:gcIz/QZGCSIIgi1f8X/pBML5une9Jd2RM1frj0FEzqKIxx2gFjNJdhM9s5ezW1V5vdwF5OnTuHZP0+dlqimI/fUgsczVBCMMNBqcShXuNlo=;7:NisYYaE/dt7kmfarbJOA6lHXbCU261tuXzObka7vfNU7kNDAVD1O8K4Sli6fYEt2O+/+Ka9AUamZV1PLyS3xchVGMvqlUF+zQhSzHt2+db93ltEJ7jHU98rEYrvHFiQrPJpDLPMnGowNo4aNzJP4yfiGFoq7WNhVbd1xKChrFBfvqij2bvAMjWkqK/rDOprZmU1TSEX7EXl3B6apOwVCRTP4t6itstSiagafqFy+N+zJmsuJTTTwHoeBq2MKkXUO SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2016 22:15:52.7668 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0311 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/19/2016 02:42 PM, Waiman Long wrote: > On 07/18/2016 07:38 PM, Tejun Heo wrote: > >>> +/* >>> + * include/linux/dlock-list.h >>> + * >>> + * A distributed (per-cpu) set of lists each of which is protected >>> by its >>> + * own spinlock, but acts like a single consolidated list to the >>> callers. >>> + * >>> + * The dlock_list_head_percpu structure contains the spinlock, the >>> other >>> + * dlock_list_node structures only contains a pointer to the >>> spinlock in >>> + * dlock_list_head_percpu. >>> + */ >> The more I think about it, the more bothered I'm about the dlock_list >> name. For the most part, this isn't different from other percpu data >> structures in the kernel. Sure, it might benefit from doing Nth cpu, >> but so are other percpu data structures and it's not just "distributed >> lock" list either. The list itself is percpu, not just locking. Can >> we please go back to percpu_list? Christoph, what do you think? >> > > As I said before, I don't mind reverting the name back to percpu_list. > I am just waiting for a final agreement. > Christoph, are you OK with Tejun's request to revert the name back to percpu_list? Or do you still think the current name is better? I am almost done with my next version of the patch. This is the only thing that is still outstanding. Thanks, Longman Thanks, Longman