From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752880AbcGUObr (ORCPT ); Thu, 21 Jul 2016 10:31:47 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:34067 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751553AbcGUObo (ORCPT ); Thu, 21 Jul 2016 10:31:44 -0400 Subject: Re: [patch] Disable PMBus status check for DPS400 PSU controller To: Vadim Pasternak References: <1469112953-77032-1-git-send-email-vadimp@mellanox.com> <5790D10A.9070404@roeck-us.net> Cc: "jdelvare@suse.com" , "linux-hwmon@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jiri@resnulli.us" From: Guenter Roeck Message-ID: <5790DCBD.3030903@roeck-us.net> Date: Thu, 21 Jul 2016 07:31:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/21/2016 07:08 AM, Vadim Pasternak wrote: [ ... ] >>> }; >>> >>> diff --git a/drivers/hwmon/pmbus/pmbus_core.c >>> b/drivers/hwmon/pmbus/pmbus_core.c >>> index ba59eae..3d98070 100644 >>> --- a/drivers/hwmon/pmbus/pmbus_core.c >>> +++ b/drivers/hwmon/pmbus/pmbus_core.c >>> @@ -1931,8 +1931,11 @@ EXPORT_SYMBOL_GPL(pmbus_do_probe); >>> int pmbus_do_remove(struct i2c_client *client) >>> { >>> struct pmbus_data *data = i2c_get_clientdata(client); >>> + const struct pmbus_platform_data *pdata = >>> + dev_get_platdata(&client->dev); >>> hwmon_device_unregister(data->hwmon_dev); >>> kfree(data->group.attrs); >>> + kfree(pdata); > > So, if I use in allocation > pdata = devm_kzalloc(&client->dev, > sizeof(struct pmbus_platform_data), > GFP_KERNEL); > I also can drop the above three lines, right? > Correct. Guenter