From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753384AbcGVBbd (ORCPT ); Thu, 21 Jul 2016 21:31:33 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:46042 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751259AbcGVBb3 (ORCPT ); Thu, 21 Jul 2016 21:31:29 -0400 Subject: Re: [PATCH v4 0/3] hwmon: xgene: Add support for X-Gene hwmon driver To: Hoan Tran , Jean Delvare , Jonathan Corbet , Rob Herring References: <1469140653-2287-1-git-send-email-hotran@apm.com> Cc: Jassi Brar , Ashwin Chaugule , Duc Dang , lho@apm.com, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org From: Guenter Roeck Message-ID: <5791774C.4010804@roeck-us.net> Date: Thu, 21 Jul 2016 18:30:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1469140653-2287-1-git-send-email-hotran@apm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/21/2016 03:37 PM, Hoan Tran wrote: > This patch set adds hardware temperature and power reading support for > APM X-Gene SoC using the mailbox communication interface. > For device tree, it is the standard DT mailbox. > For ACPI, it is the PCC mailbox. > > For ACPI, this patch is built on top and depends on patch[1]: > [1] http://www.spinics.net/lists/linux-acpi/msg66041.html > - [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2 > One thought: You might consider taking ACPI support out of the driver for now, and add it back in after the dependent patch was accepted. Guenter > v4 > - Return 0 if driver registers successfully > > v3 > - Order include files alphabetically > - Use sign_extend32() to decode temperature > - Use DEVICE_ATTR_RO() for temperature and power attributes > - Temperature and power attributes start with index 1 > - Use !!amsg->param2 > - Fix checkpatch WARNING with --strict flag > - Use hwmon_device_register_with_groups() > - Check invalid sensor data > > v2 > - Increase power reading accurateness by using 2 registers > (a register for Watt, another for milli-Watt) > - Remove power reading for SoC > - Fix review comments from Guenter > > v1 > - Initial > > Hoan Tran (3): > Documentation: dtb: xgene: Add hwmon dts binding documentation > hwmon: xgene: Add hwmon driver > arm64: dts: apm: Add X-Gene SoC hwmon to device tree > > .../devicetree/bindings/hwmon/apm-xgene-hwmon.txt | 14 + > Documentation/hwmon/xgene-hwmon | 30 + > arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 5 + > arch/arm64/boot/dts/apm/apm-storm.dtsi | 5 + > drivers/hwmon/Kconfig | 7 + > drivers/hwmon/Makefile | 1 + > drivers/hwmon/xgene-hwmon.c | 755 +++++++++++++++++++++ > 7 files changed, 817 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt > create mode 100644 Documentation/hwmon/xgene-hwmon > create mode 100644 drivers/hwmon/xgene-hwmon.c >