From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752847AbcGVGgq (ORCPT ); Fri, 22 Jul 2016 02:36:46 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:38142 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbcGVGgn (ORCPT ); Fri, 22 Jul 2016 02:36:43 -0400 X-AuditID: cbfec7f4-f796c6d000001486-92-5791bef7c37d Message-id: <5791BEF3.5060404@samsung.com> Date: Fri, 22 Jul 2016 08:36:35 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: "H. Nikolaus Schaller" Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Richard Purdie , drivshin.allworx@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, kernel@pyra-handheld.com, marek@goldelico.com, letux-kernel@openphoenux.org, Andrey Utkin Subject: Re: [PATCH v6 2/2] Bindings documentation for ISSI is31fl319x driver References: <403335d22f6a8e131bc44077f97e499970e61245.1468928850.git.hns@goldelico.com> <20160720012457.GA10971@rob-hp-laptop> In-reply-to: <20160720012457.GA10971@rob-hp-laptop> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRmVeSWpSXmKPExsVy+t/xa7rf900MN+idrmXx/9s1Fov5R86x WiyePIvdov/NQlaLH9u+Mlmce7WS0eLS1xqLrX8usVlc3jWHzWLrm3WMFv+WbmGzWHr9IpPF hOlrWSz+79nBbrF711NWB36PNfPWMHpc7utl8lj0cj67x85Zd9k91rw/xeyxcvkXNo9NqzrZ PFom7WL3+NLSzOyxZ/4PVo/Pm+QCuKO4bFJSczLLUov07RK4Mo6vX8lYcIWzonnPJcYGxp/s XYycHBICJhKzpvxggbDFJC7cW8/WxcjFISSwlFHi49fb7BDOM0aJHTc62UCqeAW0JHrOPWEC sVkEVCU2P5wBFmcTMJT4+eI1WFxUIELiz+l9rBD1ghI/Jt8D2yAioCfR+f0PC8hQZoHLzBK3 J20FKxIW8JXY1fqVFWLbakaJ70dug93HKWAssenFG2YQm1nAWmLlpG2MELa8xOY1b5knMArM QrJkFpKyWUjKFjAyr2IUTS1NLihOSs811CtOzC0uzUvXS87P3cQIibovOxgXH7M6xCjAwajE w3vi6YRwIdbEsuLK3EOMEhzMSiK883dPDBfiTUmsrEotyo8vKs1JLT7EKM3BoiTOO3fX+xAh gfTEktTs1NSC1CKYLBMHp1QD41qXxlQW79tb1HicGDOlti9Ywui1aiZvqsHn+rD0LwGzHvBv 8Dx5UmTXXr+WT00Vuqu2HGFiY2GoYlmVvW/Hyu8HV60S2fhgT0/Y4indtqfmCT5RC9sxwXXi rx8uPesOqf3ymGXdFjr/bJGOzzEnpiXvHlbNNkvZzMQQttr0elrca4vHjRYTDymxFGckGmox FxUnAgCv+krAtgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/20/2016 03:24 AM, Rob Herring wrote: > On Tue, Jul 19, 2016 at 01:47:31PM +0200, H. Nikolaus Schaller wrote: >> Signed-off-by: H. Nikolaus Schaller >> --- >> .../devicetree/bindings/leds/is31fl319x.txt | 59 ++++++++++++++++++++++ >> 1 file changed, 59 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/is31fl319x.txt >> >> diff --git a/Documentation/devicetree/bindings/leds/is31fl319x.txt b/Documentation/devicetree/bindings/leds/is31fl319x.txt >> new file mode 100644 >> index 0000000..03287c0 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/is31fl319x.txt >> @@ -0,0 +1,59 @@ >> +LEDs connected to is31fl319x LED controller chip >> + >> +Required properties: >> +- compatible : Should be any of >> + "issi,is31fl3190" >> + "issi,is31fl3191" >> + "issi,is31fl3193" >> + "issi,is31fl3196" >> + "issi,is31fl3199" >> + "si-en,sn3199". >> +- #address-cells: Must be 1. >> +- #size-cells: Must be 0. >> +- reg: 0x64, 0x65, 0x66, 0x67. > > This is an OR or AND? OR it seems. With that, Nikolaus, could you please make it explicit? > > Acked-by: Rob Herring > > -- Best regards, Jacek Anaszewski