From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751966AbcGVPDC (ORCPT ); Fri, 22 Jul 2016 11:03:02 -0400 Received: from mail-db5eur01on0105.outbound.protection.outlook.com ([104.47.2.105]:44640 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751705AbcGVPC7 (ORCPT ); Fri, 22 Jul 2016 11:02:59 -0400 X-Greylist: delayed 59998 seconds by postgrey-1.27 at vger.kernel.org; Fri, 22 Jul 2016 11:02:59 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: + mm-kasan-switch-slub-to-stackdepot-enable-memory-quarantine-for-slub-fix-2.patch added to -mm tree To: Alexander Potapenko References: <578fc651.63fI2iyJ8CTxPKUJ%akpm@linux-foundation.org> <57908C79.2020105@virtuozzo.com> CC: Andrew Morton , "Kirill A. Shutemov" , , Michal Hocko , , David Rientjes , , LKML From: Andrey Ryabinin Message-ID: <57922E3C.9070207@virtuozzo.com> Date: Fri, 22 Jul 2016 17:31:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM2PR09CA0020.eurprd09.prod.outlook.com (10.161.22.158) To HE1PR0801MB1979.eurprd08.prod.outlook.com (10.168.94.149) X-MS-Office365-Filtering-Correlation-Id: 775bccf1-a4f4-4a00-d93f-08d3b23cb48a X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1979;2:Qu69N2SIaim7yyjvw3fHjUNeMFm1wl+cXPMktIe+9IWHlJGgbCH2PUa7NafxfATTg06bm3IK9TSMw4SFRE0Aw8Wb1NvAwz11inPVf1Za7fnkIxCv5eFTHsttpuG7QU9ikAHBX1bSMvnj5FU9PsO4h/cEutGfkUK2HrTFkO3yZE3OZvL0yzOgk+3bJhNj/pTl;3:9vA1RLm8EANpccyf1jdqtmgIa/FSn7JQ3h4jpLysvgy+gfI+np4k9KQeG/jltR6AVHnJ27tIu89EBPs4J63G9q3w3tbrP3j2qJnc/L7hx4Qh5WWmtjky35FsOEBHM9C8;25:k+wREqBMMJlmxkyWiUqHO4Fgs7Ey59YDaRDzHQYJXiu16hRV94WXYQy3WN5+BqbiMyPmXoPyey94KmfwGx+FTA8iUx6g8m3kr2nzLu5fuT0o672riShZI4DzDB/5dWXTD/7G2DFSfon30Sr0ElihGK3Ciytan1iHw4LsdGaPG7RuCPs95zw4t46Z3Sa9dORiUFGERCq85Ik8nJQj5Y/32gg8zFDqjG2jIR4UvnPAlZ/jIknB3H+SUua/rz9a3ujRbjcYOBfF4n9t0ACcacsJApa7j21SeZmtTdDpQGb/FGRbExl9RzwAoGbPMybBpopD9psjDj/RkeAMpnCCAj88qQnU1xL9r1h8JeW/V8WAXVV65NhN4SaAoJABJbM9YeiUtDwRMGmreITNa9Ljgxq9Z5E6MRkLZN1T6NhjDLtix+Q= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1979; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1979;31:yc+uNZsqLBRI2VaUa9H7bJ7VlEnSIDoR+G2owuJb1qYYNsiDWNit+hNA+fD3kijI/bcbAMElOHtk5FGZ5kZHz5UH6CaJS/wnBjPoKoN+pwskyU3uCPaDzL+iftkv0iz6RUILSL25Z3rKzs4I29Wf26FRjJUq8rv0JsDuUvSPhcRvST//DzTkS9wxQSRcrRUSN8C1FK2chfDXM6olNvoP2A==;4:bog3l/HJ2Y52f2TOo3Gn8YAdymWLHkXLR3ONLc2C49i6KeIYjLdhedbcPHjdY22w2i9YfIKVt8hk+nARBKSPCs5m/Ut6UdiYrAbpP2s1Md3sNqZpke3/gilI7TPtEQx+Lftk+NBg3SPlg94Ld/39bm4u9DO5ZcleR+Fut77ZT8S+TBlx0ogPFcqkApA8zbJDzC1HMWOWrLyoQ/n8zgENr9U2ZeBLb5Pyej0Hi4v5ZPHkktvpfV5a9cn23VyETUSs9gjcXoZMN1Eeelvz8/fYT0Ex4NceHRFZ41gFuRFI0ePfty9cJaOcP9HmCQbdcFNAWyiA1IEDdbWhUBvDZcHud8h8LGOxB75kPi+rTIDHNf6/wNJNSIsfD1VO/H7i0fgHrURwrWk2ZzZp1cEd5AEZhKHiRjpLGpsHWMj83gL5pr4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041072)(6043046);SRVR:HE1PR0801MB1979;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1979; X-Forefront-PRVS: 0011612A55 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(189002)(199003)(24454002)(377454003)(64126003)(2906002)(110136002)(8676002)(15975445007)(77096005)(23676002)(4326007)(189998001)(4001350100001)(101416001)(42186005)(50986999)(76176999)(54356999)(33656002)(65816999)(81166006)(81156014)(7846002)(36756003)(87266999)(66066001)(65956001)(65806001)(575784001)(97736004)(92566002)(15395725005)(19580395003)(230700001)(80316001)(105586002)(19580405001)(6116002)(106356001)(47776003)(50466002)(2950100001)(86362001)(7736002)(68736007)(83506001)(305945005)(59896002)(230783001)(3846002)(586003)(99136001);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0801MB1979;H:[10.30.19.223];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA4MDFNQjE5Nzk7MjM6VlBycG5xMVdLOGtQVjdMN2NuajBWK2Z3?= =?utf-8?B?RmROTEIxbkhXZmFidjIrbFBXdE04U21HMm9qRHFmaVN1ZytpWjlhdVQybmhz?= =?utf-8?B?WXRkMnYzYUN2dTduYmp2N1hZUTB4YkU2SklpbXZqSGZTYXFXdXdFbXRQdW5a?= =?utf-8?B?VUJQQnI2TnEyaGJYekVNRVMrZVBxNzhvTCs2cFZITXJiaXBQTHEya1hZV3c0?= =?utf-8?B?WFlpSGIyMHhIcm9zME1rbUZxaVpCamQxL3dzYWEvSUNWUWJFNjhFNWt3a20x?= =?utf-8?B?RlIyUTYySUY3RU9YMU16SVUyV0VXRy9CUDFaNnFoeG5EMnpEakNaUVZYWDU5?= =?utf-8?B?MXM1NER4YVVxVmRRRG45Vjc3c1MwUmJoSHUvdEJUZlNsUms4S0djbmR3NEV3?= =?utf-8?B?QWh5Y1EyQ0ZHRHpTWjd2bFBuTGJZMUJwUk5PK0xoUmlGMWd0d3VLN3hDaU4w?= =?utf-8?B?MUV1VEhzNkg1MEdBZHA3QXdWZmxFcTgwWllLZ0tMVzNwMGtTenZZQzZxanhC?= =?utf-8?B?YlNSaEgvUGMrRUk1VWUxaGN3Y2RPWDFGSERBRDdQQzF3c1dLQTYxa2xsQWNC?= =?utf-8?B?Vk1lc1g4VE5xN3IzMGxOV1paNzI3blNFcnB1U2wvRU01R1dvVzBZSXM2eHpM?= =?utf-8?B?VFRiK3RPUXdZRlpHWHRWYllrT084dmZrRXZrdW9oK3NndWlPSU8zTGVTZjhu?= =?utf-8?B?aFIwc1VPZno1SjlTYkw2ajl3YkdMUHlJN2lyWUk1WGp6eVZzSi9mOEx2R2tv?= =?utf-8?B?TFBpaml1MGhBL1c0cU5ZVTM0clc0SjQ2WVBDbm1CdmRkV1lVaHlieWs4dkMy?= =?utf-8?B?K3NqaE1kbGJQVUpKVmV2YWR1QUZGcGFuUkMzVWlmdjFRbitRMVcyZ2dhRFNV?= =?utf-8?B?a21xTVUzU1J4QjFYVTArdFphL01ucjdrbERVRnZuMDNJOGdMQ0F6N1NRN29n?= =?utf-8?B?bWhiRndkSVpxTjczd0pOM1oycXViM3gwR0tSN3hXdVNiVTU3aHlJUnVsQXlj?= =?utf-8?B?a0NrM3d3U3JCUjZqaHNSclhBWHhDU1R2N2l0cG16K1lrSkFLeG9iTExoSFRJ?= =?utf-8?B?WnpNbVdzVWMzVzl4QlI4ZmpFMWZ0REljRUZVOVk1RXdvQUdUUnNNTTJzOWhm?= =?utf-8?B?SEk5YTZXRmUrVEtja2xCS0tpQzdqVmJINmhJdlZUMXljTE82KzNpZUd3TjdF?= =?utf-8?B?ZkE4L25sT284RUdrcnd6SW1PdG1QSTI5ZnBkUkRxN3BQY1ovYm1aZ1JYajBz?= =?utf-8?B?SktTZkhjSmdnM21RS3BwcWhrbFVmQkN0VGVlWC9CWGpoS1Z1MGZsRDNGSDh0?= =?utf-8?B?RTl2S3NtSStYdkNNTDRWeDA4Q1dLM29mVExnWCsrczVlT3lyQkdDQUN0bURF?= =?utf-8?B?S0VVSHgzM0ZqaW5wdUU3MXBXajlsQWZJWm5sQW1INGtLTk9VRkcyK0MvMURk?= =?utf-8?B?anZzQjdoZzU4eHIyQzRUK24wczRDUjR6UExPZDlDSXFoU1hhbGFpSzBvQXFO?= =?utf-8?B?Q1dnWHA1MFFXVWpUNFcvWDhMMmV5ZWlCb2hlQ09ySkVpbDVVOWVYZG05SUkz?= =?utf-8?B?STNSWE10ZnBsWkVZWkNzK3FENmxhRmRaZktrR1hiYzBKN0ZZY2dHd2xYNkRK?= =?utf-8?B?UzJzMW8wbTlGS2JLdEJYaUhWWERJNFJxd21QczZOaFFoVGhlMGtXYjRDRks2?= =?utf-8?B?YnJYQWhPTmVYcCsvU2xPM1BVVEpRUitrWEZQTUxTeFF0TUw5QWl4Smd4aHhk?= =?utf-8?B?QUlhMHg3Ync4eWNBcnNmNmtxT08vS01kUmV5NHZQZkFjaHBhZFhmcFhabFF5?= =?utf-8?B?Zkdzd0I3Q3NVZzRKUStETVBnNDhQckJDOFoxS2hLcUhBa3QyYzg5WWNsSW8v?= =?utf-8?Q?AghJlUTEMLmbGq3OPicFDo3UfDjU3w6wsN?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1979;6:qsHZzVJDKL/FZmy3N9IE6Qg2aBb44l3fsAOdbkdTb3yA+zwEhFXgdz7jFTZGFvcxvYANF8PTPINIIRV/dl1IGg8jhUc3mOyofg4l706JKd80slKRTU1IG+QxOJuCrh9ksnSxKvQnHEWtnIsuELiHVTTwHnGa0VEMQ1SKSD5HvHZSLzroDiSs4ltq7rS8XVxVKnnQlEnHAg4OapkDo5Uihg0yXxFpFuZEtCav9aXDbfLj01MeL+Zabx0UTC/ullbNW0tHmW+9Mj6n4QifqgK1B3hu8zrpC5AuIlQFTuKLW3Y4bJJdpuGHQg+ZvygvXFs8;5:oipY4qwncB51Ig1xlmzRoD8y/91BkIKrmTATfKKWLGaO5i2V27ztb3YvFS/lSg9yuUIUsDDNoR4QUPLAc65B5XrvosTrETijHAszkNs3PhEEW4fYMEQruwO40MA6cq7crxMdSyv2uJ0ePmXKoyqmPw==;24:/NkmY4oTVh6OkIx6Om02Zz9Hb4zj18AFBBQghDIV9c5psU0Cs9p4g766kecXzGqsBEVi22lUZqw2EWZMsNcf+L0oTCQom+dZ9+jsKjfY0V8=;7:gB5hx3hVJ78u3QqSaw0/WzcFjpj1f1sQmsLbuDvixwOUPrLjigxsDsPZTXZQKA5AGmRWhGzKr5kgv8fVIlZxBWuUxTnIMISbR/+RBOYUcvviOLE8cQrknjiZsFrQNN7iAWozKafaqqvOVMoHJdddUzT0Bfap9ugiIZZjGb6b6Us1tQcAjkhkkI0uLS4GOB47RAb4cYzWOjTG7pQ+mHciiYEHdQYKWT7f1ZE+pjoseBQqMOzw9133RnM48goCLSe0 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1979;20:PQorj7DY1+ufUU/MObDX+5GGzjHwnOg/eKmC8dTx+vaYkx+YpIOQ+OT2ACcQUyoftsGFlFM82fS6Yo7o8/0iUuwU9aANOSAshh+1+PrOGx7d7ast6wiO/Eumfh1k4O6bR5FZRLVbobDNpP/rp2eFYf5C2RCp058uHiZ/f73/bQE= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2016 14:30:17.3341 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1979 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/22/2016 04:32 PM, Alexander Potapenko wrote: > On Thu, Jul 21, 2016 at 10:48 AM, Andrey Ryabinin > wrote: >> >> >> On 07/20/2016 09:43 PM, akpm@linux-foundation.org wrote: >>> >>> The patch titled >>> Subject: mm-kasan-switch-slub-to-stackdepot-enable-memory-quarantine-for-slub-fix >>> has been added to the -mm tree. Its filename is >>> mm-kasan-switch-slub-to-stackdepot-enable-memory-quarantine-for-slub-fix-2.patch >>> >>> This patch should soon appear at >>> http://ozlabs.org/~akpm/mmots/broken-out/mm-kasan-switch-slub-to-stackdepot-enable-memory-quarantine-for-slub-fix-2.patch >>> and later at >>> http://ozlabs.org/~akpm/mmotm/broken-out/mm-kasan-switch-slub-to-stackdepot-enable-memory-quarantine-for-slub-fix-2.patch >>> >>> Before you just go and hit "reply", please: >>> a) Consider who else should be cc'ed >>> b) Prefer to cc a suitable mailing list as well >>> c) Ideally: find the original patch on the mailing list and do a >>> reply-to-all to that, adding suitable additional cc's >>> >>> *** Remember to use Documentation/SubmitChecklist when testing your code *** >>> >>> The -mm tree is included into linux-next and is updated >>> there every 3-4 working days >>> >>> ------------------------------------------------------ >>> From: "Kirill A. Shutemov" >>> Subject: mm-kasan-switch-slub-to-stackdepot-enable-memory-quarantine-for-slub-fix >>> >> >> This should be a separate patch. Stackdepot was added in cd11016e5f5212c13c0cec7384a525edc93b4921 >> which is in v4.6. > Andrey, do you think we need this patch? > I've posted the link to > http://article.gmane.org/gmane.linux.kernel/2266971 in the discussion, > and my patch seems to have fixed the problem. It fixed high memory consumption which is orthogonal problem. > Adding __GFP_NOWARN will mask further problems of the similar nature, > so I think we'd better avoid it. > How warning can help to detect such situations? Allocation failure doesn't mean that stackdepot consumes too much memory.