From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757821AbcHCMJn (ORCPT ); Wed, 3 Aug 2016 08:09:43 -0400 Received: from gloria.sntech.de ([95.129.55.99]:37139 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754542AbcHCMJj (ORCPT ); Wed, 3 Aug 2016 08:09:39 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Shawn Lin Cc: Doug Anderson , Brian Norris , Elaine Zhang , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: rockchip: Provide power-domains for sd/sdio/emmc controllers Date: Wed, 03 Aug 2016 14:07:42 +0200 Message-ID: <5792766.oYNWZEQPkG@diego> User-Agent: KMail/4.14.10 (Linux/4.6.0-1-amd64; KDE/4.14.22; x86_64; ; ) In-Reply-To: <1470040874-17256-1-git-send-email-shawn.lin@rock-chips.com> References: <1470040874-17256-1-git-send-email-shawn.lin@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shawn, Am Montag, 1. August 2016, 16:41:14 schrieb Shawn Lin: > The PM domain will be "powered on" once we have registered our PM domain > with genpd and when the device (dw_mmc etc) gets attached to the domain. > The attach occurs when the platform bus'->probe() function get invoked > for the device. > > Due to this, we should be able to deploy genpd support by adding the > phandle of related power-domains without first having to deploying > runtime PM support in the related drivers. > > Let's do this in case of taking risk of accessing controller when the > genpd is in "power off" status as the genpd will turn off all the > power domains which are the referenced by drivers. > > Signed-off-by: Shawn Lin you're missing the subnodes below power: power-controller defining the power- domains, - including the needed clocks. Thus currently you end up defering probe of the emmc and friends indefinitly. Ideally do it in this patch together with the assignment. Thanks Heiko