From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751769AbcGVU6N (ORCPT ); Fri, 22 Jul 2016 16:58:13 -0400 Received: from mail-bl2nam02on0125.outbound.protection.outlook.com ([104.47.38.125]:63520 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750796AbcGVU6L (ORCPT ); Fri, 22 Jul 2016 16:58:11 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=waiman.long@hpe.com; Message-ID: <5792856D.7070508@hpe.com> Date: Fri, 22 Jul 2016 16:43:25 -0400 From: Waiman Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12 MIME-Version: 1.0 To: Tejun Heo CC: Alexander Viro , Jan Kara , Jeff Layton , "J. Bruce Fields" , Christoph Lameter , , , Ingo Molnar , Peter Zijlstra , Andi Kleen , Dave Chinner , Boqun Feng , Scott J Norton , Douglas Hatch Subject: Re: [PATCH v3 1/4] lib/dlock-list: Distributed and lock-protected lists References: <1468604383-40362-1-git-send-email-Waiman.Long@hpe.com> <1468604383-40362-2-git-send-email-Waiman.Long@hpe.com> <20160718233803.GN3078@mtj.duckdns.org> <578E7497.30602@hpe.com> In-Reply-To: <578E7497.30602@hpe.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [72.71.243.24] X-ClientProxiedBy: CY1PR14CA0004.namprd14.prod.outlook.com (10.163.13.142) To AT5PR84MB0305.NAMPRD84.PROD.OUTLOOK.COM (10.162.138.27) X-MS-Office365-Filtering-Correlation-Id: ebd994cb-b6e3-431c-c8ca-08d3b270d6ca X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0305;2:x3yx83f/lGjt1RMrykk1zV5tjIC7lBY8Lj9knC5PgkXe48HJXn7nsGDFB9eizSx7DThruKfrth4q9tIcreQHAqb4T3IaiQuCSNF3Nwa5CUkSKyRIobPlLR8FI8M26JJMlnpx+BeHsIPtGWbJAO9HE2W2nH0zdCgmtFBIfD2c1TQe06grNwRGiwvD8MscAeq0;3:l552me4Non/PAr6bY9mGxW2cDjaxxlObnSFIkX/kfQD4IvDivMx9f/5kqXx3/BLwy8MV6v5DFRXWKHXmOSpFrBX7avdkO2+Yix+Wqbq8pSEGiUi9yAinqAFcGdRYJPBK X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0305; X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0305;25:UoxpzBdcgH7tPik0HE5eobAHE78nyWOuJsAlxAMlvZC30mzHMcnrG3OkBg6Gf8qbWDmRcSh2xZvFsW3nQMKJF82bEPzoDYBnxg80QI7p88P3A6IYNhO1tYWm5YFfDH8ipp+iDDszU/ekKOFYNZOQVGiSuntqGqBL5zuj5qcTNLIaf3aAtpRTX8ba5RXOMuwmrwzIMw1yEzzCvvlOgLlUxa31M4RPl0AkbmWSFIxF5RJ8eDJZWtbtCV1Z53W0egRK6RQV3u+I59l7b3JZ+FJz/jS+Ah9RDb7kZpCsyB+wEYuabUZ5H1rZwOTLwFrXiFny3VS5jvYwP23099nSV6tB32/KCtCeczvcgWDGoFuVnWMscNZyHHI+33YduuMNM3BmlY4cA+Cj2gv10MLon+I2xAcNwLrgB7P/9MQyvqoQRS5B8MWJZLD6tKfu5FOU0xJ2FqAy1jWwNhqvQUHWTueVHx7vh2IrRGJIQOz0POOS+uI88mTu7o+ro2DSjdcRPFrloQmq//eNzXUhqYkpW26PnOgzbmWCDwOIWbFq2fZ741VkzTECX9/f+8V3ZqskQ0C40s5JA11Y1XZTMzN4lfMk0aDpUp/K/dh9BjEYVOeodFEL9bECRl6ceRHP+jE2dVnMrTmiuZTs04LhVyPWCkdnfFo2stqtjEVlAMKkknSgrkqTxA83h9COC+45ow5DunVZ4fiC6LB/VZdSBgMSY8wZOcbWFbXnWU9cCNotK30CJ6Q=;31:dgnBhlA18zyb4ROOFYQuOJEB9EKoXI1isNnNaFhB3OsQpG9dyxAPJu1kMlJg8TAeme1v4Js8nEl+V1j0rut8WSLVbhfv0ssDWZokE5oIvVrmMP74YExuZQEla2WLisfA9Vj9kEUwQh/QRXnxwBCj6jfVwCMm018C4OXU12jw68wtn3G9vIvLe8VaLPOn/0HVP2PI2wkoKK1PXUUY53vL0w== X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0305;20:ZpdTQE6DSLGffWvABO0i4h3UasTMOHyN8MzP8unPMrRa6tetlHjgnt1weC9c5ZVtvDEaO56THPwkkesEONVicLpoqRZiGs06kGSIFuiqTiK5jqdvg1TXqyx0YS80C+rLCOq0CvzIU7RRFpXF93SPEf8ySgLxzZeGcxb/GExva0Glpfkvbl2bEic7vMkzyEHFQt97NuQZvsdXlSqmS/LcEjwaHKeEkn84Az0mgY1hGwDZcrxAEE0Wwg6g8ZlRzwDO6HcY1/FS9dOwfFDyCrX2KdlPOEhC58GHaAdMK8bsCGoXodulAXIwh8Z5WaDKIGDLbEAt9OnU6S4HjimJZ8xlg2Yn4+/el6bhP8oj+xXn2tCn2+4NBD5uKDYr+rQPgQU2CvWhvZDc2GNTzNaAkFMPnEjx/Ogt5Pdho6+hrQRNBI2q8JltjVvk+X+q3Gt/lf9Ekj9rG6riydaMmljoq8qlkrkpT7ne0KRTbn7zpIhwtigD/jI3x/LjpFQED6nkw70v;4:1LByFxXlswNy0MXJXM2yTTkO0DLEIbxYIVFliUXcJFZzhLQPgR5YS99eolfaIvFSrlbj7wdydo+mUgoR/ZfvHsqsLAc+O9J6wlfpyWoY14t1NlU6NumrO7+YlANCFiLfbnt/NXWhB3OSk+g5YyHibYe0LbZ7mX00ErB3a9FgGWpuPTZLq+wPCbjEZCkGsJR4qlZLk7zMLEn1QaA3xMrRwWirv1U9jrAp9E7gOxqFvConoSY0AIuff5ozJ5h8I6jWwGs9wwXXcBW3vuHY+r2fEQM/F/38yBhDaS9bsDUmfFSfwRi+CqGvOWk0a62gBMPMkg1ofKEOd6Zpa3Dw0oUVWG6dxCIB83t+IyZDD8wAPeHLPTOMGWcVNw49KsLXQ+AcW1q2gzxH554/cbeNcHsDOw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:AT5PR84MB0305;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0305; X-Forefront-PRVS: 0011612A55 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(76104003)(377454003)(24454002)(199003)(37984002)(189002)(6116002)(42186005)(77096005)(3846002)(586003)(8676002)(81156014)(50466002)(81166006)(23756003)(99136001)(2906002)(230700001)(189998001)(97736004)(64126003)(110136002)(2950100001)(105586002)(4001350100001)(7846002)(7736002)(65806001)(80316001)(86362001)(36756003)(4326007)(66066001)(65956001)(92566002)(93886004)(106356001)(47776003)(33656002)(59896002)(117156001)(101416001)(65816999)(68736007)(50986999)(305945005)(87266999)(54356999)(76176999)(83506001);DIR:OUT;SFP:1102;SCL:1;SRVR:AT5PR84MB0305;H:[192.168.142.176];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;AT5PR84MB0305;23:vDy0eS8SnTU8WlCqsYt/431GokzL48r3qq/Zrw+?= =?iso-8859-1?Q?BFLms14hmIr6Nc4EBBisDUDjY8b4xVJJ0UF6NaxyEmYvlvdYfqNyqBNU9H?= =?iso-8859-1?Q?B9rHXNbelep5iwBHaY0GCf2lWFn3lEFlxgvVq8ucdBnx9zwlTywQcKehrJ?= =?iso-8859-1?Q?0PJnOwCUn/OsCa2intFVQQwD2HN3IaNpRjWadaN0CjCAyrRvT5j3vtvAJU?= =?iso-8859-1?Q?7UJynWRhpuJtVrG7AxJhuz/IAbM839NOejCrt/28vo3BuN7Y4nrO52GhM5?= =?iso-8859-1?Q?kp9P71bIeaP2lRUO5LRcfFA/l+KYUSUMjr4rKgwZQJmmUpUEPQ8tPNaK+M?= =?iso-8859-1?Q?3fu9xGQXrIpJVBRLveDS/v5KlBNYlWfodQRC9vhtxybJRLVcyuooeiZedd?= =?iso-8859-1?Q?XvsfrCfwPMLgnZvRB1rkllyLXzUpBt/f+aknKpWUQ83IA/GMbacDeXrpde?= =?iso-8859-1?Q?fFaDUvL1KEav7rWFUv4IWfp5ttl9KHygggrjUGXPx9F5Eh8vdNMT9/i9lH?= =?iso-8859-1?Q?mCjFs6LtcQ/3sdrbexbfqPu3f8ovIpjjoCx8qi3Yg/eJf1pB29ucs1H8+U?= =?iso-8859-1?Q?j9KENMQEKlS42vns0Gx0DMIiwP4q80Ox217FI+G/jegyWbndbbRM4ccbNr?= =?iso-8859-1?Q?6RiyypgdeQwb4N7O2fzAqzvnF0EKgZRru2cgMROn/Kfm/ocwYXouX4a1Vr?= =?iso-8859-1?Q?qzyc9AJCFXzj+eYbZNZooeuXy/omXEsucdrIdhgiU5iaSDyuoZo3RlSW0Q?= =?iso-8859-1?Q?parXU9A1GBKrlqQexlbpPmFSI/G5GM3Vw5AajJAtmhUc/9+SQvvSjxiVER?= =?iso-8859-1?Q?7LiqF1Kp6veff65lzhE6FKXqNfn/sYC4dU/ldj+6RQZaSdFIIORuB48aC4?= =?iso-8859-1?Q?v4187TRo9j2HTBgC+Xd7oOgn8hNiTUSMDpjfXsx0/f48XKdwHQgi48S9Ac?= =?iso-8859-1?Q?LvhE2LttMDy7uL4Qlrz9XSa+7lBIamNQw1b2V+zaGFf6IvskcEz/lxwnSZ?= =?iso-8859-1?Q?mcAG10loKbA69+t0BvSkHNUZmn8UKeg0IDluwo8WBu/tFzroy+gbDInA7F?= =?iso-8859-1?Q?w288E1+o5TE99BDKiq7zbSkhMslpAPBSLJoje/AFyKlgFMNtJWiBxPiKGZ?= =?iso-8859-1?Q?L/TQcoGFGNTl0I5sBf+vbIit61PM8z3GIBiU+8aOziaDhkXrgmlYDdipn1?= =?iso-8859-1?Q?kLFLuygCqlcRl5QN7ddg65Z4DdX3ot4ETqW0ntD+6KxrhWh7YU+GSqMHjk?= =?iso-8859-1?Q?Ym9jsNi2PeaMa5SNBK3QDz88r+0iYdEqVDQipn7N5BWOY2Hcw2/IXn9yEN?= =?iso-8859-1?Q?L+E/dQ1TcJH92cSRwEyoDB4THoccrSfFoBNpUEaWHJaTXzgk25a+VX4wCq?= =?iso-8859-1?Q?RYr7rWD2o31XLqyufH0aFPptqBJgo?= X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0305;6:AmzPRL8UsLuDk3dbeChPZCRkHhEgW95IxxWyXgKGmW/PfpTys6ADBn/h0NwY7tz+VBRvQHhjTtn5B3TCnwpzneFw2Mc873bDCzVPckHNDMDR5TDQ6nZNT+iWxpJ+uAJ8TYQJJCveW98XAqO2TTwdV7fttQudvGVdlhQvpPlX0ebPHtp0AiWwl3iBrLlnEBm5CKGNQyHUGdRthPCMXHC8MZm7KMZYxO0EsjYMH+C071A+aUOUc/E2pWnclmpNwuc1xJednY6IIcZPPCavO2JoIhEOTQnmUnMNxQzUKYgBzCPuzbVXHXXPDib0IoNK7hg3+EgO1uv3+0J0cG5XZ1G6lQ==;5:uINLfkCJEcKUvVoZFCLc1/qFHxBHThDARUOaDLmkIB3n7J/EpBk7zsbCApS7U2MAcn2feO9sZSKz9OHUlc1dyD1DNUO+/mvwNw3lYiobPPp01v6HH54OQo/gMdQIMPeCPQWC5TGd9eDGBHU1K8uPpQ==;24:0kIKYnkN8ZhrlBMVDrBpA7Bqp6i0Dmv7Yt9RO5g9yR2xm9CrzrkmK+ppftabPftHm506gaGNBmxnWZwpZgpwZzkZ20DNLEizJFyoLbCmivk=;7:yaBh0RTtrekY2kVobhE8lQpc5WBAFprJcNkZc+qiwLASLEFE5NTxjfq0uqy7N4qGDc/jl/AMpZveWZBCv+INS8jAsysZUXjG3eXLE414nb7CsodF23ti4VNnDTTWJ6znGrNQ7/Q2EXP2L0JEqKn6RYycYjH3PUB9s+Jh3HGsFfyBDOdTPUIJ6scZ8DUaO1r6wtUo9ByNrCQvZ4xnuTPv/VpLC/fF+2Np751pkA9yEeEkXWE4RGJP2bSWUK1KKmLa SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2016 20:43:27.1368 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0305 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/19/2016 02:42 PM, Waiman Long wrote: > On 07/18/2016 07:38 PM, Tejun Heo wrote: > > >>> +/* >>> + * include/linux/dlock-list.h >>> + * >>> + * A distributed (per-cpu) set of lists each of which is protected >>> by its >>> + * own spinlock, but acts like a single consolidated list to the >>> callers. >>> + * >>> + * The dlock_list_head_percpu structure contains the spinlock, the >>> other >>> + * dlock_list_node structures only contains a pointer to the >>> spinlock in >>> + * dlock_list_head_percpu. >>> + */ >> The more I think about it, the more bothered I'm about the dlock_list >> name. For the most part, this isn't different from other percpu data >> structures in the kernel. Sure, it might benefit from doing Nth cpu, >> but so are other percpu data structures and it's not just "distributed >> lock" list either. The list itself is percpu, not just locking. Can >> we please go back to percpu_list? Christoph, what do you think? >> > > As I said before, I don't mind reverting the name back to percpu_list. > I am just waiting for a final agreement. > I have just sent out an update dlock-list patch that incorporates all the feedbacks that I got so far except the name change. I will be on vacation next week. After I come back, we can continue our discussion if the name should be reverted back to percpu_list or not. Cheers, Longman