From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752882AbcGVVQp (ORCPT ); Fri, 22 Jul 2016 17:16:45 -0400 Received: from mail-by2nam01on0125.outbound.protection.outlook.com ([104.47.34.125]:23981 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751849AbcGVVQn (ORCPT ); Fri, 22 Jul 2016 17:16:43 -0400 X-Greylist: delayed 87728 seconds by postgrey-1.27 at vger.kernel.org; Fri, 22 Jul 2016 17:16:43 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=linda.knippers@hpe.com; Message-ID: <57928D31.5050602@hpe.com> Date: Fri, 22 Jul 2016 17:16:33 -0400 From: Linda Knippers User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Viresh Kumar , "Rafael J. Wysocki" , Andreas Herrmann CC: Jacob Tanenbaum , , , Subject: Re: [PATCH] Revert "cpufreq: pcc-cpufreq: update default value of cpuinfo_transition_latency" References: <20160722151411.GB11711@suselix.suse.de> <20160722153656.GR3122@ubuntu> In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [50.187.52.22] X-ClientProxiedBy: BY2PR08CA0083.namprd08.prod.outlook.com (10.163.62.179) To AT5PR84MB0228.NAMPRD84.PROD.OUTLOOK.COM (10.162.138.153) X-MS-Office365-Filtering-Correlation-Id: 8056a8a1-f130-4b7e-d435-08d3b2757942 X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0228;2:GheQ8aXkKki/h4vEuksWcxLXXAfJhXcqtKvuGfgbPmHO1RbELaJ7eHNUhz611806/rg8JfFvs6R2GsnFuyiQRTTPecLXWs545BdHhB64WOi/aLy0REM+s0nZyk3k2ROeGQCboTbATj1WvTwxlnOafw8x0YpKaAiP7BDOMpfQtpkyvQJDGam6qvxnIi96dln/;3:oy/BilN4etFTOU73UoxLnDkB2PQaXCWHpmN46juZp+UvEckd/HsmaYmYGADWL+Wtc5TzZ1GdOf9ln3aEfAqTr4u6mTeEw4El2CqREC+j6EdHHf3OugT94/AWA6G9oM4y;25:HP5y3ktltzeRLSQuLOznUkR+63IOXlZ1wIMZIk347CAc4C49LF2nrt+jSCDL+NPkS5+UK9wgDoI1IMXbUyJ9VnUnp1kHsvsnrZWlo6wi1ZMRN4sfdzq2fvF4H6mfn8pm9yq4905TsJjmf0E7KEAGhGMujJ6X6RdBj3xVLTcCfKhKEDf7GZJJqhFQOQ1VDa26vzRVehW6MzpflPjuRWMwLJcs84GmZxJ7rzyOXBPNUEM7sS1KGCMnYLz6xujd3ZKtNIRinup0G05DrrSAg8O0LHoPOr0wR68EiQkakXlsRqZa0CCIutvLFQ0ogra5fevxCEnW7pRf2/ykz+EeTgzmXkZ4ufw8njpwuujd0FYp59XxnBLpQkp1Ptc5OxgrT3FB2QAWK60pMjzeYeuVDnHlu0rTOh+b02aytbt6RJ0nXnc=;31:wwOyN7Kn+XuZ9xGDzXBUWbwqStVMlaQIg9AObbOWOJQQ0tEdi0NIQxRxtba4+/54wtUBQMJGTTRrPtN5M+Fv39SVcsEDczWS4mFiIrtGwmT/gEw8ygvLvFs6fz2uH97a+rErBcHmCcU9eHWcKue24Pt2vXAGMY8x14Y29RWZMrZzEX/LcCqelG8G7rUubLEV09SB0qClVEP4QkpOrVAw7Q== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0228; X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0228;20:rJpw6rmWSEyIGDM8lg/jvwVf2zROF27EWJCdwEKYbg0KuwpjUd8dayR2RwMCEurmQpmqDyRbxY/D/FSjtZatTC/2Cbg28igjgkzctCSbJL46ul5eEG2mmm6yhvx8FI+oNDgVvNkULOCVATsk1jDyqOBzztYNEWeKkS/+ajMlhPUM3UeRF/ZZkF+mY1ybZz/rv6hjjQ8L54fBPDziwDNap8n0pmoPZAGH3eNdy75m7HYfOJCcgOt3LHylYKqJiAJPnt7kSSOUtHbG0RPxo/M5Zxs4dQoXcpH1udVL6g5Yr7iyeHfE2jRbeMuKP+a7JI9l2egOvp/fg477YrkSL7ZbpodissYZG2kXkNH/2cSA63w0SBNpPYR61lFpMcyqdvW/GnD7sThmfsSmlih4P2ulo/IP+qvG8Fn8e16QXp8dA1HSrEgXmHIX2vfbQeb5Ir5+mT17Qcl8cHTTHN+Mtfigki6hrTqynKT38A3MroslhIM9+gFD1GWB+a4Iji4FecYW;4:Rq5nhCIKlJdK37IIxL1Cg1cIY8phyKtlqk83m1knSccCy8t6laMp7wfhvvWI2CkJQ1uAsISIcl8iP4nIMZSJxjycBPJJrlV3hpmZAikYZDoHppDEF1KRbKduBHmhcseP19OmcmuFowCvX6YJK8zAAWtFYDSjP04Zy/Iedp8sUF9AU28XyaMpZKHkT6uvunaddy3gYnVaom5+YQ8+VgPkQ/Y2zqOysJ9WFYb05lWQFkOMWjNFGSQfdED6f5a90lv/xHKRWPa8MdB/kWcqv7EAKER5VQEzfpbKcgXRI+aVET/T0luY7/lP3U9GuM+iIbm7It8zGQpyJWH6PX0QB2rjxBm6TCYucWxJAzvsKKkLHiZo9DXb5ihPQDTlw4hqT/Hp2yFkhu93bVHuafmTdNRNMQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:AT5PR84MB0228;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0228; X-Forefront-PRVS: 0011612A55 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(377454003)(199003)(377424004)(189002)(24454002)(105586002)(77096005)(80316001)(47776003)(64126003)(586003)(7736002)(65806001)(65956001)(15650500001)(42186005)(2906002)(66066001)(33656002)(86362001)(575784001)(7846002)(305945005)(97736004)(50466002)(83506001)(4326007)(4001350100001)(189998001)(68736007)(117156001)(5001770100001)(59896002)(81156014)(101416001)(76176999)(87266999)(230700001)(54356999)(50986999)(106356001)(8676002)(36756003)(65816999)(23746002)(81166006)(3846002)(99136001)(92566002)(2950100001)(6116002);DIR:OUT;SFP:1102;SCL:1;SRVR:AT5PR84MB0228;H:[192.168.1.12];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AT5PR84MB0228;23:Bo5b21I8b+X1hBKrpQ64LyYoegl7rWvpPXWlf?= =?Windows-1252?Q?vAwnCmm+0SOtix9jdwFKo8duAUe8jNLY0L+HnWzIGWnp4ywZLxgVVcD2?= =?Windows-1252?Q?g8rAOPJFt4iYB5z10rOBSFUAt/klXkjf5ryNRLFDAL+85tThjrLMIIQj?= =?Windows-1252?Q?kqtGMVlG/FnB9RG9+A736+KuxcHcfiiPORg3jYvCeNZJbymAyj7FFwmz?= =?Windows-1252?Q?nB3Gz8PKyKBJGKVZP5jfDKErGZIvPbriITarzomAZziclquejwwQy4Kc?= =?Windows-1252?Q?CrqP5633FeKAqYQscgfDjsKniAODtt6nor9s4ZMwoku5/Ta1kJsXlzbX?= =?Windows-1252?Q?7LqtY+w07F6STNYxdWsu5GK7KKpuRrNmdwhqRFphy6eT7gVSrJIPQyqt?= =?Windows-1252?Q?OnjOiHPzz9u+zWQtm7U7d02HQX3JOyTOkzMqrP7BePUwmFiNIbB1KOQD?= =?Windows-1252?Q?yl4Sq1p4AHL14fKdDwFd8SXTrhAIlcrFAwENpiAyxtl7FsrScMbb5P4n?= =?Windows-1252?Q?zWG1naAyPFf9icjRLaSrlVYp9eoeb4Cyj3MdlI8JW3xIL37ymaZCuyb2?= =?Windows-1252?Q?WvHj1v6IDMCmZLMIOesAjkpQkhx2a76AnuVnBjje8N5P+gOprAABl5i7?= =?Windows-1252?Q?5ruh0V579G8VX3pd49xtdplUUydfe4M1G19jAZXSbCALVSA0dHfhFkPI?= =?Windows-1252?Q?lCSLk3EWZ7EeWblCA2JKRH68W3ZK40zy48fhmgZVq8vXO8L3/0Nh2uc3?= =?Windows-1252?Q?kYIH+Dfan6fS5strFVDL8ez0Dd3Hn2TgsLBP04g89xtjIwp4PzWSi8nw?= =?Windows-1252?Q?FgnmJfEM/B7e2u5l+VWursus9VxKDb8WmlPumjsGLAuJNOALJ0umfBFY?= =?Windows-1252?Q?tqragiyRWRLDLhWF1iR3mSw96oX2Z5H2srvFzCzcbJwnVwgv8/ODVW37?= =?Windows-1252?Q?08MEakZ/Mptd4hE6oDX2icnN2ULxXO3VdicZPgmiLB5rntrdnhWVi7aG?= =?Windows-1252?Q?8zzwGQo33QDlqubhhlmZgulaKAsUehVrIUK1hqkh37IPQbGD3hRJlgFM?= =?Windows-1252?Q?TVrwJO2QHIcDmjvpNxBfoEnNas4HsJryGgk1lo4RIvS+n8f1bDoGnGye?= =?Windows-1252?Q?M7o7Rn+OiACd4tOjmGD7+8zY4bl5TPy7y5+oHJuUPj6ACIADR53w52b8?= =?Windows-1252?Q?QmXyHxKmQAweBAQv8t3GLzb2hAj9mHTFGph6HgjfPL2eguX1tkQ3LkMs?= =?Windows-1252?Q?8b7If/ZhvKAnahgiGz5I3kaCBAwrk4gD3Y6O12oVfVlBGtf0Q9rZUADI?= =?Windows-1252?Q?NaE3IkUvtDOryG/HB+pr8ncLI1FDzroDK8orIvkrOBN0KXCMRfSvvagL?= =?Windows-1252?Q?CjG7jkiVuGquNPIF87D9ZY4GJ6gY+a7kdel4jAV0FaYNE6AVe8ZokShO?= =?Windows-1252?Q?sKawIBcQNIMpqMSid5H3oxpNMPtu5MCR0mCYvmS4w=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0228;6:8FPFoEiBcITlckNiEgxoz/F1l0SbwhDI7vgMotuj8P0VFgkjrqqx2Nx3F7YF2at86aBD+A0P1UkoJUCIi2tYvRK4Oa7tiMvDwoefvjZ4Mhz5ktBZbfyhS8L6DiuAseAZ93UFG827clW3mKC5hcHdNrDfVfEQYjgts/EaDFQAw+DqEf3T6FJ+izsiaaUEpAWkXIEk2rBbCsKcECRanq3lo8Y1NCiipFpcgBPSOIi7eHyFW6InP5/9eeEEBc+vpz4VZxVgdNmsHxSvnOs7nmW+4GxWJxJ27yHLJukXLfArPKtyT7EbawNm0CcZENk5dQcFav91xsK+hb7dcjxKzV0fgw==;5:c9SXTnTeuw+mPE0Ii0FuTCuTyBBGBcfaH5K52fki+mvPxoZV+x9j/TxauTf45JZ7gendh6VSHCLHq2SccypCFphJSVqvsrEFqq7YEg5JekQlpqqitOF6ihQzs0KTouVX0SpJurZQAalD+W38kcCTWA==;24:idOkBdnwWbc25oAkfsR9ghy1MxkQedDT5IgAxoz8mHTiXCmrB6wVXCzJPrtpw+8ViBRnLjOzCsg3A+dO2F4jMpVIa1I3UP982tB6puH8Pqo=;7:VXlf+SXmMXH9A9/5+q99U/ieTrYJ6wymBv4VliAE6UvZ4DUSpa70HWzYKqQiLPxWy81/bgsMY069913h00uh0I+KTKKnWgD07dUCapNnj8LDGBPlsmt+gS4Ux08KYozyN4PG8BH5P5t8gf/1e6+pvcwZyNU8rEBw98/jm3N2f0d4HsRAc5ZQGr5+Lo3dnpCn+dH6K6yhC2jtbNFVffQGqSg0QoZfd9E2k67fAKVTeXD+mgn+4c3Qp4DMJRNumBzA SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2016 21:16:39.0590 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0228 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/22/2016 03:25 PM, Linda Knippers wrote: > > > On 7/22/2016 11:36 AM, Viresh Kumar wrote: >> On 22-07-16, 17:14, Andreas Herrmann wrote: >>> diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c >>> index a7ecb9a..3f0ce2a 100644 >>> --- a/drivers/cpufreq/pcc-cpufreq.c >>> +++ b/drivers/cpufreq/pcc-cpufreq.c >>> @@ -555,8 +555,6 @@ static int pcc_cpufreq_cpu_init(struct cpufreq_policy *policy) >>> policy->min = policy->cpuinfo.min_freq = >>> ioread32(&pcch_hdr->minimum_frequency) * 1000; >>> >>> - policy->cpuinfo.transition_latency = CPUFREQ_ETERNAL; >>> - >>> pr_debug("init: policy->max is %d, policy->min is %d\n", >>> policy->max, policy->min); >>> out: >> >> Hi Rafael, >> >> I am very confused on this, can you help me understand ? >> >> - CPUFREQ_ETERNAL = -1 >> - unsigned int transition_latency = CPUFREQ_ETERNAL, will set it to UINT_MAX. >> - Many drivers do it today >> >> cpufreq.c >> >> if (policy->governor->max_transition_latency && >> policy->cpuinfo.transition_latency > >> policy->governor->max_transition_latency) { >> >> - And this check will always fail, unless max_transition_latency is zero. >> >> What am I missing ? > > I don't know what's missing but I can reproduce the problem. I added a debug message to show the transition latency values. [ 36.113829] cpufreq: ondemand governor failed, too long transition latency of HW, fallback to performance governor [ 36.164688] cpufreq: cpufreq_governor: max_transition_latency 0x10000000, transition_latency 0x4294967295 max_transition latency for ondemand seems to come from #define TRANSITION_LATENCY_LIMIT (10 * 1000 * 1000) How does this work for any driver? -- ljk > > -- ljk >