From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751790AbcGXOCl (ORCPT ); Sun, 24 Jul 2016 10:02:41 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:60582 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751452AbcGXOCk (ORCPT ); Sun, 24 Jul 2016 10:02:40 -0400 Subject: Re: 'kbuild: simpler generation of assembly constants' causing frv build errors To: Alexey Dobriyan References: <20160724001123.GA17473@roeck-us.net> <20160724082400.GA1866@p183.telecom.by> Cc: linux-kernel@vger.kernel.org, Andrew Morton From: Guenter Roeck Message-ID: <5794CA78.8060205@roeck-us.net> Date: Sun, 24 Jul 2016 07:02:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160724082400.GA1866@p183.telecom.by> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/24/2016 01:24 AM, Alexey Dobriyan wrote: > On Sat, Jul 23, 2016 at 05:11:23PM -0700, Guenter Roeck wrote: >> Hi, >> >> your commit 'kbuild: simpler generation of assembly constants' in next >> causes build errors when trying to build frv images. >> >> arch/frv/kernel/switch_to.S: Assembler messages: >> arch/frv/kernel/switch_to.S:155: Error: unresolved expression that must be resolved >> arch/frv/kernel/switch_to.S:160: Error: unresolved expression that must be resolved > > OK, I don't have frv cross-compiler. > I use the compiler from https://www.kernel.org/pub/tools/crosstool/. > What's in include/generated/asm-offsets.h ? > Here is a whitespace-cleaned diff of the file as generated in mainline against -next. < #define REG_PSR 0 /* offsetof(struct pt_regs, psr) ; */ < #define REG_ISR 4 /* offsetof(struct pt_regs, isr) ; */ < #define REG_CCR 8 /* offsetof(struct pt_regs, ccr) ; */ < #define REG_CCCR 12 /* offsetof(struct pt_regs, cccr) ; */ < #define REG_LR 16 /* offsetof(struct pt_regs, lr) ; */ < #define REG_LCR 20 /* offsetof(struct pt_regs, lcr) ; */ < #define REG_PC 24 /* offsetof(struct pt_regs, pc) ; */ < #define REG__STATUS 28 /* offsetof(struct pt_regs, __status) ; */ < #define REG_SYSCALLNO 32 /* offsetof(struct pt_regs, syscallno) ; */ < #define REG_ORIG_GR8 36 /* offsetof(struct pt_regs, orig_gr8) ; */ < #define REG_GNER0 40 /* offsetof(struct pt_regs, gner0) ; */ < #define REG_GNER1 44 /* offsetof(struct pt_regs, gner1) ; */ < #define REG_IACC0 48 /* offsetof(struct pt_regs, iacc0) ; */ < #define REG_TBR 56 /* offsetof(struct pt_regs, tbr) ; */ < #define REG_GR0 56 /* offsetof(struct pt_regs, tbr) ; */ 32,47d14 < < #define REG_DCR 632 /* offsetof(struct frv_frame0, debug.dcr) ; */ < #define REG_IBAR0 640 /* offsetof(struct frv_frame0, debug.ibar[0]) ; */ < #define REG_DBAR0 656 /* offsetof(struct frv_frame0, debug.dbar[0]) ; */ < #define REG_DBDR00 672 /* offsetof(struct frv_frame0, debug.dbdr[0][0]) ; */ < #define REG_DBMR00 736 /* offsetof(struct frv_frame0, debug.dbmr[0][0]) ; */ < < #define __INT_GR0 56 /* offsetof(struct user_context, i.gr[0]) ; */ < #define __USER_FPMEDIA 312 /* offsetof(struct user_context, f) ; */ < #define __FPMEDIA_FR0 312 /* offsetof(struct user_context, f.fr[0]) ; */ < #define __FPMEDIA_FNER0 568 /* offsetof(struct user_context, f.fner[0]) ; */ < #define __FPMEDIA_MSR0 576 /* offsetof(struct user_context, f.msr[0]) ; */ < #define __FPMEDIA_ACC0 584 /* offsetof(struct user_context, f.acc[0]) ; */ < #define __FPMEDIA_ACCG0 616 /* offsetof(struct user_context, f.accg[0]) ; */ < #define __FPMEDIA_FSR0 624 /* offsetof(struct user_context, f.fsr[0]) ; */ A quick glance suggests that those missing defines are responsible for the build problems. Guenter