From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752714AbcGYCzl (ORCPT ); Sun, 24 Jul 2016 22:55:41 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:51567 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752582AbcGYCzi (ORCPT ); Sun, 24 Jul 2016 22:55:38 -0400 Subject: Re: [PATCH v2 2/9] hwmon: (core) New hwmon registration API To: Jonathan Cameron , Jean Delvare References: <1468733432-15730-1-git-send-email-linux@roeck-us.net> <1468733432-15730-3-git-send-email-linux@roeck-us.net> <15243498-d127-0c1a-ea3f-dfa28f5bf2ee@kernel.org> Cc: Zhang Rui , Eduardo Valentin , Punit Agrawal , linux-pm@vger.kernel.org, linux-iio@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <57957F9C.8060100@roeck-us.net> Date: Sun, 24 Jul 2016 19:55:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <15243498-d127-0c1a-ea3f-dfa28f5bf2ee@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/24/2016 12:08 PM, Jonathan Cameron wrote: > On 17/07/16 06:30, Guenter Roeck wrote: >> Up to now, each hwmon driver has to implement its own sysfs attributes. >> This requires a lot of template code, and distracts from the driver's core >> function to read and write chip registers. >> >> To be able to reduce driver complexity, move sensor attribute handling >> and thermal zone registration into hwmon core. By using the new API, >> driver code and data size is typically reduced by 20-70%, depending >> on driver complexity and the number of sysfs attributes supported. >> >> With this patch, the new API only supports thermal sensors. Support for >> other sensor types will be added with subsequent patches. >> > Looks good to me which is pretty unusual for a V2 of anything ;) > Thanks ... unfortunately, it wasn't perfect, so I'll have to send another version. The thermal code needs to be surrounded with "#if IS_REACHABLE(CONFIG_THERMAL) && defined(CONFIG_THERMAL_OF)". Guenter