From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752909AbcGYTDp (ORCPT ); Mon, 25 Jul 2016 15:03:45 -0400 Received: from mail-bn3nam01on0066.outbound.protection.outlook.com ([104.47.33.66]:30265 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752143AbcGYTDm (ORCPT ); Mon, 25 Jul 2016 15:03:42 -0400 X-Greylist: delayed 7221 seconds by postgrey-1.27 at vger.kernel.org; Mon, 25 Jul 2016 15:03:37 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@cavium.com; Message-ID: <57963ED3.4090402@caviumnetworks.com> Date: Mon, 25 Jul 2016 09:31:15 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Mark Brown CC: Jan Glauber , , , "Steven J. Hill" , David Daney Subject: Re: [PATCH 6/6] spi: octeon: Add thunderx driver References: <20160724210452.GB6345@sirena.org.uk> <20160725155122.GA2710@hardcore> <20160725161632.GD11806@sirena.org.uk> In-Reply-To: <20160725161632.GD11806@sirena.org.uk> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [50.233.148.158] X-ClientProxiedBy: SN1PR0701CA0008.namprd07.prod.outlook.com (10.162.96.18) To DM3PR07MB2140.namprd07.prod.outlook.com (10.164.4.146) X-MS-Office365-Filtering-Correlation-Id: c39dcf7d-58cb-42c9-7d71-08d3b4a91a5d X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2140;2:XYx83Mo4+h9pBNFMZezJ6C4qY7sYpGpGSrDqUXzAQfSHUjnsyZgN3/RBcg5psoMMzMHqZtq6Y7XmmM5iI+2RPrtJ4un1FrJB9m8bbuSQX+Cw35zKpzOY8VfS67YX2/LKueEy47mNPpEVQeHwgq/3HJKvqd5CAYQEnvNXvjbiGT+Q6bgmXdw6fsrcxcjhoH4J;3:gU1LboJTZzZUiaHUtCtmg7QUk/G0q9fRUYxm6l+kj/AB/MWJyBGpNiTnblKObPrywiO3IqMataaaySprbJZiENzB6N3uu4DusDUmNQDPqI7WV32KcZ9VupKqI6atlKq9;25:XlQeqVbCmQEE7Bd1LgHqVjcqH7GT35phHDFpVZNCe9VMDVi4dW6k725B8u7SC6aUWov4tAgkafyiHFo2n94a1WURe2g10GuaZjctmLUH3/UighqR9BLMK1axJGsXVfZOBik11XGxkYeLGPV/PDxjoxaIEIQfbt19RAo/6j8Kas0JHq1ph/nHMoAciBeRRi2rGTXvaOZWqXGBghNL8FQg7Z7eYF62kVVZ21RS6FCnB36fNV2DUzVrVoeS3s2HrnFy3igoNizRfnPV26vyTVEsjoBd37jFldz9toNKDojlrbsIhxYoy9caR7QKskWkQBXENs+eJeclRe3L7Xin0baGxLG6sk1dDh/Gfmq68Fc4b4SCRCK02Co4K/YLwF0mDAcUX4r5TkgCGwCbwAZnEqKAZ/DAc7fYd9kt9a7c/NBK+sA=;31:K7/1T+j3sYk2mOt513CyLmYvHdeOjtscvagBRY69Vuq/R409khYevlmXJD7QgqQrecQAYqsIVsR2TOSX4BE3DcrHApRlAB97OxKQMlU0Nko3TWvFSOPR1HTeTF56afGIOnLVI0sMgv/W6oHf3gMlO+Lvc558tqGZaD29kFE4grg7UT522leXzWJRQrVm3JQzsF+HH/fJyN9DZZUTPZPSeQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2140; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2140;20:FHzy5HOHTrrCQCPB88Zsh7LGFWTZqjywzls0kjXHz6ljxGoifobW4P63PwmBTj6xayaBnwLt17j6+b8DUnjWwhdjHpvW3Rgb0mBa0GQkWTHxPGCDrMY5QwLyksaAjKggLmKiodukfy9/abnQrNg7mF32Q4rTRuqvDjX5W0DQLSuqXUJjDdVwVMnZkxY0//hdlG47KkcUutxNkbnWRccXPltCTSiBfh2fCAR4HQKC3zIAYQMyJe0TzcUgwZs4ftf7ztQMxxr1AIEwnQ4JGRC2TzKtfjvyIghQo8TpZhhLDXdujjezJMPbf5/xMXaE7cqWob1xA0Cd4ZriDH2kH2ssMPY597SC0sqeV2tk46jHMXKKmbeMENuQX+ZJ5KG+yMOLDZqe16vKmv/4aOFbXeoG1h5wZhFQZrRnE3xC31RjoQTKIJ9ASsWJC1DAC4sN4F3sZLJcr8k3AtRZnlyo4O9ziS6crdCEs1ZevzXBoRSMliuxxIUG5AOzj2mqy9onmlKMOKjoGa9sNybSKSClq0WFGSQGPI+2aRRKNvpgZmQR89CNQtbWakFwhMo1nnWncXYMUGPf/xs1vts4ycpIAAVWi/2w8cejFlek/rStq6ymJuQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:DM3PR07MB2140;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2140; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2140;4:6tyrNyFwrra/2E2R+0cbHyeck+9E6Lhpdut90MSr34Y8jXBnlwYaWWUFZ8npnp8r4PbWt/Vqwp6BPh1dlO1MWIH2EMb0c40U7QMAgHCSfcAK61nBPuYnA1BVR9Xys6wYirB2wthkyImiz5yN/x8u8qsAcPBxOKbfJiX5DVOpv/4XPIF/G3EeA0QaQDAFCBXx6I7hudYhNSVFezbJff250qSV14YnDSfZJsynXHs34m16BJHF1pdrDYnRqVoNXofvZXtZT9hbAAqDpvztUOL6lhxCW/NL7mEMxX2zkzeydsM2AjRLw7BR8A+23Qi6K5zRyP7vlqYZqaCAtBkmSN1q0WFiMz1FzgFVyGHz+q5jBqsIzxtJSvih0P/32/3OhYDP X-Forefront-PRVS: 0014E2CF50 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(377454003)(24454002)(7846002)(4001430100002)(105586002)(106356001)(305945005)(7736002)(33656002)(6116002)(65806001)(42186005)(4326007)(93886004)(81166006)(2950100001)(36756003)(47776003)(99136001)(230700001)(77096005)(8676002)(64126003)(81156014)(23756003)(66066001)(65956001)(53416004)(107886002)(68736007)(110136002)(2906002)(101416001)(92566002)(586003)(189998001)(50986999)(4001350100001)(50466002)(97736004)(83506001)(65816999)(87266999)(54356999)(3846002)(59896002)(76176999)(69596002)(80316001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR07MB2140;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;DM3PR07MB2140;23:qUwkocVuIa+CtU0w5E8hPvKvDNgvHxLxcWuHGbr?= =?iso-8859-1?Q?dlXtYVLn4I6jBbjHazg/P5ZrupoHAEO07lgmVUnU2+O6HiWGPSmdMEeexT?= =?iso-8859-1?Q?bC9OBZ1FN651wZO6kCHsODNmjluhvH8EN13CFCC9r1XvkH6j6o+LwVXHFK?= =?iso-8859-1?Q?U/foQ2gBx2T4XdQJebXSjjOMUmFMs7/y2UvkbMnAVf/AWOV4JPnCJIj93q?= =?iso-8859-1?Q?nGTsPw63k/IAlNbgqJO4KcRFCPVpIpUOz9SE1tepmosqE1+e5KYNjZgl4V?= =?iso-8859-1?Q?pvDrOsAgOGwWQxiqztpCA3vDhpSN0O6j0mULvZQ5x145O8uiJwHDu+3bW4?= =?iso-8859-1?Q?icAd3d/0X8DfPNXBBwsNPlvVMf11ZI+euKOiNCy8A2CzHHOywL1MkX9kKx?= =?iso-8859-1?Q?UiknWXOWfNQ6Vds43fZkO/dRouEWVEKeTuRpUYvjr+30Wbal+J5+599yQp?= =?iso-8859-1?Q?slbsGgh/D4gMVuZGHx6ybmTXUy6kwghpmgeVIy/Orq7ACwrvc5XMJS5ifX?= =?iso-8859-1?Q?KImS8hUj6HfrPA6iM/fP0q9O7zHwyjCoomhPcdAyafZKCVL+qijFJcU3QA?= =?iso-8859-1?Q?kLA02gDNelET3pAvjQy+pAGdhgaFJgnFtAqwzsxIIeaXnRoLlnFkhCzEh7?= =?iso-8859-1?Q?3pp8har4QDIZyJJPxFiuZP4TPcWD7GQzi2rh5Fy6gQnZAWfDYvQx2HeJ55?= =?iso-8859-1?Q?+bW9TL97CZlE2McAUWGg+ZT2lXFAYQ5EdK4LBWmJ85vRInQZId5KJsNfp0?= =?iso-8859-1?Q?/h6PUPRVbG/IcvPv/Q0Dtq90ktOXr6hFTWN0pPTda3GiImUQJxEzQxCW20?= =?iso-8859-1?Q?pydPP0yALyeNPd+Ol1tiEj2qn0pHYlGnPhXL7G+qR4d7Y8urE9NYlIR+oK?= =?iso-8859-1?Q?rXlL87y7UfMRp/AFmhqpmfo1gIdSWjvYA7AhoXyZEBuFpi5bBTRodfQt5I?= =?iso-8859-1?Q?BeSdpo9tQDLRIse2SXIJKxIvKtiU6MGh+vBYrcHEznbrZFSG4tjE/+qaaY?= =?iso-8859-1?Q?yxzeCBbXdHM6a9I/1RBQa2Cx7he4H1Y2jlUGbRNpKZKsbLkdq4LUO831Ye?= =?iso-8859-1?Q?Iqxl15jRNLa87dU8IdW9U/vS/8s0P19794aArLl3xH95f9zBkeiJdM8fHT?= =?iso-8859-1?Q?npYM86KL5AYR5aAaEXyyaCsN6ahJBLgQyjvvI8npom4qKbqEXDSh+PDLbe?= =?iso-8859-1?Q?m6eOJFxXgYEgsv9ie5wlsul0YVmZECYPQwGOhuhBA8CxlcEbleMw5b+t7H?= =?iso-8859-1?Q?uIN/Ssk/6LzKJyZ+X8TCMATvPotmbp74wTFtdlGjlNGBFz2Yqoj5iI2p72?= =?iso-8859-1?Q?biUrla3R1zCgd9INW41/MEas0JCji6dDmhojmOvBzDnbkk6cAxjFt0+/Ka?= =?iso-8859-1?Q?j+zClfpFLRfH48Sx4f1kiY8uy887L?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2140;6:aEGayuGOHtNih7T+AwhqFblVGMHpPos/7T+H1A1sNZP2yCYMMEV8QgI2ZAwrKAYMbr3AE74EZnKnqbI5H6kuBiUwFKqD+/YCoY1AfnZXIa7EpYoZXOufvhAU3YFOQ1RhW6RaSVOqLuRDdQa8yP/UHPaSZbZEl0oGo3VBDdyvzsL0myR7KUUDeVqi+vusSfuxPuCWQMxEayXKBaNJRYWqnoUhj+qNKq+O1mzrUqs5IlY12HZ/GsyV9sfLsjvjeY9t1iNyACDuQpm/25U1E0neLra0NOnZKHauZTSplwFIsRs=;5:wRkMKpEcJQM6Xtks6N1LvKxHBl5cfPMK+BtwiBJQ6d+Ab0eseLO9yf2qs0wMLuOO4k9Aeoz1VWeEbmqpEIa+Sawe37/v55s+35eWA33kUF0kEPOsDslnPg65KWAa0U6ay3riCqxyGnwaxCj/agUH2g==;24:1oEB7vWD3cCWbf9oFX28xqDiyzpX3ioEvMBMHJ6uenYTuEiI55SPZCAhiokmi7PNDiqxuaHz8aDi54wjIPxSd6a4XxyoiVx6ow57MD7krkY=;7:Agad+LFZJziS6uWwp6GnFopnv9qM85ynMoxqGUpXUT+7ESpXPj3hR6DuQI2ODr9ZVVvqucfxA7ZIL8hhDWYW81rYJbj99Wqvuem+A5aglaleEjIuFb0+W9r85CSqRKI6S3DAoe5EXAvyRd3tEnvfVI8Zh6BZWvugntXuLHvEiTUNYWdt6W4cKhH/QXkMMTvxrN3LHaRCL0i88PXwu+k4XreRFXpbijOyvWd5zGSRyoMGCL3XSUaRWTkl5fWzqnot SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2016 16:31:16.8524 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR07MB2140 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/25/2016 09:16 AM, Mark Brown wrote: > On Mon, Jul 25, 2016 at 05:51:22PM +0200, Jan Glauber wrote: >> On Sun, Jul 24, 2016 at 10:04:52PM +0100, Mark Brown wrote: >>> On Sat, Jul 23, 2016 at 12:42:55PM +0200, Jan Glauber wrote: > >>>> + depends on 64BIT && PCI && !CAVIUM_OCTEON_SOC > >>> This is a *weird* and most likely broken set of dependencies - why >>> exclude this if we're on Octeon (or Octeon happens to have been enabled >>> in a config)? > >> I agree that it looks weird, the reasoning is that we would like >> to avoid making the driver depend on something like ARCH_THUNDER. > > Why? > >> So I made the driver depend on the things it actually uses >> (PCI for probing and 64BIT because of readq/writeq) and don't care if it >> compiles on other platforms too (like x86). > > The usual pattern would be something like (ARCH_THUNDER || COMPILE_TEST) > && PCI && 64BIT (so that people on other platforms where the device will > never actually appear don't get bothered by the prompt). ARCH_THUNDER needs to die, so perhaps it should be (ARM64 || COMPILE_TEST) && PCI && 64BIT if you really want to hide it from non-arm64 kernel configs. > >> That said, I can remove the !CAVIUM_OCTEON_SOC, it compiles without >> errors on MIPS too. Would that be ok? > > Sure. >