From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753781AbcGZAtJ (ORCPT ); Mon, 25 Jul 2016 20:49:09 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:53462 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752818AbcGZAtG (ORCPT ); Mon, 25 Jul 2016 20:49:06 -0400 X-AuditID: cbfee68d-f79286d000007a9a-a7-5796b37debeb Message-id: <5796B37D.70001@samsung.com> Date: Tue, 26 Jul 2016 09:49:01 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Alim Akhtar , Krzysztof Kozlowski , Ulf Hansson , Kukjin Kim , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz Subject: Re: mmc: dwmmc: exynos: Warn if HS400 is being used on non-Exynos5420 chipset References: <1468502547-18571-1-git-send-email-k.kozlowski@samsung.com> <5788637F.2070908@samsung.com> In-reply-to: <5788637F.2070908@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBIsWRmVeSWpSXmKPExsWyRsSkULd287Rwg74LZhYP5m1js9g4Yz2r xesXhhb9j18zW2x6fI3V4vKuOWwWR/73M1rMOL+PyeL42nAHTo9NqzrZPO5c28PmsXlJvUff llWMHp83yQWwRnHZpKTmZJalFunbJXBldDekF6ziqThw8TBzA+Npzi5GTg4JAROJL1O2sELY YhIX7q1n62Lk4hASWMEosenmJ0aYosNLT7NCJJYySrw7tYkdwnnAKHFk1zmwKl4BDYmem40s IDaLgKrEuZ/bwGw2AR2J7d+OM4HYogJhEg/W7WWFqBeU+DH5HliNiMByJonZ03xBbGYBC4mt W1ezg9jCAhESx7ZDzBcS2MMocXd6BYjNKaAtsbn/A9CpHED1ehL3L2pBtMpLbF7zlhnkNgmB W+wSPy5ug7pHQOLb5EMsIPUSArISmw4wQzwmKXFwxQ2WCYxis5BcNAth6iwkUxcwMq9iFE0t SC4oTkovMtQrTswtLs1L10vOz93ECIzA0/+e9e5gvH3A+hCjAAejEg/vBNdp4UKsiWXFlbmH GE2BjpjILCWanA+M87ySeENjMyMLUxNTYyNzSzMlcV5FqZ/BQgLpiSWp2ampBalF8UWlOanF hxiZODilGhhPrVvfdFi396MQt1OyfGR+e2fuBy6Rfc+VSgI/3K2SUu9ZKrTw9rXTjqlbfjR3 r7s+hS/9qAD/n/LrGiwvdqx1bPjOsz1l5xb+hNt/ri3O4mDdv3a208S3AU87mOMObzo8s0pc 78KXEu/AGC+rxvzZequNYh4/9zVb6prfw96t7MAVV+n2XleJpTgj0VCLuag4EQAzQGO7uwIA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKIsWRmVeSWpSXmKPExsVy+t9jAd3azdPCDU5cN7B4MG8bm8XGGetZ LV6/MLTof/ya2WLT42usFpd3zWGzOPK/n9Fixvl9TBbH14Y7cHpsWtXJ5nHn2h42j81L6j36 tqxi9Pi8SS6ANaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnF J0DXLTMH6BwlhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGENY0Z3Q3rBKp6K AxcPMzcwnubsYuTkkBAwkTi89DQrhC0mceHeerYuRi4OIYGljBLvTm1ih3AeMEoc2XWOEaSK V0BDoudmIwuIzSKgKnHu5zYwm01AR2L7t+NMILaoQJjEg3V7WSHqBSV+TL4HViMisJxJYvY0 XxCbWcBCYuvW1ewgtrBAhMSx7RDzhQT2MErcnV4BYnMKaEts7v8AdBEHUL2exP2LWhCt8hKb 17xlnsAoMAvJhlkIVbOQVC1gZF7FKJFakFxQnJSea5SXWq5XnJhbXJqXrpecn7uJERzlz6R3 MB7e5X6IUYCDUYmH12HqtHAh1sSy4srcQ4wSHMxKIrxx64FCvCmJlVWpRfnxRaU5qcWHGE2B QTCRWUo0OR+YgPJK4g2NTcyMLI3MDS2MjM2VxHkf/18XJiSQnliSmp2aWpBaBNPHxMEp1cAY wdxUGixmds/nSB/jy78Z5SlT77nb67w5F7h8983Z/TZ2sil/NT9IpBp1/v7ntLSMZdPDlQfj P267MfEVW4Umg4LkiYptZeER89UWFpfVFS86dull+As7H6fkP9uzLFekv5z67M+JI4/6T8jn Xnp/PWKrPIOH1br+tnudzPmZZkdXrGFt15ZXYinOSDTUYi4qTgQAmgDgmAgDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/15/2016 01:15 PM, Alim Akhtar wrote: > Hi Krzysztof, > > On 07/14/2016 06:52 PM, Krzysztof Kozlowski wrote: >> Chipsets before Exynos5420 did not support HS400 so if MMC core tries to >> configure HS400 timing, this might or might not work. Warn in such >> cases because this is DTB misconfiguration. >> >> Signed-off-by: Krzysztof Kozlowski >> --- > > Reviewed-by: Alim Akhtar Applied on my repository. Thanks! Before applied, I modified the prefix of subject from "dwmmc" to "dw_mmc" Best Regards, Jaehoon Chung > >> drivers/mmc/host/dw_mmc-exynos.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c >> index da0ef1765735..7ab3d749b5ae 100644 >> --- a/drivers/mmc/host/dw_mmc-exynos.c >> +++ b/drivers/mmc/host/dw_mmc-exynos.c >> @@ -225,8 +225,12 @@ static void dw_mci_exynos_config_hs400(struct dw_mci *host, u32 timing) >> * Not supported to configure register >> * related to HS400 >> */ >> - if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420) >> + if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420) { >> + if (timing == MMC_TIMING_MMC_HS400) >> + dev_warn(host->dev, >> + "cannot configure HS400, unsupported chipset\n"); >> return; >> + } >> > It is good to have extra bit of debug information handy. > >> dqs = priv->saved_dqs_en; >> strobe = priv->saved_strobe_ctrl; >> > >