From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754563AbcGZAtt (ORCPT ); Mon, 25 Jul 2016 20:49:49 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:54068 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752878AbcGZAtq (ORCPT ); Mon, 25 Jul 2016 20:49:46 -0400 X-AuditID: cbfee68d-f79286d000007a9a-44-5796b3a1f544 Message-id: <5796B3A1.1050002@samsung.com> Date: Tue, 26 Jul 2016 09:49:37 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Shawn Lin Cc: Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmc: dw_mmc: remove parsing for each slot subnode References: <1468547254-805-1-git-send-email-shawn.lin@rock-chips.com> In-reply-to: <1468547254-805-1-git-send-email-shawn.lin@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgkeLIzCtJLcpLzFFi42JZI2JSoLtw87Rwg8lTxC0u75rDZnHkfz+j xZ0n61ktjq8Nd2DxuHNtD5vH31n7WTw+b5ILYI7isklJzcksSy3St0vgyni9/BRjwRKxivY3 TawNjA8Fuxg5OSQETCQetSxhgbDFJC7cW8/WxcjFISSwglHi1KwXzDBFP+edhErMYpTobH7F CuE8YJR4tP0nWBWvgJbEyq/7gao4OFgEVCXOzI0DCbMJ6Ehs/3acCcQWFQiTeLBuLytEuaDE j8n3wDaLCGhI3Dh7nQ3EZhZIluj4dxQsLizgJjHxyjMmiF1zGCW+3joLNohTwF3i2qoJLCC7 mAX0JO5f1ILolZfYvOYtM0i9hMAqdonpfcvABrEICEh8m3wIrF5CQFZi0wGoxyQlDq64wTKB UWwWkpNmIUydhWTqAkbmVYyiqQXJBcVJ6UWGesWJucWleel6yfm5mxiBEXT637PeHYy3D1gf YhTgYFTi4Z3gOi1ciDWxrLgy9xCjKdARE5mlRJPzgXGaVxJvaGxmZGFqYmpsZG5ppiTOqyj1 M1hIID2xJDU7NbUgtSi+qDQntfgQIxMHp1QDY6/DzfI9Va9ydN+fW5O6kONKpO+H2zy6ZyVe Zqld/eu2VSi9omm+1jWOl03p54/HzHvnyLt4cXKUw2xHs0Lvd4dnzFlctUJuwiqjmJL1V/1Y /3X7q5aZ+buW5J9e9dY63uaNYUXBFPfbGYtqS2MzX22fv/NfhGTTpCoBTu7IPVtsiq/Hhako K7EUZyQaajEXFScCAKaAKFCbAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKIsWRmVeSWpSXmKPExsVy+t9jQd2Fm6eFGxyfJGRxedccNosj//sZ Le48Wc9qcXxtuAOLx51re9g8/s7az+LxeZNcAHNUA6NNRmpiSmqRQmpecn5KZl66rZJ3cLxz vKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtA2JYWyxJxSoFBAYnGxkr4dpgmhIW66FjCNEbq+ IUFwPUYGaCBhDWPG6+WnGAuWiFW0v2libWB8KNjFyMkhIWAi8XPeSTYIW0ziwr31QDYXh5DA LEaJzuZXrBDOA0aJR9t/MoNU8QpoSaz8uh+oioODRUBV4szcOJAwm4COxPZvx5lAbFGBMIkH 6/ayQpQLSvyYfI8FxBYR0JC4cfY62DJmgWSJjn9HweLCAm4SE688Y4LYNYdR4uuts2CDOAXc Ja6tmsACsotZQE/i/kUtiF55ic1r3jJPYAS6EmHFLISqWUiqFjAyr2KUSC1ILihOSs81zEst 1ytOzC0uzUvXS87P3cQIjtJnUjsYD+5yP8QowMGoxMM7wXVauBBrYllxZe4hRgkOZiUR3rj1 QCHelMTKqtSi/Pii0pzU4kOMpsAgmMgsJZqcD0wgeSXxhsYmZkaWRuaGFkbG5krivI//rwsT EkhPLEnNTk0tSC2C6WPi4JRqYFzw+3eWfAdfzpmFd94JM1zY8F8uZjb3uZwHCqcPn/HW0j99 c8fppONlPvv7mhsmrZXuu1Ptyc2coB4vLqA7O1VngaXXTf2YqfbTF94JnhL03vSXyt31e/19 fMNXv21ZvVxUJlHJm8n/oPuc1e62/QX+6ZG/RNmO/bOdnyLUfuJ0XNSHFPNVk5VYijMSDbWY i4oTASickFfoAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/15/2016 10:47 AM, Shawn Lin wrote: > The intention to remove it comes from the conflict of > what the mmc-core does with the way dw_mmc treats disable-wp. > We could see that 'disable-wp' is supported by core but > it's deprecated by dw_mmc as we don't expect it to be existed > for each slot subnode but should be in the parent node. Based > on searching for all the upstream dts using dw_mmc, we're > confident that none of them use the deprecated way. Maybe > we should take old dtb in consideration but it was a flag day > since the time we was considering to take it away. The fact is > that there are none of dts using the deprecated way since v3.18 > or even earlier. So personally I don't believe the old dtb > would/could bootup current kernel(may not?). Let's remove it now. > > Signed-off-by: Shawn Lin Applied on my repository. Thanks! Best Regards, Jaehoon Chung > --- > > drivers/mmc/host/dw_mmc.c | 43 ------------------------------------------- > 1 file changed, 43 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 2dfdc58..d0adddb 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -2523,47 +2523,6 @@ static irqreturn_t dw_mci_interrupt(int irq, void *dev_id) > return IRQ_HANDLED; > } > > -#ifdef CONFIG_OF > -/* given a slot, find out the device node representing that slot */ > -static struct device_node *dw_mci_of_find_slot_node(struct dw_mci_slot *slot) > -{ > - struct device *dev = slot->mmc->parent; > - struct device_node *np; > - const __be32 *addr; > - int len; > - > - if (!dev || !dev->of_node) > - return NULL; > - > - for_each_child_of_node(dev->of_node, np) { > - addr = of_get_property(np, "reg", &len); > - if (!addr || (len < sizeof(int))) > - continue; > - if (be32_to_cpup(addr) == slot->id) > - return np; > - } > - return NULL; > -} > - > -static void dw_mci_slot_of_parse(struct dw_mci_slot *slot) > -{ > - struct device_node *np = dw_mci_of_find_slot_node(slot); > - > - if (!np) > - return; > - > - if (of_property_read_bool(np, "disable-wp")) { > - slot->mmc->caps2 |= MMC_CAP2_NO_WRITE_PROTECT; > - dev_warn(slot->mmc->parent, > - "Slot quirk 'disable-wp' is deprecated\n"); > - } > -} > -#else /* CONFIG_OF */ > -static void dw_mci_slot_of_parse(struct dw_mci_slot *slot) > -{ > -} > -#endif /* CONFIG_OF */ > - > static int dw_mci_init_slot(struct dw_mci *host, unsigned int id) > { > struct mmc_host *mmc; > @@ -2620,8 +2579,6 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id) > if (host->pdata->caps2) > mmc->caps2 = host->pdata->caps2; > > - dw_mci_slot_of_parse(slot); > - > ret = mmc_of_parse(mmc); > if (ret) > goto err_host_allocated; >