From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753241AbcGZDXP (ORCPT ); Mon, 25 Jul 2016 23:23:15 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:55870 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752787AbcGZDXM (ORCPT ); Mon, 25 Jul 2016 23:23:12 -0400 Subject: Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe To: Caesar Wang , Jonathan Cameron , Heiko Stuebner References: <1469475540-26855-1-git-send-email-linux@roeck-us.net> <5796D036.1060101@rock-chips.com> Cc: linux-iio@vger.kernel.org, dianders@chromium.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org From: Guenter Roeck Message-ID: <5796D792.4080407@roeck-us.net> Date: Mon, 25 Jul 2016 20:22:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <5796D036.1060101@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/25/2016 07:51 PM, Caesar Wang wrote: > Hi Guenter, > > Thanks for fixing it. > > On 2016年07月26日 03:39, Guenter Roeck wrote: >> If the ADC is read for the first time, the caller gets a timeout error, >> and the kernel log shows >> >> read channel() error: -110 >> >> The ADC may be enabled on boot, and needs to be explicitly disabled >> for a read sequence to work (otherwise there is no completion interrupt). >> Disaple it explicitly in the probe function. >> >> Fixes: 44d6f2ef94f9 ("iio: adc: add driver for Rockchip saradc") >> Signed-off-by: Guenter Roeck >> --- >> drivers/iio/adc/rockchip_saradc.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c >> index f9ad6c2d6821..6aa3271d86b5 100644 >> --- a/drivers/iio/adc/rockchip_saradc.c >> +++ b/drivers/iio/adc/rockchip_saradc.c >> @@ -280,6 +280,9 @@ static int rockchip_saradc_probe(struct platform_device *pdev) >> goto err_pclk; >> } >> + /* Make sure ADC is disabled */ >> + writel_relaxed(0, info->regs + SARADC_CTRL); > > I think we should reset the saradc controller. > Since make sure the reset value is 0 and loader-->kernel may even cause harm, as my experience on tsadc. (drivers/thermal/rockchip_thermal.c) > > > e.g.: > /** > * Reset SARADC Controller, reset all saradc registers. > */ > static void rockchip_saradc_reset_controller(struct reset_control *reset) > { > reset_control_assert(reset); > usleep_range(10, 20); > reset_control_deassert(reset); > } > > ..probe() > { > ... > rockchip_saradc_reset_controller(); > ... > } > Ok, I'll give it a try. Guenter > > - > Caesar > >> + >> platform_set_drvdata(pdev, indio_dev); >> indio_dev->name = dev_name(&pdev->dev); > >