From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161109AbcGZVrw (ORCPT ); Tue, 26 Jul 2016 17:47:52 -0400 Received: from mx2.suse.de ([195.135.220.15]:51759 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757448AbcGZVrt (ORCPT ); Tue, 26 Jul 2016 17:47:49 -0400 Subject: Re: [PATCH 1/1 linux-next] kbuild: add make force=1 for testing To: Andrew Morton References: <1469366898-1496-1-git-send-email-fabf@skynet.be> <20160725170555.fd4df28de067f2a689a2efc2@linux-foundation.org> Cc: Fabian Frederick , Robert Jarzmik , linux-kernel@vger.kernel.org From: Michal Marek Message-ID: <5797DA7A.4050102@suse.com> Date: Tue, 26 Jul 2016 23:47:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20160725170555.fd4df28de067f2a689a2efc2@linux-foundation.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne 26.7.2016 v 02:05 Andrew Morton napsal(a): > On Sun, 24 Jul 2016 15:28:18 +0200 Fabian Frederick wrote: >> This patch adds ability to do make force=1 for people >> not interested in modules_install in this case but only testing. >> >> (Note that other options could go under ifndef force) > > That's a bit of a hack on a hack. Agreed. > 51193b76bfff said: > > : When the kernel path contains a space or a colon somewhere in the path > : name, the modules_install target doesn't work anymore, as the path names > : are not enclosed in double quotes. It is also supposed that and O= build > : will suffer from the same weakness as modules_install. > : > : Instead of checking and improving kbuild to resist to directories > : including these characters, error out early to prevent any build if the > : kernel's main directory contains a space. > > What's involved in fixing this properly? Make the whole kbuild > system operate correctly when there are spaces/colons in the > pathname? modules_install probably could be fixed. However, O= builds are definitely unfixable: We use -I$(srctree)/... in various *FLAGS variables, which are space-separated lists. We assign $(srctree) to VPATH, which is a colon-separated list. Also, we pass $(srctree)/... to the wildcard, addprefix or patsubst functions, which take a space-separated list of words. The Makefile language simply does does not give us tools to handle special characters properly. To work around such paths, I suggest to create a symlink and use that. As far as I can tell, we do not call readlink/realpath in the buildsystem. Michal