From: Michal Marek <mmarek@suse.com>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
x86@kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v2] kbuild: Abort build on bad stack protector flag
Date: Tue, 26 Jul 2016 23:52:22 +0200 [thread overview]
Message-ID: <5797DB96.2020904@suse.com> (raw)
In-Reply-To: <20160726212620.GA8511@www.outflux.net>
Dne 26.7.2016 v 23:26 Kees Cook napsal(a):
> Before, the stack protector flag was sanity checked before .config had
> been reprocessed. This meant the build couldn't be aborted early, and
> only a warning could be emitted followed later by the compiler blowing
> up with an unknown flag. This has caused a lot of confusion over time,
> so this splits the flag selection from sanity checking and performs the
> sanity checking after the make has been restarted from a reprocessed
> .config, so builds can be aborted as early as possible now.
>
> Additionally moves the x86-specific sanity check to the same location,
> since it suffered from the same warn-then-wait-for-compiler-failure
> problem.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> v2:
> - fix use of SRCARCH, mmarek
> - simplify stackp-check usage, mmarek
Applied to kbuild.git#kbuild.
Michal
prev parent reply other threads:[~2016-07-26 21:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 21:26 [PATCH v2] kbuild: Abort build on bad stack protector flag Kees Cook
2016-07-26 21:52 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5797DB96.2020904@suse.com \
--to=mmarek@suse.com \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).