From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758818AbcG0Dmw (ORCPT ); Tue, 26 Jul 2016 23:42:52 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:36609 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750975AbcG0Dmv (ORCPT ); Tue, 26 Jul 2016 23:42:51 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68d-f79286d000007a9a-ed-57982db8d47a Content-transfer-encoding: 8BIT Message-id: <57982DB8.4050703@samsung.com> Date: Wed, 27 Jul 2016 12:42:48 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Chris Zhong , Guenter Roeck Cc: chanwoo@kernel.org, linux-kernel , "myungjoo.ham@samsung.com" , Guenter Roeck , cpgs@samsung.com Subject: Re: [PATCH 2/6] extcon: Add the support for extcon property according to extcon type References: <1469534988-8305-1-git-send-email-cw00.choi@samsung.com> <1469534988-8305-3-git-send-email-cw00.choi@samsung.com> <57980B2D.7090307@rock-chips.com> <579817EF.7090905@rock-chips.com> In-reply-to: <579817EF.7090905@rock-chips.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRmVeSWpSXmKPExsWyRsSkQHeH7oxwg/9PDSwm3rjCYvHykKbF qVfLmC16Fy1hsbi8aw6bxe3GFWwW8x/sYHZg95jdcJHFY8GmUo9NqzrZPP7O2s/i0bdlFaPH 501yAWxRXDYpqTmZZalF+nYJXBkn93cxFtzgqGh99I2tgXEHWxcjJ4eEgInEtPn9zBC2mMSF e+uB4lwcQgIrGCVut3xhhCnadvsfC0RiKaPEh7ctYN28AoISPybfA0pwcDALyEscuZQNYapL TJmSC1H+gFGiY/0ndpA4r4CWxO0ruiCdLAKqEvdeXmcFsdmAwvtf3GADKREViJDoPlEJEhYR cJeYd+kZ2DnMAlsZJeYcO80OkhAWiJc4uH0qK8T8D8wS0+dtBnuAU0BPYsvRFYwgCQmBW+wS C/YsZYTYJiDxbfIhsDslBGQlNh2AelhS4uCKGywTGMVmIflmFsI3sxC+WcDIvIpRNLUguaA4 Kb3IUK84Mbe4NC9dLzk/dxMjMO5O/3vWu4Px9gHrQ4wCHIxKPLwWu6aHC7EmlhVX5h5iNAW6 YSKzlGhyPjC680riDY3NjCxMTUyNjcwtzZTEeRWlfgYLCaQnlqRmp6YWpBbFF5XmpBYfYmTi 4JRqYNwQe0E9SYPD9enekEtmwTOvxk5e8NjAqj+Y+e6qmg4BodqwQ/dP79rcf8p2fvmZ+vep ucITz3EYTXyRvNz6uZx71bfpfVUxGUzTXgQ1Zy98bMFsdWK+mtrt9ofXeth23trWct3t8rXL y+sW9ZTPEnC8IKZUt9OmWHTfPt6/IWcmzj0c2LbmTJkSS3FGoqEWc1FxIgBxnsNTtgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrAIsWRmVeSWpSXmKPExsVy+t9jAd0dujPCDa7t07SYeOMKi8XLQ5oW p14tY7boXbSExeLyrjlsFrcbV7BZzH+wg9mB3WN2w0UWjwWbSj02repk8/g7az+LR9+WVYwe nzfJBbBFNTDaZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl 5gCdoqRQlphTChQKSCwuVtK3wzQhNMRN1wKmMULXNyQIrsfIAA0krGHMOLm/i7HgBkdF66Nv bA2MO9i6GDk5JARMJLbd/scCYYtJXLi3HijOxSEksJRR4sPbFrAiXgFBiR+T7wEVcXAwC8hL HLmUDWGqS0yZkgtR/oBRomP9J3aQOK+AlsTtK7ognSwCqhL3Xl5nBbHZgML7X9xgAykRFYiQ 6D5RCRIWEXCXmHfpGdhWZoGtjBJzjp1mB0kIC8RLHNw+lRVi/gdmienzNjODJDgF9CS2HF3B OIFRYBaS62YhXDcL4boFjMyrGCVSC5ILipPSc43yUsv1ihNzi0vz0vWS83M3MYJj+5n0DsbD u9wPMQpwMCrx8DJcmR4uxJpYVlyZe4hRgoNZSYR3v8aMcCHelMTKqtSi/Pii0pzU4kOMpkD/ TWSWEk3OB6advJJ4Q2MTMyNLI3NDCyNjcyVx3sf/14UJCaQnlqRmp6YWpBbB9DFxcEo1MDLm f6t+F+OyRFRzYxbz3TzfrwyrDCyvR356Zz45VOLSywUn51ycut97foLU4T3Oszx4NLUOWvr9 2R3k4tG6vFxV/NjRWb0pxv9vx0RP+K/1kqX9T2Pk3CMFH1eWVD0ou+1THXXAwItL6dqfuKOZ lw/ZbbsqxrpxsWG3nMj2f4Le6koX9/nfPK3EUpyRaKjFXFScCABuk6XLAwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chris, On 2016년 07월 27일 11:09, Chris Zhong wrote: > Hi Guernter > > On 07/27/2016 09:44 AM, Guenter Roeck wrote: >> Hi Chris, >> >> On Tue, Jul 26, 2016 at 6:15 PM, Chris Zhong wrote: >> >> [ ... ] >> >>>> > + >>>> > +/* Properties of EXTCON_TYPE_DISP. */ >>>> > +#define EXTCON_PROP_DISP_MIN 150 >>>> > +#define EXTCON_PROP_DISP_MAX 150 >>>> > +#define EXTCON_PROP_DISP_CNT (EXTCON_PROP_DISP_MAX - >>>> EXTCON_PROP_DISP_MIN) >>>> >>>> + 1 >>>> >>>> >>>> ok. >>> >>> Tested with these "+1", it works for my DP patch. >>> >> You should be able to use >> https://chromium-review.googlesource.com/#/c/363623/1 as baseline (if >> you didn't do that already). >> >> Thanks, >> Guenter > > Thanks Guenter, and I saw this bug has fixed in extcon-test branch. > > Do you test it with extcon_set_property_capability()? And if you test this patch-es, could you send the tested-by tag for these patches? I'll send the next version after a few days. Regards, Chanwoo Choi