From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758655AbcG0D5c (ORCPT ); Tue, 26 Jul 2016 23:57:32 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:50020 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751504AbcG0D5X convert rfc822-to-8bit (ORCPT ); Tue, 26 Jul 2016 23:57:23 -0400 X-AuditID: cbfee68e-f79cb6d000006cfe-17-5798311f5bb8 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <5798311E.9080603@samsung.com> Date: Wed, 27 Jul 2016 12:57:18 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Guenter Roeck Cc: Chris Zhong , chanwoo@kernel.org, linux-kernel , "myungjoo.ham@samsung.com" , Guenter Roeck , cpgs@samsung.com Subject: Re: [PATCH 2/6] extcon: Add the support for extcon property according to extcon type References: <1469534988-8305-1-git-send-email-cw00.choi@samsung.com> <1469534988-8305-3-git-send-email-cw00.choi@samsung.com> <57980B2D.7090307@rock-chips.com> <579817EF.7090905@rock-chips.com> <57982DB8.4050703@samsung.com> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsWyRsSkUFfecEa4QdM3IYuJN66wWLw8pGlx 6tUyZoveRUtYLC7vmsNmcbtxBZvF/Ac7mB3YPWY3XGTxWLCp1GPTqk42j7+z9rN49G1Zxejx eZNcAFsUl01Kak5mWWqRvl0CV8bHvs0sBat4KjpuLWBsYDzM2cXIySEhYCLxasVeZghbTOLC vfVsXYxcHEICKxglVs78zQ5TdGveFyYQW0hgFqPEx4t5IDavgKDEj8n3WLoYOTiYBdQlpkzJ BQkzC4hINF3Zxwhha0ssW/iaGaL1AaPE3mvVEK1aEoc3nAKrYRFQlWi5eYgVxGYDiu9/cYMN ZKSoQIRE94lKkLAIUMmpp8fZIEbeZJS4tsESxBYWiJc4uH0qK8TJ11gkDl/8ywKS4BQIlrj1 thEsISFwiV2i89pjqGUCEt8mHwK7WUJAVmLTAajfJSUOrrjBMoFRfBaSz2YhfDYLyWezkHy2 gJFlFaNoakFyQXFSepGRXnFibnFpXrpecn7uJkZgnJ7+96xvB+PNA9aHGAU4GJV4eFdcnB4u xJpYVlyZe4jRFOigicxSosn5wGSQVxJvaGxmZGFqYmpsZG5ppiTOmyD1M1hIID2xJDU7NbUg tSi+qDQntfgQIxMHp1QDY5OUWNGMi/lTprBq7LBjUROPErXO/1PRduWQ2fQgCVeHVxdfRvn9 032QdzfmqZ04r3P9x4UfMx61rGTZkJWyU2LWnH0ZJe7y7AsWq2R5/e8L80ifGaRbMntvaa1q /5zOM292bu39p3n8SMS2IK8XkfP2rq1xCL268XAjz+R5bM+b3zx/8W7JYiWW4oxEQy3mouJE APnSjnLOAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsVy+t9jQV15wxnhBnO/8FhMvHGFxeLlIU2L U6+WMVv0LlrCYnF51xw2i9uNK9gs5j/YwezA7jG74SKLx4JNpR6bVnWyefydtZ/Fo2/LKkaP z5vkAtiiGhhtMlITU1KLFFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0y c4BOUVIoS8wpBQoFJBYXK+nbYZoQGuKmawHTGKHrGxIE12NkgAYS1jBmbH69iaWgiafi3j6t BsbZnF2MnBwSAiYSt+Z9YYKwxSQu3FvPBmILCcxilPh4MQ/E5hUQlPgx+R5LFyMHB7OAvMSR S9kQprrElCm5ENUPGCX2XquGqNaSOLzhFCOIzSKgKtFy8xAriM0GFN//4gYbSKuoQIRE94lK kLAIUMmpp8fBljIL3GSUuLbBEsQWFoiXOLh9KlArF9D4aywShy/+ZQFJcAoES9x628g6gRHo RITjZiEcNwvhuAWMzKsYJVILkguKk9JzDfNSy/WKE3OLS/PS9ZLzczcxgqP6mdQOxoO73A8x CnAwKvHwPtg+PVyINbGsuDL3EKMEB7OSCK+17oxwId6UxMqq1KL8+KLSnNTiQ4ymQO9NZJYS Tc4HJpy8knhDYxMzI0sjc0MLI2NzJXHex//XhQkJpCeWpGanphakFsH0MXFwSjUwRsv3vtS/ +qfKS8AsXujvtcI/gX/vHfpSU+mjKbXZ5dx3ti/bg2dbui2bHOiXy30rWdD3paJ3cvnhEMG6 q+l7v8nsTb5eKONp8Wn98p71XyLtOMzPeuxnm/GELd7g2czbfs0Jul9PhUp8yeSeYNUvwNbZ cedO8qwDmnZ+NwKXxGfEXFxuWRWixFKckWioxVxUnAgANuuE7wADAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 07월 27일 12:51, Guenter Roeck wrote: > On Tue, Jul 26, 2016 at 8:42 PM, Chanwoo Choi wrote: >> Hi Chris, >> >> On 2016년 07월 27일 11:09, Chris Zhong wrote: >>> Hi Guernter >>> >>> On 07/27/2016 09:44 AM, Guenter Roeck wrote: >>>> Hi Chris, >>>> >>>> On Tue, Jul 26, 2016 at 6:15 PM, Chris Zhong wrote: >>>> >>>> [ ... ] >>>> >>>>>> > + >>>>>> > +/* Properties of EXTCON_TYPE_DISP. */ >>>>>> > +#define EXTCON_PROP_DISP_MIN 150 >>>>>> > +#define EXTCON_PROP_DISP_MAX 150 >>>>>> > +#define EXTCON_PROP_DISP_CNT (EXTCON_PROP_DISP_MAX - >>>>>> EXTCON_PROP_DISP_MIN) >>>>>> >>>>>> + 1 >>>>>> >>>>>> >>>>>> ok. >>>>> >>>>> Tested with these "+1", it works for my DP patch. >>>>> >>>> You should be able to use >>>> https://chromium-review.googlesource.com/#/c/363623/1 as baseline (if >>>> you didn't do that already). >>>> >>>> Thanks, >>>> Guenter >>> >>> Thanks Guenter, and I saw this bug has fixed in extcon-test branch. >>> >>> >> >> Do you test it with extcon_set_property_capability()? >> And if you test this patch-es, could you send the tested-by tag for these patches? >> > > For my part I did. Above link is public, so you should be able to see > the complete patch set which uses the new API from > drivers/extcon/extcon-cros_ec.c. > > I'll re-test tomorrow with the updated patches from your test branch. OK. Thanks. Regards, Chanwoo Choi