From: Chris Zhong <zyw@rock-chips.com>
To: Chanwoo Choi <cw00.choi@samsung.com>, Guenter Roeck <groeck@google.com>
Cc: chanwoo@kernel.org, linux-kernel <linux-kernel@vger.kernel.org>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
Guenter Roeck <groeck@chromium.org>,
cpgs@samsung.com
Subject: Re: [PATCH 2/6] extcon: Add the support for extcon property according to extcon type
Date: Wed, 27 Jul 2016 12:30:50 +0800 [thread overview]
Message-ID: <579838FA.5@rock-chips.com> (raw)
In-Reply-To: <5798311E.9080603@samsung.com>
Hi Chanwoo
On 07/27/2016 11:57 AM, Chanwoo Choi wrote:
> On 2016년 07월 27일 12:51, Guenter Roeck wrote:
>> On Tue, Jul 26, 2016 at 8:42 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>>> Hi Chris,
>>>
>>> On 2016년 07월 27일 11:09, Chris Zhong wrote:
>>>> Hi Guernter
>>>>
>>>> On 07/27/2016 09:44 AM, Guenter Roeck wrote:
>>>>> Hi Chris,
>>>>>
>>>>> On Tue, Jul 26, 2016 at 6:15 PM, Chris Zhong <zyw@rock-chips.com> wrote:
>>>>>
>>>>> [ ... ]
>>>>>
>>>>>>> > +
>>>>>>> > +/* Properties of EXTCON_TYPE_DISP. */
>>>>>>> > +#define EXTCON_PROP_DISP_MIN 150
>>>>>>> > +#define EXTCON_PROP_DISP_MAX 150
>>>>>>> > +#define EXTCON_PROP_DISP_CNT (EXTCON_PROP_DISP_MAX -
>>>>>>> EXTCON_PROP_DISP_MIN)
>>>>>>>
>>>>>>> + 1
>>>>>>>
>>>>>>>
>>>>>>> ok.
>>>>>> Tested with these "+1", it works for my DP patch.
>>>>>>
>>>>> You should be able to use
>>>>> https://chromium-review.googlesource.com/#/c/363623/1 as baseline (if
>>>>> you didn't do that already).
>>>>>
>>>>> Thanks,
>>>>> Guenter
>>>> Thanks Guenter, and I saw this bug has fixed in extcon-test branch.
>>>>
>>>>
>>> Do you test it with extcon_set_property_capability()?
>>> And if you test this patch-es, could you send the tested-by tag for these patches?
>>>
Yes, the new API need this extcon_set_property_capability to be called
before setting property.
On this basis, My DP patches works well with a little bit modification.
Then, I will post the V7 version soon, base on this patches and
Guenter's FIXUP patch.
Please feel free to add my Tested-by: Chris Zhong <zyw@rock-chips.com>
tag in the next version.
>> For my part I did. Above link is public, so you should be able to see
>> the complete patch set which uses the new API from
>> drivers/extcon/extcon-cros_ec.c.
>>
>> I'll re-test tomorrow with the updated patches from your test branch.
> OK. Thanks.
>
> Regards,
> Chanwoo Choi
>
>
>
next prev parent reply other threads:[~2016-07-27 4:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 12:09 [PATCH 0/6] extcon: Add the support for extcon type and property Chanwoo Choi
2016-07-26 12:09 ` [PATCH 1/6] extcon: Add the extcon_type to group each connector into five category Chanwoo Choi
2016-07-26 12:09 ` [PATCH 2/6] extcon: Add the support for extcon property according to extcon type Chanwoo Choi
2016-07-26 22:06 ` Guenter Roeck
[not found] ` <CAGTfZH2rPyhSiXU=62RKTaE40fok5iiWM+G=+V147gGq8wv_Bw@mail.gmail.com>
2016-07-27 1:15 ` Chris Zhong
2016-07-27 1:44 ` Guenter Roeck
2016-07-27 2:09 ` Chris Zhong
2016-07-27 3:42 ` Chanwoo Choi
2016-07-27 3:51 ` Guenter Roeck
2016-07-27 3:57 ` Chanwoo Choi
2016-07-27 4:30 ` Chris Zhong [this message]
2016-07-27 17:24 ` Guenter Roeck
2016-07-29 7:02 ` Chanwoo Choi
2016-07-26 12:09 ` [PATCH 3/6] extcon: Add the support for the capability of each property Chanwoo Choi
2016-07-26 12:09 ` [PATCH 4/6] extcon: Rename the extcon_set/get_state() to maintain the function naming pattern Chanwoo Choi
2016-07-26 12:09 ` [PATCH 5/6] extcon: Add the synchronization extcon APIs to support the notification Chanwoo Choi
2016-07-27 7:30 ` Chris Zhong
2016-07-27 7:41 ` Chanwoo Choi
2016-07-26 12:09 ` [PATCH 6/6] extcon: Add EXTCON_DISP_DP and the property for USB Type-C Chanwoo Choi
[not found] ` <CGME20160726120955epcas1p1379233158fe6612133799eb2255a5247@epcas1p1.samsung.com>
2016-07-27 4:27 ` [PATCH 1/6] extcon: Add the extcon_type to group each connector into five category MyungJoo Ham
2016-07-27 5:35 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579838FA.5@rock-chips.com \
--to=zyw@rock-chips.com \
--cc=chanwoo@kernel.org \
--cc=cpgs@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox