From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759340AbcG0EbQ (ORCPT ); Wed, 27 Jul 2016 00:31:16 -0400 Received: from regular1.263xmail.com ([211.150.99.136]:38713 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751702AbcG0EbC (ORCPT ); Wed, 27 Jul 2016 00:31:02 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: zyw@rock-chips.com X-FST-TO: cpgs@samsung.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zyw@rock-chips.com X-UNIQUE-TAG: <2fef0bde218da37e87958206b255ded9> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 2/6] extcon: Add the support for extcon property according to extcon type To: Chanwoo Choi , Guenter Roeck References: <1469534988-8305-1-git-send-email-cw00.choi@samsung.com> <1469534988-8305-3-git-send-email-cw00.choi@samsung.com> <57980B2D.7090307@rock-chips.com> <579817EF.7090905@rock-chips.com> <57982DB8.4050703@samsung.com> <5798311E.9080603@samsung.com> Cc: chanwoo@kernel.org, linux-kernel , "myungjoo.ham@samsung.com" , Guenter Roeck , cpgs@samsung.com From: Chris Zhong Message-ID: <579838FA.5@rock-chips.com> Date: Wed, 27 Jul 2016 12:30:50 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5798311E.9080603@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chanwoo On 07/27/2016 11:57 AM, Chanwoo Choi wrote: > On 2016년 07월 27일 12:51, Guenter Roeck wrote: >> On Tue, Jul 26, 2016 at 8:42 PM, Chanwoo Choi wrote: >>> Hi Chris, >>> >>> On 2016년 07월 27일 11:09, Chris Zhong wrote: >>>> Hi Guernter >>>> >>>> On 07/27/2016 09:44 AM, Guenter Roeck wrote: >>>>> Hi Chris, >>>>> >>>>> On Tue, Jul 26, 2016 at 6:15 PM, Chris Zhong wrote: >>>>> >>>>> [ ... ] >>>>> >>>>>>> > + >>>>>>> > +/* Properties of EXTCON_TYPE_DISP. */ >>>>>>> > +#define EXTCON_PROP_DISP_MIN 150 >>>>>>> > +#define EXTCON_PROP_DISP_MAX 150 >>>>>>> > +#define EXTCON_PROP_DISP_CNT (EXTCON_PROP_DISP_MAX - >>>>>>> EXTCON_PROP_DISP_MIN) >>>>>>> >>>>>>> + 1 >>>>>>> >>>>>>> >>>>>>> ok. >>>>>> Tested with these "+1", it works for my DP patch. >>>>>> >>>>> You should be able to use >>>>> https://chromium-review.googlesource.com/#/c/363623/1 as baseline (if >>>>> you didn't do that already). >>>>> >>>>> Thanks, >>>>> Guenter >>>> Thanks Guenter, and I saw this bug has fixed in extcon-test branch. >>>> >>>> >>> Do you test it with extcon_set_property_capability()? >>> And if you test this patch-es, could you send the tested-by tag for these patches? >>> Yes, the new API need this extcon_set_property_capability to be called before setting property. On this basis, My DP patches works well with a little bit modification. Then, I will post the V7 version soon, base on this patches and Guenter's FIXUP patch. Please feel free to add my Tested-by: Chris Zhong tag in the next version. >> For my part I did. Above link is public, so you should be able to see >> the complete patch set which uses the new API from >> drivers/extcon/extcon-cros_ec.c. >> >> I'll re-test tomorrow with the updated patches from your test branch. > OK. Thanks. > > Regards, > Chanwoo Choi > > >