From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759364AbcG0FgS (ORCPT ); Wed, 27 Jul 2016 01:36:18 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:51760 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759346AbcG0FgA (ORCPT ); Wed, 27 Jul 2016 01:36:00 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68d-f79286d000007a9a-f5-5798483da17d Content-transfer-encoding: 8BIT Message-id: <5798483D.2090904@samsung.com> Date: Wed, 27 Jul 2016 14:35:57 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: myungjoo.ham@samsung.com, "linux-kernel@vger.kernel.org" Cc: "zyw@rock-chips.com" , "groeck@chromium.org" , "cwchoi00@gmail.com" Subject: Re: [PATCH 1/6] extcon: Add the extcon_type to group each connector into five category References: <1469534988-8305-1-git-send-email-cw00.choi@samsung.com> <757384616.167210.1469593665960.JavaMail.weblogic@ep1ml101a> In-reply-to: <757384616.167210.1469593665960.JavaMail.weblogic@ep1ml101a> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKIsWRmVeSWpSXmKPExsWyRsSkQNfWY0a4weOr+hbPjmpbnHq1jNni 8q45bBa3G1ewWcx/sIPZgdVjdsNFFo+ds+6ye/ydtZ/Fo2/LKkaPz5vkAlijuGxSUnMyy1KL 9O0SuDKObW5hKnjFV3HjyQeWBsZj3F2MnBwSAiYS5/fOYYawxSQu3FvP1sXIxSEksIJRYvO7 F+wwRZO/LoFKzGKUWNZzGizBKyAo8WPyPZYuRg4OZgF5iSOXsiFMdYkpU3Ihyh8wStxqvMAK Ua4lsWHBRxYQm0VAVWLz3JtgY9iA4vtf3GAD6RUViJDoPlEJEhYRiJVom/qVFWQOs0Ano0R/ 005GkISwQKLEgb1XmSAWXGeUWP10LtgHnAKeEhsvn2SBOPoYu8SZT5oQywQkvk0+BHanhICs xKYDUA9LShxccYNlAqPYLCTfzEL4ZhbCNwsYmVcxiqYWJBcUJ6UXGeoVJ+YWl+al6yXn525i BMbW6X/Pencw3j5gfYhRgINRiYfXYtf0cCHWxLLiytxDjKZAN0xklhJNzgdGcF5JvKGxmZGF qYmpsZG5pZmSOK+i1M9gIYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxSDYxNBcJLOrNvq6SpijY/ dl/D/fXIoqn79IMmSzx+m96m+vr7C5dpNR6X7wktNevZV3yQfYbO03Wcu5ZcjHEKyDxzvuCK 7YelzXMmFC/aH+wf3fS2JWzmzEmORxPqvtlVyRzsnaZ06uay5L32kgkvHk+bWbr2r8CWsEw1 jvOyL+bNTxY2E//G/KxTiaU4I9FQi7moOBEA+CBRGagCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsVy+t9jQV1bjxnhBk9/alo8O6ptcerVMmaL y7vmsFncblzBZjH/wQ5mB1aP2Q0XWTx2zrrL7vF31n4Wj74tqxg9Pm+SC2CNamC0yUhNTEkt UkjNS85PycxLt1XyDo53jjc1MzDUNbS0MFdSyEvMTbVVcvEJ0HXLzAFarqRQlphTChQKSCwu VtK3wzQhNMRN1wKmMULXNyQIrsfIAA0krGHMOLa5hangFV/FjScfWBoYj3F3MXJySAiYSEz+ uoQNwhaTuHBvPZDNxSEkMItRYlnPaXaQBK+AoMSPyfdYuhg5OJgF5CWOXMqGMNUlpkzJhSh/ wChxq/ECK0S5lsSGBR9ZQGwWAVWJzXNvgo1hA4rvf3GDDaRXVCBCovtEJUhYRCBWom3qV1aQ OcwCnYwS/U07GUESwgKJEgf2XmWCWHCdUWL107nMIAlOAU+JjZdPskxgBLoS4bxZCOfNQjhv ASPzKkaJ1ILkguKk9FyjvNRyveLE3OLSvHS95PzcTYzgCH4mvYPx8C73Q4wCHIxKPLwMV6aH C7EmlhVX5h5ilOBgVhLh/ec8I1yINyWxsiq1KD++qDQntfgQoynQfxOZpUST84HJJa8k3tDY xMzI0sjc0MLI2FxJnPfx/3VhQgLpiSWp2ampBalFMH1MHJxSDYzRBYHa22fWf1Mw9Ht6UH/b M3mT73s1TpxboWjbkWs0g+t4udE31gsOJZOnX1vatCluhcTU+wzhieFb7jT8PWD6xiC9cOn5 SO9ygTvFO0wvrvPPlojZVXlR7PUb9/Avj99uULHfGqpx88q976/lMu1exB2W0s8I/5euEq91 n2G/X9repQkNCW+VWIozEg21mIuKEwF+JyqK9gIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Myungjoo, On 2016년 07월 27일 13:27, MyungJoo Ham wrote: >> This patch adds the new extcon type to group the each connecotr >> into following five category. This type would be used to handle >> the connectors as a group unit instead of a connector unit. >> - EXTCON_TYPE_USB : USB connector >> - EXTCON_TYPE_CHG : Charger connector >> - EXTCON_TYPE_JACK : Jack connector > > "Jack" seems to be an internal jargon that many people won't recognize. > It's, in fact, 3.5-pi, isn't it? You're right. But, the ALSA framework already used the 'jack' word for headphone/headset/microphone for a long time. (sound/soc/soc-jack.c) So, To prevent the confusion, I use the 'jack' word. > > Anyway, this is already being used as an enum with drivers, > I'd suggest to add a comment in extcon.h stating that > "Jack connector" is usually the 3.5-pi earbud connector. Additionally, jack means the the LINE_IN/OUT, VIDEO_IN/OUT, SPDIF_IN/OUT in the extcon. > > Anyway, I like the direction of this patch. Thanks. > > > Signed-off-by: MyungJoo Ham Regards, Chanwoo Choi > > Cheers, > MyungJoo > >> --- a/include/linux/extcon.h >> +++ b/include/linux/extcon.h >> @@ -29,6 +29,15 @@ >> #include >> >> /* >> + * Define the type of supported external connectors >> + */ >> +#define EXTCON_TYPE_USB BIT(0) /* USB connector */ >> +#define EXTCON_TYPE_CHG BIT(1) /* Charger connector */ >> +#define EXTCON_TYPE_JACK BIT(2) /* Jack connector */ > + /* Usually, this is a 3.5-pi earbud conector */ >> +#define EXTCON_TYPE_DISP BIT(3) /* Display connector */ >> +#define EXTCON_TYPE_MISC BIT(4) /* Miscellaneous connector */ >> + >> +/* >> * Define the unique id of supported external connectors >> */ >> #define EXTCON_NONE 0 >> -- >> 1.9.1 >>