From: David Daney <ddaney@caviumnetworks.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jan Glauber <jan.glauber@caviumnetworks.com>,
<linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>,
"Steven J. Hill" <steven.hill@cavium.com>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 6/6] spi: octeon: Add thunderx driver
Date: Wed, 27 Jul 2016 11:25:10 -0700 [thread overview]
Message-ID: <5798FC86.8040601@caviumnetworks.com> (raw)
In-Reply-To: <20160727181205.GT11806@sirena.org.uk>
On 07/27/2016 11:12 AM, Mark Brown wrote:
> On Mon, Jul 25, 2016 at 09:31:15AM -0700, David Daney wrote:
>> On 07/25/2016 09:16 AM, Mark Brown wrote:
>
>>> The usual pattern would be something like (ARCH_THUNDER || COMPILE_TEST)
>>> && PCI && 64BIT (so that people on other platforms where the device will
>>> never actually appear don't get bothered by the prompt).
>
>> ARCH_THUNDER needs to die, so perhaps it should be (ARM64 || COMPILE_TEST)
>> && PCI && 64BIT if you really want to hide it from non-arm64 kernel configs.
>
> It does? Why?
It adds clutter. If we build a generic kernel, we first must select all
the ARCH_*, then go back and select the devices we want. Not much of a
value add.
Better to just directly select the devices and remove this middle ARCH_*
layer.
Also who is responsible for making sure the proper ARCH_* constraints
are maintained? If we remove ARCH_THUNDER, no need to worry about this.
> One of the functions of the vendor specific Kconfig
> options is to improve UX when configuring the kernel, if you're building
> for a particular SoC or set of SoCs then we can avoid showing you
> drivers that can never possibly appear in your system which makes life
> a bit easier. We shouldn't be using them in the code itself but they do
> help people in Kconfig.
>
next prev parent reply other threads:[~2016-07-27 18:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-23 10:42 [PATCH 0/6] SPI ThunderX driver Jan Glauber
2016-07-23 10:42 ` [PATCH 1/6] spi: octeon: Convert driver to use readq()/writeq() functions Jan Glauber
2016-07-23 10:42 ` [PATCH 2/6] spi: octeon: Store system clock freqency in struct octeon_spi Jan Glauber
2016-07-23 10:42 ` [PATCH 3/6] spi: octeon: Put register offsets into a struct Jan Glauber
2016-07-23 10:42 ` [PATCH 4/6] spi: octeon: Move include file from arch/mips to drivers/spi Jan Glauber
2016-07-23 10:42 ` [PATCH 5/6] spi: octeon: Split driver into Octeon specific and common parts Jan Glauber
2016-07-24 18:38 ` Paul Gortmaker
2016-07-25 11:32 ` Jan Glauber
2016-07-24 20:54 ` Mark Brown
2016-07-25 11:37 ` Jan Glauber
2016-07-25 17:49 ` [PATCH v2] " Jan Glauber
2016-07-23 10:42 ` [PATCH 6/6] spi: octeon: Add thunderx driver Jan Glauber
2016-07-24 21:04 ` Mark Brown
2016-07-25 15:51 ` Jan Glauber
2016-07-25 16:16 ` Mark Brown
2016-07-25 16:31 ` David Daney
2016-07-25 17:56 ` [PATCH v2] " Jan Glauber
2016-07-27 18:08 ` Mark Brown
2016-07-28 8:12 ` Jan Glauber
2016-07-28 13:58 ` Mark Brown
2016-07-27 18:12 ` [PATCH 6/6] " Mark Brown
2016-07-27 18:25 ` David Daney [this message]
2016-07-27 19:08 ` Mark Brown
2016-07-25 16:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5798FC86.8040601@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=broonie@kernel.org \
--cc=david.daney@cavium.com \
--cc=jan.glauber@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=steven.hill@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox