From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757982AbcG0SZU (ORCPT ); Wed, 27 Jul 2016 14:25:20 -0400 Received: from mail-bn3nam01on0074.outbound.protection.outlook.com ([104.47.33.74]:63467 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753597AbcG0SZQ (ORCPT ); Wed, 27 Jul 2016 14:25:16 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@cavium.com; Message-ID: <5798FC86.8040601@caviumnetworks.com> Date: Wed, 27 Jul 2016 11:25:10 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Mark Brown CC: Jan Glauber , , , "Steven J. Hill" , David Daney Subject: Re: [PATCH 6/6] spi: octeon: Add thunderx driver References: <20160724210452.GB6345@sirena.org.uk> <20160725155122.GA2710@hardcore> <20160725161632.GD11806@sirena.org.uk> <57963ED3.4090402@caviumnetworks.com> <20160727181205.GT11806@sirena.org.uk> In-Reply-To: <20160727181205.GT11806@sirena.org.uk> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [50.233.148.158] X-ClientProxiedBy: BY2PR07CA0091.namprd07.prod.outlook.com (10.166.107.44) To CY1PR07MB2136.namprd07.prod.outlook.com (10.164.112.14) X-MS-Office365-Filtering-Correlation-Id: 310e9edd-72b3-4caa-63ae-08d3b64b595b X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2136;2:Rr2hIS19UiNhaY0Gk18FKcX2ss6ERj398BhV2SDLKpwB72q2tYxJFU5iQ/stm+cpGgdfmza5jcq9jhj4TfSrRVE6ZSsX4HWOsFbnpj8ttxaBfSkpaRwmNoI1f2J4FHbX/MrUGFXz8mSFWmqOSyRPlSjmEgrnwNUjYtdLXH2s+EPhLlmv+Ta3zeM6JEjMbNjd;3:lhmTeM4nWNC2QA+3/cfMXc6uEbbSOdg2Ck4f/JsOGU2eThM51luDMWLQ9mxUwGrGruxOPy+Wvv9bBFWt3HJ6upHCDmNeQPnLgoJIpglH5JLwZXtIsyYw7Qyxr4CsoG2L X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2136; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2136;25:4zn+YR7qERUmRkT0hQOb9+m+N4jZbpow/LjeBv8gf6zMV9r05dErrr2QGO46IGjQqi6WFKDeOigsTpLDcvBEHmMLI4BW5ShvN/LLGnxTWwutyySuBi4sCf9ZPRvadtzvBjv2sPtRa0VnE5Ego3/LJWUQOYrOhmbUDSWqaQbSe8WMd1l+ViO47ELkJj2Iu954tqNciA4LHQOXdndMmeYRrc9PvDjlkZEiy4NJJfp/lGwknCCW7ceHyBsR2xsCoHuKSW6ubC7cKQbOnJJWEicJX+CjNBdvE8/lbUKOJx0b/ZLBKOYfMJwjajBm6yxxpB4OtPeXCJ4E2qJXFxiwcogZaWsxqYGEqtD9xmxYSsSDKkA0bCNvlLNDN+354ncVQi7C2Hj3vx/1Pt6JjpG8FC7OvoNhp6qRPrMRw7bzHSIE4nqepeAk729x8orrRh6R0qoQPHBH46kXxWRIGSUcsy5kLdqIngSI5p8HZ4V+RY+JF+/ut1VAmLNNIVAOivbTH0hywwOFM0HlhNpzpbafcuMw4L7vaR1uCKd0rUig2JimjNmqlwT+5O7+eN7gW9Dzdyn4LfKID8kI8lmupSFUL+87BId47VzsNf9X4/ijBAk+fIkVVE3ff4QJhqFWxOnZRNPpSPqrgOGSQyVV6kQ6WIkfLKiBt3xJPuXPc2TI/6Yohxj4ygTBcl3yk5SgMZtG1VRIEqiXqQxvYErmd7G2A/+Yk+hFUX//tVkSFM4V2ZXBZVs=;31:nkhUIvhhu+R1mm0wdOVlCuMOqWUjk6yIo66j5NWffUOkx9yzpi9fijfpA7XaYCOeXBNO9OUE5lFHdDSYFh7wVlYfdRVNtPIWJfg7gWTXIHMgaCc8xKwrPuIWn8WZunCVmvZx633BQ2pfnMkN8cH4JJ1kE1IRnrv3IXNk/bXqsY0um96Bd4xyhx3XAoXZgVHYEKHUnbU0+x/jwoaf5S6XSA== X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2136;20:m2vpd/ufeMU5XgyYqctA5NSizoKKi8NzSrzW5yYd7MMCXR6Dbp7VI/4oBjI33wQ6eoB0JNTovZWmrnzIVlcmOTO+guzAzao3uC9YBMit1j3DXyhjop1j1MIw9DNQwPPeAkVOVTRhoQiaZqR6F+TGuxo75LPjnMQDqye0J6TIqdBbWv7PbOU6WmsbzGGg2gUuVElBYoMilPz68z/WpRoIeY8hw9cKEltbwQjK5DqaJPeQbDoKQ7GxgSYCXeuANFEMDxZNWLWGc56FR2c8opf7wGPtUweVBXWr88vWcD6jdzdQYIM77Ir8DC6wevHWg0p5SlaNu91alULfj42nFJoH6hfidFBM1ZfQELWUkh5IcTIIjcsW41MQNeyx7p01PJJF2jM9CaEGEH8CiOcmwhgG6Du7Z7eVYRmrmArp3oVAVAgUclA7A365lbmRHGY9bi0G14s953Ox0uFnKThl2dp+sGfvNQmULuOrCJ0yYa4FjANG5gxaogSRcznyu0DnrvMYdaXvnOBU8hoZnV72uFNWgecNR1OT+2Pb3S8GXd6YXULAjHAIize1t6K96qlTwYUX2JSOCKVdDTM7055UAjKtGEQR1IVY/hpw4FjeMRjvH6I= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:CY1PR07MB2136;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2136; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2136;4:HQdPPHp8CW271bEthhSlrx5p5MVMxGmDLXaqH+Fg1iopFvXvAWLj2/w2jj0IhsTVQwHyZMCAA/5HANJqbVHS1AbdN9Gp4jlczp9lTldM51YRaoM/y4B17jGvrTZsusICpwqF5uyWyQHbLVSUClv+WcHXYWS56RUAJIALfaGCfeUnn8vUULvAksypr4fIw+60wPwyoM8BA7O65LjTRdaC4KBfcY4m/5zcVy5sl7C/Vwmgh15da+1ALhUESJrnXe3uive6SOzaKkzByiGPOuVGD0tn7ENc9/EIM8TMSZD2/j75mvP2DT8Q+v1mYfxur0RPN7i+lFSfFiWsXZShZnIVejEqAcwo5ZwUXJSd95lD5HYICGRGZ3t2AMOI+FmXzZrL X-Forefront-PRVS: 0016DEFF96 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(377454003)(189002)(24454002)(199003)(47776003)(66066001)(53416004)(42186005)(65806001)(65956001)(59896002)(4001350100001)(3846002)(6116002)(83506001)(92566002)(7736002)(305945005)(69596002)(50986999)(68736007)(23756003)(586003)(80316001)(64126003)(7846002)(76176999)(50466002)(87266999)(54356999)(8676002)(2906002)(77096005)(106356001)(81156014)(81166006)(2950100001)(36756003)(230700001)(97736004)(101416001)(189998001)(110136002)(65816999)(105586002)(93886004)(107886002)(4326007)(33656002)(4001430100002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2136;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;CY1PR07MB2136;23:iJhO61k3R3WOFXzpP8vBEo0XLdpG1LHrMsf0Ndr?= =?iso-8859-1?Q?EI6WfPor/7XOvRLRqznGCmWPg4hhr+LDuBHWHei3Bob3/r4Xb8rcbT57dJ?= =?iso-8859-1?Q?IqIRTIV4YBIHQjUEEHnzQG27Hq3MWaD2e6BX7Aq0FivHGXjUvHnBd97VHn?= =?iso-8859-1?Q?Im42FbM/1Y+DXXzGQ8+LW52cPXS/Q4NwWUOf2THFcHud8b0iF97L+WHqW+?= =?iso-8859-1?Q?vCBQ2aJ9tT4fNhHjbyPJ5cicdDAZmi7ibZbpDCtIczF2T80eMX4kirx3nF?= =?iso-8859-1?Q?0SBCKuXebtoCzVP9odombjiDEu7TP0nBriJBdaBru9kAsMNZlUpXEC6TS7?= =?iso-8859-1?Q?4M/hUBtu7+NRTHiJjxNFUFyhkzMIdUo55seTx3Gq2dQUUAaUu6sGT3Lxpi?= =?iso-8859-1?Q?LZKrUSDSfua+dG9nHu/UicYmaTfEqYiFI/+J+QyiG2GV7djHLW30JG6cs+?= =?iso-8859-1?Q?6m4x47U66Qn7pW+mfbpBPCGslPo4Y6+4T4WUd9YhwpTmy5TZfrY6lQ6PVc?= =?iso-8859-1?Q?guHp6Ac3sPwCczT8UYHbRO3Ezy+GBHGk3EVWnr9ocXPiL7B8H5rB4u/ayk?= =?iso-8859-1?Q?W4uwQptr5zjWduvMuqek0e3Dwj5Ua92cCIuau7iYw083qztOjUhdtewDys?= =?iso-8859-1?Q?/Yu1dif5rT2ivpxAFQotrCmEODpG2gMj0NEIlv2PhKFGcYva4b6LKYqElU?= =?iso-8859-1?Q?AYvl9Xw5U6P+lqQ/vRLgafIM5dg1iHpiyEeIkZn7Kl3Fgx5o8BF8yzhVyL?= =?iso-8859-1?Q?J9QT7xDddTyJ1u9M588aHNB4nbn14OzjylQPJ1f5XDFjjuKioYuduyItbu?= =?iso-8859-1?Q?7Zbog7924PUWXZX3zoQXsrm3+/TwnBt8aD2Zv/qQ+vpM2CCXRBViPwL/hF?= =?iso-8859-1?Q?XGraJ5/DZQKr1ea33D6GaK06dNfooG0mKRBYWvgSqEAST/LnppkTZ5pitf?= =?iso-8859-1?Q?NYlQGNtholRQA//TkDnNDKzbZ310oD57ettWYNopA0gERynrK9weKv03Gg?= =?iso-8859-1?Q?20Zkr0aI5Lq9CWmKHKO3WHseEwver6J1B2bnKCHomIhWNKxrQ6iz6W0DHB?= =?iso-8859-1?Q?86rZxFkx1CN0XQw+qzeG01nL7XhLWwiBVk2eRjdl1KTgz812/aTuewKofk?= =?iso-8859-1?Q?XcXJmDqfOZy/l+vP1QX8aEvpzI3tYEqezgfA5w9sbkSMFgUGeQiKe10mQh?= =?iso-8859-1?Q?tpmo/nUs2YAsCcqYGih+ytFqog4WtCofDy9WngQqUCsg2ipyP3Vm70/qS8?= =?iso-8859-1?Q?OjwHDzxzvjSCmbUjUlZkOHPWQWQmF9A23He7cDeD9aYG3sZpk5SpqdsCH1?= =?iso-8859-1?Q?0jpvGujIwh84zqiq6TJL482gHTpr2Xfl1tcXGQXo5T5xmznMMC7tbp4uu3?= =?iso-8859-1?Q?Bzu73cQA=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2136;6:arK4jzvTSzs+zBJ4yR+XwdwNvHzEHqO6ZMXcuqxHVqga5IhtFqu4la+p+d85n5rkwyLK9mS0QrioHMHEsuXKhTmP6ul7ugw5EG6Y+FIo1t2TSzx1JrJE23J977Bn2gqWSSSgElfwQAha5Kwldx1gBL3nInvzDcQCw2ehlbQoIgmCf+q/i11Ls/Kt8Ey6z8ipbp+JRzJ20PY4KzJgElid8TqMo4e73vWy2AT7dW9spW4+I5sjxoIgMoIZOsTjXnilXesVnrENciUccqmf6Nq9JCf9C3UJCeJA9XVUAQdRqSo=;5:rbmZiZ4mc/LADBw9QwdpouPBeMU8NpryJIMl4SzMfZanIShvPWDWmzkQnTlB1iuhdVPIFzr9XZB6miEcFHZxQAxJQMUt4eJ+NQ6YXhA+oZiIO2+0SLJWUWGqKMZ9zow0T5FDplL2XLwaFpVejfVNfA==;24:pGrsfWh3Nwi2mo3/YSLzsMWNImFYQ+semCdGxL9vBgDcfGJRnvixYOr/Z9kC9bS94jng3R9pJ0DNYztmLVuhl26SDZz1Mkv0myYccJnkGZA=;7:lXtj7dbRiVKqJyEGclKnhLa2oEAWrsmsy5C54+oAal2035g4q3jlxQmaO8RBL2YyaW4W7sOCBD5I+ueJWmDyefcxqyFAYuTzkoZwfJEDePeuh+mkzthlEaAYBEx8aETB7DEnTNt4vvEMbEwwyszc/xgLqFAACTMsz6Ws7YzP/1Ju3Tb+B4Gdj8b8kPNYxaFZsZEOMnoFhA99nBIC6jw4uzTkUthLbt5UvUJebvZ7fA/pb/IIYqlIkCtFkLNy/28M SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2016 18:25:12.4603 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2136 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/27/2016 11:12 AM, Mark Brown wrote: > On Mon, Jul 25, 2016 at 09:31:15AM -0700, David Daney wrote: >> On 07/25/2016 09:16 AM, Mark Brown wrote: > >>> The usual pattern would be something like (ARCH_THUNDER || COMPILE_TEST) >>> && PCI && 64BIT (so that people on other platforms where the device will >>> never actually appear don't get bothered by the prompt). > >> ARCH_THUNDER needs to die, so perhaps it should be (ARM64 || COMPILE_TEST) >> && PCI && 64BIT if you really want to hide it from non-arm64 kernel configs. > > It does? Why? It adds clutter. If we build a generic kernel, we first must select all the ARCH_*, then go back and select the devices we want. Not much of a value add. Better to just directly select the devices and remove this middle ARCH_* layer. Also who is responsible for making sure the proper ARCH_* constraints are maintained? If we remove ARCH_THUNDER, no need to worry about this. > One of the functions of the vendor specific Kconfig > options is to improve UX when configuring the kernel, if you're building > for a particular SoC or set of SoCs then we can avoid showing you > drivers that can never possibly appear in your system which makes life > a bit easier. We shouldn't be using them in the code itself but they do > help people in Kconfig. >