From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163634AbcG0XFm (ORCPT ); Wed, 27 Jul 2016 19:05:42 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:23025 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1163133AbcG0XFf (ORCPT ); Wed, 27 Jul 2016 19:05:35 -0400 Message-ID: <57993E21.7050409@oracle.com> Date: Thu, 28 Jul 2016 07:05:05 +0800 From: Bob Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= CC: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, konrad.wilk@oracle.com Subject: Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources References: <1469589685-31630-1-git-send-email-bob.liu@oracle.com> <20160727105949.3rtlnl2zr4lpsvbc@mac> <57989921.5040504@oracle.com> <20160727142420.esp7aharesu45ixr@mac> In-Reply-To: <20160727142420.esp7aharesu45ixr@mac> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/27/2016 10:24 PM, Roger Pau Monné wrote: > On Wed, Jul 27, 2016 at 07:21:05PM +0800, Bob Liu wrote: >> >> On 07/27/2016 06:59 PM, Roger Pau Monné wrote: >>> On Wed, Jul 27, 2016 at 11:21:25AM +0800, Bob Liu wrote: >>> [...] >>>> +static ssize_t dynamic_reconfig_device(struct blkfront_info *info, ssize_t count) >>>> +{ >>>> + /* >>>> + * Prevent new requests even to software request queue. >>>> + */ >>>> + blk_mq_freeze_queue(info->rq); >>>> + >>>> + /* >>>> + * Guarantee no uncompleted reqs. >>>> + */ >>> >>> I'm also wondering, why do you need to guarantee that there are no >>> uncompleted requests? The resume procedure is going to call blkif_recover >>> that will take care of requeuing any unfinished requests that are on the >>> ring. >>> >> >> Because there may have requests in the software request queue with more segments than >> we can handle(if info->max_indirect_segments is reduced). >> >> The blkif_recover() can't handle this since blk-mq was introduced, >> because there is no way to iterate the sw-request queues(blk_fetch_request() can't be used by blk-mq). >> >> So there is a bug in blkif_recover(), I was thinking implement the suspend function of blkfront_driver like: > > Hm, this is a regression and should be fixed ASAP. I'm still not sure I > follow, don't blk_queue_max_segments change the number of segments the > requests on the queue are going to have? So that you will only have to > re-queue the requests already on the ring? > That's not enough, request queues were split to software queues and hardware queues since blk-mq was introduced. We need to consider two more things: * Stop new requests be added to software queues before blk_queue_max_segments() is called(still using old 'max-indirect-segments'). I didn't see other way except call blk_mq_freeze_queue(). * Requests already in software queues but with old 'max-indirect-segments' also have to be re-queued based on new 'max-indirect-segments'. Neither blk-mq API can do this. > Waiting for the whole queue to be flushed before suspending is IMHO not > acceptable, it introduces an unbounded delay during migration if the backend > is slow for some reason. > Right, I also hope there is better solution. -- Regards, -Bob