From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751416AbcG2Deu (ORCPT ); Thu, 28 Jul 2016 23:34:50 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:33239 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750754AbcG2Der (ORCPT ); Thu, 28 Jul 2016 23:34:47 -0400 MIME-version: 1.0 Content-type: text/plain; charset=gbk X-AuditID: cbfee68d-f79286d000007a9a-81-579aced45c3b Content-transfer-encoding: 8BIT Message-id: <579ACED4.2010900@samsung.com> Date: Fri, 29 Jul 2016 12:34:44 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Shawn Lin , linux-mmc@vger.kernel.org Cc: ulf.hansson@linaro.org, linux-kernel@vger.kernel.org, Rob Herrin , mark.rutland@arm.com, devicetree@vger.kernel.org Subject: Re: [PATCH 2/2] mmc: dw_mmc: remove the deprecated "supports-highspeed" property References: <1469699727-23339-1-git-send-email-jh80.chung@samsung.com> <1469699727-23339-2-git-send-email-jh80.chung@samsung.com> <0dc812a2-8b80-03cf-b253-58f7f45ab72b@rock-chips.com> In-reply-to: <0dc812a2-8b80-03cf-b253-58f7f45ab72b@rock-chips.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAIsWRmVeSWpSXmKPExsWyRsSkQPfKuVnhBuc3mlvMP3KO1eLyrjls Fkf+9zNaLL1+kcmide8Rdos7T9azWhxfG+7A7rFm3hpGj02rOtk87lzbw+bxd9Z+Fo/Pm+QC WKO4bFJSczLLUov07RK4MmbcecRc8JKr4tD6dSwNjLs5uhg5OSQETCRmrLzACGGLSVy4t56t i5GLQ0hgBaPEpK07GWGKlkz5zAqRWMooMbnnKitIgldAUOLH5HssXYwcHMwC8hJHLmWDhJkF VCW2fb3DAmILCTxglHjzQx2iXEviwd0rTCA2C1DN5lWb2EFsNgEdie3fjoPFRQXCJB6s2ws2 XkTAWaJ50V1WiJn9jBLbtyqD2MIC0RJPv55khZjfzyRx9oUSiM0p4CTxv7OfCeROCYFL7BKd fX/YIJYJSHybfAjsTgkBWYlNB5gh/pKUOLjiBssERrFZSL6ZhfDNLCTfLGBkXsUomlqQXFCc lF5kqFecmFtcmpeul5yfu4kRGHGn/z3r3cF4+4D1IUYBDkYlHt4Z0rPChVgTy4orcw8xmgId MZFZSjQ5HxjXeSXxhsZmRhamJqbGRuaWZkrivIpSP4OFBNITS1KzU1MLUovii0pzUosPMTJx cEo1MF4W2OCWsEUh+THruwyvs7/+L7/nULD2ivfUxt1KFr/dZ/U3NFTyPOSZ27DmrswPkdUr PySfq7Ov678q4BQuqe5gL8P0TiXznsah+yZpfT91FwecE2bMTDhj8K1ic/Rxse4Vq24b7Sxd uDmOWaP9f2HKkuX6DUkiWvebI04HlbnP0JZb35p8VomlOCPRUIu5qDgRAA8/O2CzAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsVy+t9jAd0r52aFGzw7Zmgx/8g5VovLu+aw WRz5389osfT6RSaL1r1H2C3uPFnPanF8bbgDu8eaeWsYPTat6mTzuHNtD5vH31n7WTw+b5IL YI1qYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xNtVVy8QnQdcvMATpD SaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5vSBBcj5EBGkhYw5gx484j5oKXXBWH1q9jaWDc zdHFyMkhIWAisWTKZ1YIW0ziwr31bF2MXBxCAksZJSb3XAVL8AoISvyYfI+li5GDg1lAXuLI pWyQMLOAqsS2r3dYQGwhgQeMEm9+qEOUa0k8uHuFCcRmAarZvGoTO4jNJqAjsf3bcbC4qECY xIN1e8HGiwg4SzQvussKMbOfUWL7VmUQW1ggWuLp15OsEPP7mSTOvlACsTkFnCT+d/YzTWAU mIXkulkI181Cct0CRuZVjBKpBckFxUnpuYZ5qeV6xYm5xaV56XrJ+bmbGMFR/UxqB+PBXe6H GAU4GJV4eAVaZ4ULsSaWFVfmHmKU4GBWEuFVPQsU4k1JrKxKLcqPLyrNSS0+xGgK9N9EZinR 5HxgwskriTc0NjEzsjQyN7QwMjZXEud9/H9dmJBAemJJanZqakFqEUwfEwenVAOj8N3fVtNS n/crsf68eeDFZMXzhi9rvFfJx2X/WzI/d6FdWNWsg+5cKzaE3nzwO3eCy4uGFLMMbt3rOiWz n23v38KWt1xr041Jbk2ZV1vnF/tbz7SPW/M2J+6UdpNemPSSvRXHjnLX3pkywdF4G8v8Ned3 +t+Yrx546T+/lfbvXX5G/RZujC08SizFGYmGWsxFxYkA3WPRqQADAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shawn, On 07/29/2016 11:44 AM, Shawn Lin wrote: > ÔÚ 2016/7/28 17:55, Jaehoon Chung дµÀ: >> Remvoe the deprecated "supports-highspeed" property. >> DWMMC controller will not use this property anymore. >> > > We had set up a flag day to remove these deprecated property > long time agao. > > It doesn't *break* old dtb which may(not ?) still boot up new > kernel code as we just make it suffer from lower speed, then > I think it's time for them to migrate to the new property anyway. Thanks for reviewing! Best Regards, Jaehoon Chung > > So, > > Reviewed-by: Shawn Lin > >> Signed-off-by: Jaehoon Chung >> --- >> drivers/mmc/host/dw_mmc.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c >> index 1b719a6..e9faedd 100644 >> --- a/drivers/mmc/host/dw_mmc.c >> +++ b/drivers/mmc/host/dw_mmc.c >> @@ -2890,11 +2890,6 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host) >> return ERR_PTR(ret); >> } >> >> - if (of_find_property(np, "supports-highspeed", NULL)) { >> - dev_info(dev, "supports-highspeed property is deprecated.\n"); >> - pdata->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED; >> - } >> - >> return pdata; >> } >> >> > >