From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753173AbcG2PkU (ORCPT ); Fri, 29 Jul 2016 11:40:20 -0400 Received: from mail-db5eur01on0096.outbound.protection.outlook.com ([104.47.2.96]:58007 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753102AbcG2PkQ (ORCPT ); Fri, 29 Jul 2016 11:40:16 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH 1/1] UBSAN: use uppercase K to format a kernel pointer To: Nicolas Iooss , Andrew Morton References: <20160729111053.21306-1-nicolas.iooss_linux@m4x.org> CC: From: Andrey Ryabinin Message-ID: <579B5518.1020407@virtuozzo.com> Date: Fri, 29 Jul 2016 16:07:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160729111053.21306-1-nicolas.iooss_linux@m4x.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM4PR01CA0001.eurprd01.prod.exchangelabs.com (10.164.74.139) To HE1PR0801MB1980.eurprd08.prod.outlook.com (10.168.94.150) X-MS-Office365-Filtering-Correlation-Id: cab28bc8-dd0a-4a26-6679-08d3b7b12632 X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1980;2:gi+t9lCTGaU1ipPyGfcVzKmaz8O0mepVin7V7v7n80k0DHey6cV43VxY2M90FGSK2Gc900ajPwArQBlnngNR37zZt9wsRcSl5Hy5eMih2jnqCvi80awsOEiMxmuvXomWjqSlHSj7t1YnhrU2Mc97K9XHe866inXZfqGY5u70sJTUFZcenwWhD/sx7xU18grv;3:3t9cuCv7wPmgS2Vkxs0BI2c79W+y5sVZj87NFtXmL8BrQTsZG+FxyS4vhdXJ7XPtbFT+mjfnyDnzxzCPr575h0YGhM4oAGZuDzgPOXwvx6xEfQziniKhUXgIKGLhiAc9;25:i8bAZSWBm3hQvMXdkx7B68k9c9nbQ/WTS6bvEnCJDGBW4jKzkCqR+cYPKtW/7HzXKRaYKD1lhIYtHjgUpXquNX09t83aN330z8c3ahfEgmHtSUvlZsmW2ARBoiTHOn1eD70l/CQjI9MiRD6OrZ63HCVT/DYMgoXMNOpCdQfvzRtyBJWZB02+guytkWI3iVs579RTi53o3/IhAC67VOFiEqVB4+ClOH+7sWESlVZQDSZgXD26swJ8E3K9ZxFDYHgrzABgXilO+gbGR/+X/hQelNS27aTxYdU6GV+yA1JlqVRfEAtNPRKZkj+xAnTeH2h/ZuyYDGt3hBrXyBdNk+kTuSrl32L/Ip3xL0q9AOk4yljqCJduZTFt5dZNFA25rUSStD21+oR3vtJAlEZKIDcbnqOEa6CDorxJ3G/ZFH1HGqw= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1980; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1980;31:DvRsAmj19WCRG8RKGDjy2JfW8loqhjEHy9WKy7pt7uO1+facOnqUPQA9NshAmqRXV9HJ7SBbo5UoMgYOQBXvNHpQyV0c5+kDjL0SrvXRZvYOEZ6jlMYc2MgjHHG02uy36hCNXYhK8IVr8+3tCgLvHy5mY0viuXRx0XpBuSvzyGYJbo/hobFdmNBXg/DjfASmkjAc3kljmAXMz1NmWDwCqQ==;4:nWbgE3cNysoLENpIUajAkv+PQqXKHerEUqg4je+1veVSIAsT6JQdHFTo/f/EMvtIv4AxfZuibJ7guZvrlgGh72vdnc+mL1QYvllH+m2gEUXfluiBGn4wUpWPW1Bl81NLJ54CV/eaioEWvcRkt98ghUF9SkmDLJlNI3OzHK2I8PBzNi1flP68yX64i4kMw2BNn8Vk3p3dL61pXvB9bYRUALW2Zr+sdW40rNW+0XCkysqa9b/nKbdWye8cgolv38MTeDetWXqza4OykTv0GgY2cvkLSQLXHsiyVArhc3+PpZZGk6nmXp7OJQAjj8Fs+8H+KzGlZXnMdhAOB24y+OfLhpDNPd3CLCi8O57o3FHgX1meADGVBJu8UeDYJ/KUPYCanKPQD9jXntyCPYMhVLMq+c23odryChDtZ3dKFxItyd8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041072)(6043046);SRVR:HE1PR0801MB1980;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1980; X-Forefront-PRVS: 0018A2705B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(199003)(24454002)(189002)(377454003)(8676002)(230700001)(4001350100001)(77096005)(81156014)(586003)(2950100001)(97736004)(5001770100001)(68736007)(189998001)(2906002)(92566002)(23746002)(66066001)(86362001)(65806001)(47776003)(81166006)(65956001)(50986999)(33656002)(42186005)(101416001)(54356999)(87266999)(76176999)(65816999)(105586002)(64126003)(36756003)(59896002)(80316001)(83506001)(7846002)(7736002)(19580405001)(3846002)(305945005)(50466002)(4326007)(6116002)(19580395003)(106356001);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0801MB1980;H:[10.30.19.223];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;HE1PR0801MB1980;23:D+WozQmaespkydjMJV8PU5dzTGpBW5mpgIR?= =?Windows-1252?Q?DQooXrQ7V3n6VqXocjeZzm/0Xqk90L+9sjhiwG81dzxJjg3pZH3NtkXG?= =?Windows-1252?Q?OhFT3XwxV8mxNhRhs59nMJUUFSpNTK3Ut9YkVd/OLeahDNlsn2MdG+5n?= =?Windows-1252?Q?y752yEYzYDqO2sjp7hio/YGR6CRkIXWvy9dKKLlRt5SXV4IjgorSvZuj?= =?Windows-1252?Q?sSsPwgK5MnjAGT+Eny+atJvOX80f2+h9o7bznkIWfy20NqEa+u6yDJaE?= =?Windows-1252?Q?XPVMazVPsbASOP6Mdei7LbOkAwZQOdEG6uEAEoh/WbNxAXaVxl7/R4yy?= =?Windows-1252?Q?kY6JIEcAz4Fj6O44NB2FJdbzS0aGlPfYouGAdg0il4z7icj+cB8abHGk?= =?Windows-1252?Q?mDlAWGqCA0A3+WhkyazX+I8wCRn/BHwT4Oc3OPjOCL8LIgUkJy+pyTzS?= =?Windows-1252?Q?w7cpsNH2D17ERAp4tHBnpeNAvBu9zK3I6WApKTMQ0yr6Cy4W8IxzN7U3?= =?Windows-1252?Q?imi9VuHvwYPhDgSHaM18OfMM1EuzwFG+j3D2GvEHQW9naVOgMHNxqbhD?= =?Windows-1252?Q?9VED3LboVUtr9+cHP27WPG0B0u/CHrSRPDKrxGOQlLCeu+11qoJY2T52?= =?Windows-1252?Q?nmFD57lcLuvlLooieRJ7WrnuDsJyVu/pmtIvcnCqIFQo1hPCQixKh3qz?= =?Windows-1252?Q?SJVWWWEAp/c8/c3vVVolEOxWQJm4Yt7knMNB/0L9b29Hhu+k01wo4REG?= =?Windows-1252?Q?q4RNShO6Gaudo0fb/PRkgYiSU8G4+5ri+Cpec0lOGMoCNJtue9orkr4u?= =?Windows-1252?Q?zIiQlo4xIfND0ev4r9PYjijYH4h3cZC7bTGkA/FUGiLTzZAmS9vzY8BC?= =?Windows-1252?Q?WJhCPRbimDSeV3VvzEc5VeJzgw9IiX05IMctVYWncuQLO5hdgsaifcfn?= =?Windows-1252?Q?xwN9wkzs3pIXwZUE+sf6GUXMZ37NW8tJCTrp/Ep1/iB3ENMHkqZvXZC/?= =?Windows-1252?Q?KUu2oXAPGQZI2kuUmUXhB7EQjx28IC/61oNBvvHSOwOSUtkfXJ3DuC6n?= =?Windows-1252?Q?NrvRepPSCsrOMxR07WEwvZ8POkO5cTvj395zSIiQsAH0tHWIwB87u5e7?= =?Windows-1252?Q?vRwbZvAojwsc6fJev2Zy3LxwGZMJBcTF3EYMsOqW8CqXuzdk2m7j5BBJ?= =?Windows-1252?Q?8RaXTQYVmPzSqLmDsBPnii9mIZKvQ59e/DKHdHAsn2jox/YPrQfU41EF?= =?Windows-1252?Q?2tH4uuXdJnv6fK7/BmuOr1nL/8M/CoUUEJM5tNHTp7/ITTW9/wP+Iu5m?= =?Windows-1252?Q?KRZLmpzBNblcbZlqMJOcaQBYAHDGKB1saH1ONJ8wyBV/0I6UVO345W8y?= =?Windows-1252?Q?t/OfrXHm68JcSfxTyQftUm+alPxW2oCpNpQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1980;6:6VfmEaMRu14GyQrppb90mff9ZQy4ZlmvHYhPR8VZ2ZQlx07HSTSsyQRdYMTy16QWau41sViTcedHwnAkq1G6ppxnp/0PPf3qJf383uEYkxlHv/jc9ehTKOFJhG7pR+OwtinduIyK7YUPtAIUGkShFZzJLWwU81msj6w4u/8NfcepHRsM5fxbjPKn9qAstA71dqJa985wWxF4CwNcMFiHc/yZjH8bQQdTmCgoTpVBkTg+lf9CWSMkVunxBzDT0LsTJoh928SSW+QctpPfNJnrUj42C7yL6pnuJ2gdyW50A1RPHjx2N5T/a8y1PajjuURf;5:p58x70pJbnMGOre9JfH+IaI9orMZaIzZ8H+F/NyWQONiJI018idOoVme0aeC9vTbSktdiL3G/2ygqKRJJij5Juk286IjYWgObx3H3HZchgUJGxrX55mLhjwPMQtVlG6Cayzb+X6g5Jx0GcDl+l1c3A==;24:bvtW2goRhM0JttKmGZeu+GnuNuSkUP0B4au5BtocswJnGf4mlhabcVBR3T9BavKpbvpgH72hONLAvcmm67Q9DAV53Z0tYiLCAW6XaVqsEFM=;7:wlFRhe4ZN9zwretP0K7QN5OAKEMW1JjaArZfJOfjlCW46YMKAOIixXJsgNwZWCckACNAysSunMNJ6nzaJ1VmkBbghjQvlWZx1Lz6DExtkOZIKmbcxJSFMEU+lai71f6BEcRuPyW5vGHtUrL+75EJKyMxWjzsz9FEQoS+PGuRF9ieXDEgwmiQxzfRWnCJ/YF+QhJvApGxr2XjfwAlR1CYUhTTV3aS+fpMqYwFPoc92Ak9yGqQ44DzMt6eNHgh9XdX SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1980;20:1tB94Bx9TR4ZQAEvIKTlcHVk77oNj8xzJVbTdxLrmT7gT0GPd/x41HJrXeFug7mtegAMz53ExQAPbMB6wOwBhs70DgClbiSsDiqQGDOnIl/OYGKzril4vr4W+VGatMejJL1Qlj1NqJnKDY7VhkBHU8OrcUS7n04Ub7b5/cMSqzs= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2016 13:06:26.3580 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1980 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/29/2016 02:10 PM, Nicolas Iooss wrote: > handle_object_size_mismatch() used %pk to format a kernel pointer in > pr_err(). This seems to be a misspelling for %pK. > > Fixes: c6d308534aef ("UBSAN: run-time undefined behavior sanity checker") > Signed-off-by: Nicolas Iooss > --- > lib/ubsan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/ubsan.c b/lib/ubsan.c > index 8799ae5e2e42..d57d1e7e98a3 100644 > --- a/lib/ubsan.c > +++ b/lib/ubsan.c > @@ -308,7 +308,7 @@ static void handle_object_size_mismatch(struct type_mismatch_data *data, > return; > > ubsan_prologue(&data->location, &flags); > - pr_err("%s address %pk with insufficient space\n", > + pr_err("%s address %pK with insufficient space\n", I don't see much sense in using %pK here. It should be fine to use just '%p' here as we already use it in handle_missaligned_access(). > type_check_kinds[data->type_check_kind], > (void *) ptr); > pr_err("for an object of type %s\n", data->type->type_name); >