From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753329AbcG2XQC (ORCPT ); Fri, 29 Jul 2016 19:16:02 -0400 Received: from m50-133.163.com ([123.125.50.133]:44397 "EHLO m50-133.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752032AbcG2XPy (ORCPT ); Fri, 29 Jul 2016 19:15:54 -0400 Message-ID: <579BE31D.6020802@163.com> Date: Sat, 30 Jul 2016 07:13:33 +0800 From: Caesar Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: jic23@kernel.org CC: Rob Herring , Caesar Wang , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, heiko@sntech.de, linux-iio@vger.kernel.org, dianders@chromium.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, john@metanate.com, linux@roeck-us.net Subject: Re: [PATCH v3 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it References: <1469629447-544-1-git-send-email-wxt@rock-chips.com> <20160729212833.GA12688@rob-hp-laptop> In-Reply-To: <20160729212833.GA12688@rob-hp-laptop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID: DdGowADH+gEe45tXv9NDAA--.4824S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7tw4rJF1fuFWrtF1DZw1rCrg_yoW8Gw1Upa yDCFn0kFyDArWxGan7Kw15CFWFv3Wftr4UGry3tas7J3yYvF4jgr1jgF1Fqw1DJr1FkrW0 vr17Ga4UW345A37anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jiCztUUUUU= X-Originating-IP: [103.29.142.67] X-CM-SenderInfo: 5vdv3yhhz03qqrwthudrp/xtbB0wG1lVXlU8brdwAAsL Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年07月30日 05:28, Rob Herring wrote: > On Wed, Jul 27, 2016 at 10:24:04PM +0800, Caesar Wang wrote: >> SARADC controller needs to be reset before programming it, otherwise >> it will not function properly. >> >> Signed-off-by: Caesar Wang >> Cc: Jonathan Cameron >> Cc: Heiko Stuebner >> Cc: Rob Herring >> Cc: linux-iio@vger.kernel.org >> Cc: linux-rockchip@lists.infradead.org >> Tested-by: Guenter Roeck >> >> --- >> >> Changes in v3: >> - %s/devm_reset_control_get_optional()/devm_reset_control_get() >> - add Guente's test tag. >> >> Changes in v2: >> - Make the reset as an optional property, since it should work >> with old devicetrees as well. >> >> .../bindings/iio/adc/rockchip-saradc.txt | 7 +++++ >> drivers/iio/adc/Kconfig | 1 + >> drivers/iio/adc/rockchip_saradc.c | 30 ++++++++++++++++++++++ >> 3 files changed, 38 insertions(+) > Please add acks when posting new versions. I didn't get your ACK when posting the V3. :-P --- Your ack on 2016-07-27 23:12 .../bindings/iio/adc/rockchip-saradc.txt | 7 +++++ Acked-by: Rob Herring > > Rob > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip