From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752193AbcG3CjU (ORCPT ); Fri, 29 Jul 2016 22:39:20 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:3806 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbcG3CjJ (ORCPT ); Fri, 29 Jul 2016 22:39:09 -0400 Message-ID: <579C132C.5050407@huawei.com> Date: Sat, 30 Jul 2016 10:38:36 +0800 From: zhong jiang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Andrew Morton CC: , Subject: Re: [PATCH] fs: wipe off the compiler warn References: <1469803600-44293-1-git-send-email-zhongjiang@huawei.com> <20160729160247.564e27525f04416ef714ddd4@linux-foundation.org> In-Reply-To: <20160729160247.564e27525f04416ef714ddd4@linux-foundation.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.29.68] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.579C1344.0017,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 7bd487d3cb426e7b6fbfe8a13dc81452 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/7/30 7:02, Andrew Morton wrote: > On Fri, 29 Jul 2016 22:46:39 +0800 zhongjiang wrote: > >> From: zhong jiang >> >> when compile the kenrel code, I happens to the following warn. >> fs/reiserfs/ibalance.c:1156:2: warning: ___new_insert_key___ may be used >> uninitialized in this function. >> memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE); >> ^ >> The patch just fix it to avoid the warn. >> >> Signed-off-by: zhong jiang >> --- >> fs/reiserfs/ibalance.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/reiserfs/ibalance.c b/fs/reiserfs/ibalance.c >> index b751eea..512ce95 100644 >> --- a/fs/reiserfs/ibalance.c >> +++ b/fs/reiserfs/ibalance.c >> @@ -818,7 +818,7 @@ int balance_internal(struct tree_balance *tb, >> int order; >> int insert_num, n, k; >> struct buffer_head *S_new; >> - struct item_head new_insert_key; >> + struct item_head uninitialized_var(new_insert_key); >> struct buffer_head *new_insert_ptr = NULL; >> struct item_head *new_insert_key_addr = insert_key; > How do we know this isn't a real bug? It isn't obvious to me that this > warning is a false positive. > > > . > yes ,it maybe a real bug, I will resend it in v2.