From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752732AbcHAKL1 (ORCPT ); Mon, 1 Aug 2016 06:11:27 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:52915 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752080AbcHAKKf convert rfc822-to-8bit (ORCPT ); Mon, 1 Aug 2016 06:10:35 -0400 X-AuditID: cbfee68d-f79286d000007a9a-a3-579f187be09d MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <579F187A.30401@samsung.com> Date: Mon, 01 Aug 2016 18:38:02 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Maninder Singh , myungjoo.ham@samsung.com Cc: linux-kernel@vger.kernel.org, pankaj.m@samsung.com, Vaneet Narang Subject: Re: [PATCH 1/1] extcon: fixing compile time warning References: <1470043290-15486-1-git-send-email-maninder1.s@samsung.com> In-reply-to: <1470043290-15486-1-git-send-email-maninder1.s@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEIsWRmVeSWpSXmKPExsWyRsSkULdaYn64wZlOHovLu+awWRye38Zi cbtxBZvFvTdbmSwOnZzL6MDq0bdlFaPH501yAUxRXDYpqTmZZalF+nYJXBnHJ7SyFHxkr5jz /SNTA+N6ti5GDg4JAROJXwfUuhg5gUwxiQv3QMJcHEICKxglns7bxgiRMJE49XkJC0RiFqPE q+ZmNpAEr4CgxI/J91hAbGYBdYlJ8xYxQ9giEqcWTWaDsLUlli18zQzR/IBRYsnOSYwQzRoS O3bfBytiEVCV2LGxG2wQm4CWxP4XN8CuExWIkOg+UQkSFhFwk/h/6x7UzDiJvkkTmEBsYQEb iVNHlrBCzJ/LKHHrx12wOZwCHhJPt+8Hu1pCYB27xOmZzawQywQkvk0+xALxvqzEpgPMEF9K ShxccYNlAqP4LCS/zULy2ywkv81C8tsCRpZVjKKpBckFxUnpRYZ6xYm5xaV56XrJ+bmbGIFR d/rfs94djLcPWB9iFOBgVOLhvZE7L1yINbGsuDL3EKMp0EUTmaVEk/OBsZ1XEm9obGZkYWpi amxkbmmmJM6rKPUzWEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVAOjR2ye42H1QGHNrg+3dk72 L5TdvsDnz8wzx59HzHiWymCgM/N93dRr3YrcHOdORCTU33kbHzv1lEln3+RnNal3/7622nkk p3jfrW0PTgYyT9u+3vH0t6DrT2a/rdn2g2Of2cG/DLvf9qz3kfENmigtdmxTX+o6wZn+jJ0J vpuqBHaUh33PUuq2U2Ipzkg01GIuKk4EAGE4gyW1AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsVy+t9jQd1qifnhBquWs1lc3jWHzeLw/DYW i9uNK9gs7r3ZymRx6ORcRgdWj74tqxg9Pm+SC2CKamC0yUhNTEktUkjNS85PycxLt1XyDo53 jjc1MzDUNbS0MFdSyEvMTbVVcvEJ0HXLzAFap6RQlphTChQKSCwuVtK3wzQhNMRN1wKmMULX NyQIrsfIAA0krGHMeHN5H3vBbfaKR23vmRsYZ7J1MXJySAiYSJz6vIQFwhaTuHBvPVCci0NI YBajxKvmZrAiXgFBiR+T7wEVcXAwC8hLHLmUDRJmFlCXmDRvETNE/QNGiSU7JzFC1GtI7Nh9 H6yXRUBVYsfGbrAFbAJaEvtf3GADmSMqECHRfaISJCwi4Cbx/9Y9NoiZcRJ9kyYwgdjCAjYS p44sYYWYP5dR4taPu2BzOAU8JJ5u388ygRHoSoTzZiGcNwvJeQsYmVcxSqQWJBcUJ6XnGual lusVJ+YWl+al6yXn525iBMfpM6kdjAd3uR9iFOBgVOLhTfCfFy7EmlhWXJl7iFGCg1lJhPeR 6PxwId6UxMqq1KL8+KLSnNTiQ4ymQP9NZJYSTc4HppC8knhDYxMzI0sjc0MLI2NzJXHex//X hQkJpCeWpGanphakFsH0MXFwSjUwdu4Slyv9ebJEOTA6+WPs6cQfvLdVt6Wxz/8mGfX7ylqx cK5lN78c5Uu5/N3y8e3PZZIliwIPqXOvbHdTL8y+vufn7dOeu9oV1l3edrog5tlbB+7cSYUp dgGBbh6n7OfsyHgY++rGoZVhnucmfpj5W3BBZF/xyVtzz6df45ldF3644HyDk0OpmxJLcUai oRZzUXEiADROnmbpAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 08월 01일 18:21, Maninder Singh wrote: > This patch fixes below compilation warning:- > drivers/extcon/extcon.c: In function extcon_register_notifier: > drivers/extcon/extcon.c:455:6: warning: idx may be used uninitialized in this function [-Wmaybe-uninitialized] > if (idx >= 0) { > > Signed-off-by: Vaneet Narang > Signed-off-by: Maninder Singh > --- > drivers/extcon/extcon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c > index 8682efc..24f04c4 100644 > --- a/drivers/extcon/extcon.c > +++ b/drivers/extcon/extcon.c > @@ -428,7 +428,7 @@ int extcon_register_notifier(struct extcon_dev *edev, unsigned int id, > struct notifier_block *nb) > { > unsigned long flags; > - int ret, idx; > + int ret, idx = -EINVAL; > > if (!nb) > return -EINVAL; > Applied it. Thanks, Chanwoo Choi