Re: [PATCH 1/1] UBSAN: use uppercase K to format a kernel pointer

Andrey Ryabinin
2016-07-29T15:40:20Z

On 07/29/2016 02:10 PM, Nicolas Iooss wrote:
> handle_object_size_mismatch() used %pk to format a kernel pointer in
> pr_err(). This seems to be a misspelling for %pK.
>
> Fixes: c6d308534aef ("UBSAN: run-time undefined behavior sanity checker")
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> ---
> lib/ubsan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/ubsan.c b/lib/ubsan.c
> index 8799ae5e2e42..d57d1e7e98a3 100644
> --- a/lib/ubsan.c
> +++ b/lib/ubsan.c
> @@ -308,7 +308,7 @@ static void handle_object_size_mismatch(struct type_mismatch_data *data,
> return;
>
> ubsan_prologue(&data->location, &flags);
> - pr_err("%s address %pk with insufficient space\n",
> + pr_err("%s address %pK with insufficient space\n",

I don't see much sense in using %pK here. It should be fine to use just '%p' here as we already use it in handle_missaligned_access().

> type_check_kinds[data->type_check_kind],
> (void *) ptr);
> pr_err("for an object of type %s\n", data->type->type_name);
>