From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752921AbcHAOMd (ORCPT <rfc822;w@1wt.eu>);
	Mon, 1 Aug 2016 10:12:33 -0400
Received: from mga01.intel.com ([192.55.52.88]:14850 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752724AbcHAOMS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 1 Aug 2016 10:12:18 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,455,1464678000"; 
   d="scan'208";a="1032951861"
Subject: Re: [PATCH 0/3] new feature: monitoring page cache events
To: George Amvrosiadis <gamvrosi@gmail.com>
References: <cover.1469489884.git.gamvrosi@gmail.com>
 <579A72F5.10808@intel.com> <20160729034745.GA10234@leftwich>
 <579B774E.10309@intel.com> <20160730173115.GA23083@thinkpad>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Al Viro <viro@zeniv.linux.org.uk>, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
From: Dave Hansen <dave.hansen@intel.com>
Message-ID: <579F57A9.5020708@intel.com>
Date: Mon, 1 Aug 2016 07:07:37 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <20160730173115.GA23083@thinkpad>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/30/2016 10:31 AM, George Amvrosiadis wrote:
> Dave, I can produce a patch that adds the extra two tracepoints and exports
> all four tracepoint symbols. This would be a short patch that would just
> extend existing tracing functionality. What do you think?

Adding those tracepoints is probably useful.  It's probably something we
need to have anyway as long as they don't cause too much code bloat or a
noticeable performance impact when they're off.

As for exporting symbols, that's not done until something is merged.