From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753022AbcHAWiy (ORCPT ); Mon, 1 Aug 2016 18:38:54 -0400 Received: from mail-sn1nam01on0081.outbound.protection.outlook.com ([104.47.32.81]:56576 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751923AbcHAWiq (ORCPT ); Mon, 1 Aug 2016 18:38:46 -0400 X-Greylist: delayed 14815 seconds by postgrey-1.27 at vger.kernel.org; Mon, 01 Aug 2016 18:38:45 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@cavium.com; Message-ID: <579F9CDE.5050207@caviumnetworks.com> Date: Mon, 1 Aug 2016 12:02:54 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Mark Brown CC: Jan Glauber , , , David Daney , "Steven J . Hill" Subject: Re: [PATCH v2 2/2] spi: octeon: Add thunderx driver References: <20160728083144.16625-1-jglauber@cavium.com> <20160728083144.16625-3-jglauber@cavium.com> <20160801172838.GW10376@sirena.org.uk> <579F958F.9020508@caviumnetworks.com> <20160801184931.GB10376@sirena.org.uk> In-Reply-To: <20160801184931.GB10376@sirena.org.uk> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: SN1PR0701CA0031.namprd07.prod.outlook.com (10.162.96.41) To BN4PR07MB2130.namprd07.prod.outlook.com (10.164.63.12) X-MS-Office365-Filtering-Correlation-Id: b75c3e57-2a9b-4219-04e0-08d3ba3e7293 X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2130;2:ltbbcAHTKrdK8STrHR5/peUTr2SnVqGgpiTaHYgGvXP6fMrK4sEOVHluo78DAFcOQK9qotwWkhegsHGqkzfY09e+DsbjkOdLBdjGIDuSj4AZW180GVdLfpoJNrlPwwLI7o4jkgRvtaH/fYGXpAfIqi2VXlOGBbOY+f3VCfbnM8ZDzS4jAlNgtOwvrD2BpMvz;3:We95wlyaYCqjf7K7B3Ob8zu/Ev3Pgj5sm14cl96UAehJVaHnpI71bKCKp/aXfCcyZmU4YGW9ZclkjsNmNk/rgx43EymBGL8LK2luoeblmqwW9ngb0Dt6OXzJPYNJ+Hxm X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2130; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2130;25:YYF8R7Zq4Ox46Tj6V/ik97BnpUgIvbK4IO6JjX9gp1wQoiPO2Ni4nrDgeWk1O/XN9HECGoKQGyJ7VlTt5W1G4dfI34gEfQd2d1eW9Qrdj0P3ZMZTstRl9TOwjUqOP/cyhD43tYPdjv6G5XflUK5GqC3NnuYMpAr3UICd0UgUR1obPYDEObcbfQUvXXyzklisjbczrjeBiR9aNllV28VLu6FJ5JHLJb6r8swcOikkc84lx/wEqlJhD50/CZ7ilJmtz96dHEELszL2dg/t0OaVl/F2lEThUh0YiMpQBNXvbLDIKoj36kJN71WgB+nukTSltiwmAKvknr6MDVhPmHXvJSenPqJ+dfjNB/2lp7lK9LJ4flTahwG+qahf0zJr5h8yCSwbdMkCawh3ajTXSBfAl8OQOXId6/lOjhj9Arx6SvgUItqnn2B4k7dEkQVmXsUyW8YupnqO5OrgLh08OwtONWs14lJquZbqUJgmfPz4N0qw92+CHTwGdgy6Du7ZJyAdjw2z7NUdA6CX/fUzsvM9wmwKfmNM6fxwNfESOMTD3GyjiEvVr7MLmJ99ZxECwpTcHH4uNR4QeQJRbyP+RoNjfghQEZ1Z/Obq4+OnyP79rC49Z4ZkNySvIkbc7Lw6srA2Y/swyulBHKwUuVUAQjUI2+FVt++dauiuBghU90P5hQjYZerwBHJ7zGSHMWuDHVWRDINhBZP6tIeYWZ6AC2GhAQ==;31:r+Oeo330NFCr5BFQtYRGACeQm/AvJeDI3NvBwZF2pFEzpuG2OEIYQls9CKau5CyAziPVU4Mj6BjtUQUn5hxHLBVv3mqmrAGHklizimrtZYdRotrUQRU6zxpcQ+CVoO/8zaVnTvnj7GfIHmUF2Pokxp+255jp1PCpW1jN0l8aaH9a2Ybg2lUQ7Si4lydJH/g3QJoIKDJBw8iUh8SYbjgiBJfykoNySNJHtpYmftrWsj0= X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2130;20:a8JVLhp90usCR6P0zS2dhDDKXmbEdAFz9hqwPTl/GO+G9ymCVDzKuXdUjbGb7mJGBWrqvVyxSop2NsVGoeNrgfXyMUudW2Ar/4W2EJ9FE71XBrb3ORbUD+xG3rPrpv4eXJfrsSLVJ5LqsL/+QFHmuxU3ymF4A4VBuXgIbD7yzt5dPOLdwyjGLBpNk1+EtTpRiIl+B0onC5wzeUN3LKMK2HtQYhgF7DJ4D4MBCuhRt8CKWL+yThBpTzymdMQE7lCvAIjbKOCs5NqauIfIwwtE34NqCqu2q0qCKqOdzcEEJiinhghvov/dXrAIMiYqvLqHz5/jHOyphyaR5utKAkPxE+WTcMJnJdOqjN/IFH9C2+73H5ZwIliYE3k1XyY+f/VoMfPBcackUsWPR91Ozhq2VFQxX//itoy5lvWnyDVBd3VF1KktuYmXqLMrZSmIuhRqQNctFoZvaXZMRWsGyYl9VS+Y52f2P7e9EahINri0TuDSv2YpD0Rbi5d0QYc6+WvRxGK7IX5B2Cln9fZICrIDYWIUQlaiHR1cvZvHU0G/mORw6ceAn4Hnk384nnkq3x0Y2eIyf1hsgnnwWAY7KGgTueOPOvmJwrhdpeEe/EM7diI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BN4PR07MB2130;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2130; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2130;4:FRlVv90/n2WXauXpX53IijTJ+MFsG/bia/iHYuOfkXMjG/Adt1TBbRKHhGdLm0BjYoSTAOEGYFYPPlg224OI7S74GO7tOb7/7dZm3pI/ANglc3UV9iCpSOuHiRJb+bpCq2k5SrLWtGbaZD923Ykwq4f6Y6AqVwWzeEbG1m0dYqxhBcvqMxC72Y3Hgzs5q5e2+N0W3oJEMSGB8Va28zEOZ0QeFG2lIREpA8anpokg7gT6wf9mY44WDYsemqvYCI/QaPrclgh/Km0FreMR1eoYUrNItF4G564d8JBGk+1qJY1NQnUt1u9Si5yXIkj9CUqttXjkV8ii59XJ6O0C7ruVzKcsN3mcdA87bhICFlrInk7xbKyrAqzLNxDWgjFIbV7w X-Forefront-PRVS: 0021920B5A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(377454003)(24454002)(189002)(199003)(4001350100001)(4001430100002)(93886004)(77096005)(305945005)(7736002)(230700001)(101416001)(65816999)(33656002)(50466002)(65806001)(83506001)(106356001)(64126003)(107886002)(2906002)(23756003)(97736004)(4326007)(110136002)(2950100001)(7846002)(92566002)(36756003)(189998001)(42186005)(105586002)(53416004)(69596002)(6116002)(81166006)(8676002)(81156014)(80316001)(586003)(59896002)(54356999)(76176999)(68736007)(3846002)(50986999)(66066001)(65956001)(47776003)(87266999);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2130;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;BN4PR07MB2130;23:LSYrV3S5Ss1Z/5qIjVG1Nn5pm55XbsY9bIHApKg?= =?iso-8859-1?Q?cIC9aPqqiB6V9w5s/05OirtBifq95XFTLnsf+DMbl39SXMeqfYLk5Zwmiv?= =?iso-8859-1?Q?ZWwNreu+oWf6Fv57ZGSnBccmLZh+EeKgcIwq/DaA43moqexGD1kfVKImVt?= =?iso-8859-1?Q?ux5WA9YEe9ds0c5ljgQYGXatLyRXlrlNxrHo3M9cyKluDRfsk6b13YrhJj?= =?iso-8859-1?Q?MpyegbyZwIhYCbnjyI7z8HxkpxbMwXNt7iCYBIm4sCnaOVIIdV32ny8jzN?= =?iso-8859-1?Q?obeCfXp9OXNWt2BYDlQBZNQj0YMNmTXOURGrChedWVxT+KoT8p6UdwwXz6?= =?iso-8859-1?Q?s15hhqF6Z/2ZUEwBcec4Wuq/SKDsgp+bVTd5WJbj5WrvRvWwYeUNJWwrvS?= =?iso-8859-1?Q?O7cG7h8vPInt2Y5c3+ysQ4FJ4cSb0Bhti5bSyzvYSWDtSCEWIqzCOe7RaB?= =?iso-8859-1?Q?4duMNIhJizDshMANvPnzAyY0fwOk3M7JCm09nb0s2l9YUas3WZv09Mh5gw?= =?iso-8859-1?Q?TRAIy57QHCgnbkl1JKRonuKAQKhB1pp0wABGbCEG8Eor0h4PxByDp3W7jx?= =?iso-8859-1?Q?vEdNTkvA7new625mGtGYv/jZd5/AGXeDW59Cx4NAnxlNBBPfX8HpGQ9eJw?= =?iso-8859-1?Q?PNSjTZsHSOrrNgc+h9AVn/tIZ5oYaP+lIeE6igkG2+LcNhvvc0YdGtWsx8?= =?iso-8859-1?Q?OxHURWsNP2gzJ0a+oAZ55doVm8UB71aLcTD3pZSSp/CSx94YIaI1z7PLLN?= =?iso-8859-1?Q?USqEftXii+QtV0HuYUIO/4tNVC/8leq9yNjoxcRVSYbzA6yAonNueBRYbe?= =?iso-8859-1?Q?3ffs+nTTRidutwNZoJ3btwOqCuGa3VQ+9ZRSjPnf9hag5ZbhaXMi9Ac0pV?= =?iso-8859-1?Q?mWAzf7Xisa/mw1SlUdf3QMcu2JZxNUa9ZxKoQaESy5ktH0jNZt3+b6qVvb?= =?iso-8859-1?Q?UFKBxEFEjtZcDiB+nq5920YSy3lwuldtHX2w54zQoV4IV8qlYAqr+o9sgs?= =?iso-8859-1?Q?zSYy+U9NWrfDacQSLx9uw+9Sm8ATL5et4Ugxwa1xZoC4iZL81tQ7uJDKay?= =?iso-8859-1?Q?Tz+T/2IWeK4a1S1WqjRryh97lU5rrnuqbulYIjmCuaOo9AcSaadT7qVjLn?= =?iso-8859-1?Q?Ve2Sec3qhLAbSXEERVCxYNfckZlJ8tw+vIHcMC0BU135IQxOZ0KKJobn02?= =?iso-8859-1?Q?iG3yYWN/K+WPeC4jXfAnVfrzho6SaNW+MBt1dJsjr2CkpXtujczvyOyhqr?= =?iso-8859-1?Q?zyOIb8eojSFdV2NHQxda4V5LnQ6JHcArRtjyHW4jbxm6qR2Lkh5LADEJ/B?= =?iso-8859-1?Q?gNw0h+QmFfplgAvIIbqGxpnJ7H9CFHb3dIq50kEYV/GZmbgPN/FBx1Y1Kf?= =?iso-8859-1?Q?MSe1wG1c=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2130;6:HjlqtcnNM4lUfQrdBWPewq29S897KsgdaY2a2JkaKwOKce/f4zFY5g/OXuKT961tbYgxBzgDmOhT06kzPWXYGjD3qRWNgRbOtRkeD1pfJFuswmHBNYLq6shCyO0FqtBPpwXOJWV8IRP5bQEEkX/lrTqG85Ne2Of8xc1021rDY8AsL7n71TzzZv8NUeR6C3m1WYsxy+5aLJJFZmDc3teGW5P9aBc+/lb4qFhcQtoddlFXp1uvknvsJKSJmxtZW5h0KmFYIbEc9VAKLc71XgBRGZmh5GkHv8yjduESG4yfafE=;5:YC2S+NwSI4JE5JbWLbI4gGQuPuIxlDCO7sb/eMnLfI7DO6k5AhLtihxEK2PAmQlI44fz65cK8gDWZVdAgYSAZ4MTbUmCn2K8lu81UVkUkHA7vg8XkxWAkkewe/NTOn1d/sZSo2bvEJB39gfx9TZTlQ==;24:jhs+xFnWmE7IOGer1jC4igmGUx4OB+Yu3mF7xtjo1azsfbGRK7kkc441K1SBrzxxaxw1Y02ZIXPgYYh0qiEaN2BtyCfOuVNIwwT8n54aO3A=;7:erMgBpsfD6QOAtQdM/yFxh0OXCdmDm2BDrTb6BTQltt+2Eg+uzpcCrfxcIgDJWoeaoku3L6aqeW8wnBqVhV3MI5joiJRVY3CbglgI1/Z6FjgTAW/sIZU7bTEtQaj42Lh24rLuxvVeWN/zFfS+2Wm85I3idjPFmX+hMcRvfHIw7H7gArtqHcVmfjOoWV89Kn5lLAZeuRmXUxp9QoSk8kx4VqXnZ4o5BhIyCdia09MVoK+3WOJ3Sok3RYWoPiX6LrI SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2016 19:02:55.6403 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2130 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/01/2016 11:49 AM, Mark Brown wrote: > On Mon, Aug 01, 2016 at 11:31:43AM -0700, David Daney wrote: >> On 08/01/2016 10:28 AM, Mark Brown wrote: >>> On Thu, Jul 28, 2016 at 10:31:44AM +0200, Jan Glauber wrote: > >>>> + p->clk = devm_clk_get(dev, NULL); >>>> + if (IS_ERR(p->clk)) >>>> + goto out_unmap; > >>> We're now just using the normal clock API which is good but I'm now >>> unclear what is going to ensure that the clock is there - is there some >>> other change elsewhere that I'm not aware of? > >> The clock is an integral part of the SoC and is always running, so it will >> always be there. All we want to know is the frequency, which is supplied by >> the device tree clock-bindings framework > > So there's something there that registers the clock? Yes, when using OF device tree, standard device probing registers the clock. > What is that thing on ACPI systems? I don't know if it works ACPI, or if ACPI even has support for the clock framework. But does it matter? We are not currently using ACPI on systems where this driver is used. In the future, if we ever need ACPI support, we will add support for it. David.