From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755692AbcHBB6T (ORCPT ); Mon, 1 Aug 2016 21:58:19 -0400 Received: from regular1.263xmail.com ([211.150.99.137]:36827 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755562AbcHBB6J (ORCPT ); Mon, 1 Aug 2016 21:58:09 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: zhengxing@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: zhengxing@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [RESEND PATCH v2 3/8] clk: rockchip: rk3399: fix incorrect parent for rk3399's {c, g}pll_aclk_perihp_src To: Brian Norris References: <1470045224-31854-1-git-send-email-zhengxing@rock-chips.com> <1470045224-31854-4-git-send-email-zhengxing@rock-chips.com> <20160801201349.GA129313@google.com> Cc: heiko@sntech.de, linux-rockchip@lists.infradead.org, dianders@chromium.org, huangtao@rock-chips.com, zhangqing@rock-chips.com, Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Xing Zheng Message-ID: <579FFC4D.2070406@rock-chips.com> Date: Tue, 2 Aug 2016 09:50:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160801201349.GA129313@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Brain, On 2016年08月02日 04:13, Brian Norris wrote: > On Mon, Aug 01, 2016 at 05:53:38PM +0800, Xing Zheng wrote: >> There was a typo, swapping 'c' <--> 'g'. >> (This patch is updated and am from https://patchwork.kernel.org/patch/9254067/) >> >> Signed-off-by: Xing Zheng >> Signed-off-by: Brian Norris >> Reviewed-by: Douglas Anderson >> --- >> >> Changes in v2: None > I believe this patch was already applied upstream; otherwise, it > wouldn't make sense to have both this patch and patch 4 -- we would > probably squash them together. > > Brian > Yes, this patch is applied in mmind/linux-rockchip.git v4.7-clk/fixes, I arm sorry to tracked on v4.8-clk/next so that didn't note it. This patch will be abandoned. Thanks. >> drivers/clk/rockchip/clk-rk3399.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c >> index f55f967f..2182391 100644 >> --- a/drivers/clk/rockchip/clk-rk3399.c >> +++ b/drivers/clk/rockchip/clk-rk3399.c >> @@ -832,9 +832,9 @@ static struct rockchip_clk_branch rk3399_clk_branches[] __initdata = { >> RK3399_CLKGATE_CON(13), 1, GFLAGS), >> >> /* perihp */ >> - GATE(0, "cpll_aclk_perihp_src", "gpll", CLK_IGNORE_UNUSED, >> + GATE(0, "cpll_aclk_perihp_src", "cpll", CLK_IGNORE_UNUSED, >> RK3399_CLKGATE_CON(5), 0, GFLAGS), >> - GATE(0, "gpll_aclk_perihp_src", "cpll", CLK_IGNORE_UNUSED, >> + GATE(0, "gpll_aclk_perihp_src", "gpll", CLK_IGNORE_UNUSED, >> RK3399_CLKGATE_CON(5), 1, GFLAGS), >> COMPOSITE(ACLK_PERIHP, "aclk_perihp", mux_aclk_perihp_p, CLK_IGNORE_UNUSED, >> RK3399_CLKSEL_CON(14), 7, 1, MFLAGS, 0, 5, DFLAGS, >> -- >> 1.7.9.5 >> >> > > -- - Xing Zheng