From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758585AbcHDKbz (ORCPT ); Thu, 4 Aug 2016 06:31:55 -0400 Received: from smtpoutz25.laposte.net ([194.117.213.100]:36067 "EHLO smtp.laposte.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751030AbcHDKbw (ORCPT ); Thu, 4 Aug 2016 06:31:52 -0400 Subject: Re: [PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell() To: Thomas Gleixner References: <57A063B8.5050209@laposte.net> Cc: Grant Likely , Marc Zyngier , Jason Cooper , LKML , Mason From: Sebastian Frias Message-ID: <57A31994.7030503@laposte.net> Date: Thu, 4 Aug 2016 12:31:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-VR-SrcIP: 78.31.43.6 X-VR-FullState: 0 X-VR-Score: -100 X-VR-Cause-1: gggruggvucftvghtrhhoucdtuddrfeeltddrkedvgddvhecutefuodetggdotefrodftvfcurfhrohhf X-VR-Cause-2: ihhlvgemucfntefrqffuvffgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhs X-VR-Cause-3: ucdlqddutddtmdenucfjughrpefuvfhfhffkffgfgggjtgfgsehtjegrtddtfeehnecuhfhrohhmpefu X-VR-Cause-4: vggsrghsthhirghnucfhrhhirghsuceoshhfkeegsehlrghpohhsthgvrdhnvghtqeenucfkphepjeek X-VR-Cause-5: rdefuddrgeefrdeinecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghloheplgdujedvrddv X-VR-Cause-6: jedrtddrvddugegnpdhinhgvthepjeekrdefuddrgeefrdeipdhmrghilhhfrhhomhepshhfkeegsehl X-VR-Cause-7: rghpohhsthgvrdhnvghtpdhrtghpthhtohepthhglhigsehlihhnuhhtrhhonhhigidruggv X-VR-AvState: No X-VR-State: 0 X-VR-State: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thomas, On 08/04/2016 12:05 PM, Thomas Gleixner wrote: > On Tue, 2 Aug 2016, Sebastian Frias wrote: > >> Use IRQ_TYPE_SENSE_MASK on irq_domain_xlate_onetwocell() >> >> According to the xlate() callback definition, the 'out_type' parameter >> needs to be the "linux irq type". A mask for such bits exists, >> IRQ_TYPE_SENSE_MASK, and as a matter of fact it is used in >> irq_domain_xlate_twocell(), use it for irq_domain_xlate_onetwocell() as >> well. >> >> Fixes: 16b2e6e2f31d ("irq_domain: Create common xlate functions that device >> drivers can use") > > You seem to be obsessed by adding "Fixes" tags and 'Fix' to the $subject, but > your changelog just babbles about making the code the same as in > irq_domain_xlate_twocell() and avoids carefully to explain what is broken, > what consequences that has and what the fix is. I'm sorry but I think your comment above is unfair, so you could have omitted it entirely. > > Now if you look at the call site which uses the xlate functions then you'll > notice that we have a sanity check there already: > > if (irq_domain_translate(domain, fwspec, &hwirq, &type)) > return 0; > /* > * WARN if the irqchip returns a type with bits > * outside the sense mask set and clear these bits. > */ > if (WARN_ON(type & ~IRQ_TYPE_SENSE_MASK)) > type &= IRQ_TYPE_SENSE_MASK; > (for what is worth, my patch was based on a recent 4.7 that does not has the code you mention above) > So we better remove the masking in the xlate functions completely and let all > the offending device trees trip over the warning so they get eventually fixed. That's fine by me. If you want I can submit a patch that does what you want (if so, should I use "fixes" or not?), let me know. Best regards, Sebastian