From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934150AbcHDROA (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Aug 2016 13:14:00 -0400
Received: from smtprelay.synopsys.com ([198.182.47.9]:50470 "EHLO
	smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932685AbcHDRN6 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Aug 2016 13:13:58 -0400
Subject: Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to
 .detect() callback
To: Russell King - ARM Linux <linux@armlinux.org.uk>,
        Jose Abreu <Jose.Abreu@synopsys.com>
References: <cover.1470306826.git.joabreu@synopsys.com>
 <1bbffb944fb9ce0363f5544db31baf2a911c1c55.1470306826.git.joabreu@synopsys.com>
 <20160804104738.GR1041@n2100.armlinux.org.uk> <57A349E8.5040400@synopsys.com>
 <20160804143102.GU1041@n2100.armlinux.org.uk> <57A357D1.1070900@synopsys.com>
 <20160804150443.GW1041@n2100.armlinux.org.uk>
CC: <dri-devel@lists.freedesktop.org>,
        Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
        Archit Taneja <architt@codeaurora.org>,
        David Airlie <airlied@linux.ie>,
        Fabio Estevam <fabio.estevam@freescale.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>, Takashi Iwai <tiwai@suse.de>,
        Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
        Thierry Reding <treding@nvidia.com>, <linux-kernel@vger.kernel.org>
From: Jose Abreu <Jose.Abreu@synopsys.com>
Message-ID: <57A377AE.5060208@synopsys.com>
Date: Thu, 4 Aug 2016 18:13:18 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <20160804150443.GW1041@n2100.armlinux.org.uk>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.107.19.32]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Russell,


On 04-08-2016 16:04, Russell King - ARM Linux wrote:
> On Thu, Aug 04, 2016 at 03:57:21PM +0100, Jose Abreu wrote:
>> Hmm, I am not debugging it right now but I remember that
>> drm_fb_helper_probe_connector_modes() was not being called at the
>> time I set the new EDID but only after I stopped sending video (I
>> was using modetest).
> Please investigate - I'd prefer that your patch does not get applied
> until we really know what's going on here.
>
> Hmm, if you're using modetest, then userspace is setting a mode, and
> userspace is in control of the DRM device - that's probably the reason
> why you're not seeing anything happening - modetest probably doesn't
> know anything about hotplug events, and so doesn't read the modes.
>
> Have you tried with the framebuffer console and DRM fbdev emulation
> enabled, without using modetest?
>

So, I didn't use framebuffer console but used X instead and it is
working as it should. I think we can drop this patch. I am now
making interoperability with DVI and I am facing the following
scenario:
    - I start the driver
    - An EDID is sent which tells the driver that HDMI is NOT
supported;
    - The driver configures itself to a DVI mode;

Until this point everything is working as it should. But:

    - Now I send an EDID which tells the driver that HDMI is
supported;
    - As the EDID has the same preferred mode the user will not
reconfigure the mode and there will be no change to HDMI mode.

The missing change to HDMI mode will cause the test to fail. The
workaround that I am using is to reconfigure to another video
mode and then configure to the preferred one but I think this
could be fixed in the driver, right?

Best regards,
Jose Miguel Abreu