From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934928AbcHEIZa (ORCPT ); Fri, 5 Aug 2016 04:25:30 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:42003 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759548AbcHEIYx (ORCPT ); Fri, 5 Aug 2016 04:24:53 -0400 Subject: Re: [PATCH v5 1/3] Documentation: mfd: LP873X: Add information for the mfd driver To: Lee Jones , Keerthy References: <1467215067-6486-1-git-send-email-j-keerthy@ti.com> <1467215067-6486-2-git-send-email-j-keerthy@ti.com> <20160805080557.GP5243@dell> CC: , , , , , , , , From: Keerthy Message-ID: <57A44D48.2070402@ti.com> Date: Fri, 5 Aug 2016 13:54:40 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20160805080557.GP5243@dell> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 05 August 2016 01:35 PM, Lee Jones wrote: > On Wed, 29 Jun 2016, Keerthy wrote: > >> The lp873x series of PMICs have a bunch of regulators and a couple >> of GPO(General Purpose Outputs). >> Add information for the mfd and regulator drivers. > > Nit: s/mfd/MFD/ Okay. > >> Acked-by: Rob Herring >> Signed-off-by: Keerthy >> --- >> >> Changes in v4: >> >> * Added the GPIO properties. >> >> Changes in v3: >> >> * Changed the example node lable to pmic from lp8733. >> >> Documentation/devicetree/bindings/mfd/lp873x.txt | 59 ++++++++++++++++++++++++ >> 1 file changed, 59 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/lp873x.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/lp873x.txt b/Documentation/devicetree/bindings/mfd/lp873x.txt >> new file mode 100644 >> index 0000000..1377c25 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/lp873x.txt >> @@ -0,0 +1,59 @@ >> +TI LP873X MFD driver > > "PMIC MFD" or "MFD PMIC" > >> +Required properties: >> + - compatible: "ti,lp8732", "ti,lp8733" >> + - reg: I2C slave address. >> + - gpio-controller : Marks the device node as a GPIO Controller. >> + - #gpio-cells : Should be two. The first cell is the pin number and >> + the second cell is used to specify flags. >> + See ../gpio/gpio.txt for more information. >> + - regulators: : List of child nodes that specify the regulator >> + initialization data. > > Please standardise your formatting here. Sometimes you do ":", other > times you do " :", and oddly ": :". Okay sure. > >> +Example: >> + >> +pmic: lp8733@60 { >> + compatible = "ti,lp8733"; >> + reg = <0x60>; >> + gpio-controller; >> + #gpio-cells = <2>; >> + >> + regulators { >> + lp8733_buck0: buck0 { >> + regulator-name = "lp8733-buck0"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <1400000>; >> + regulator-min-microamp = <1500000>; >> + regulator-max-microamp = <4000000>; >> + regulator-ramp-delay = <10000>; >> + regulator-always-on; >> + regulator-boot-on; >> + }; >> + >> + lp8733_buck1: buck1 { >> + regulator-name = "lp8733-buck1"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <1400000>; >> + regulator-min-microamp = <1500000>; >> + regulator-max-microamp = <4000000>; >> + regulator-ramp-delay = <10000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> + >> + lp8733_ldo0: ldo0 { >> + regulator-name = "lp8733-ldo0"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <3000000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> + >> + lp8733_ldo1: ldo1 { >> + regulator-name = "lp8733-ldo1"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <3000000>; >> + regulator-always-on; >> + regulator-boot-on; >> + }; >> + }; >> +}; >