From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932777AbcHJChv (ORCPT ); Tue, 9 Aug 2016 22:37:51 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:46341 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932540AbcHJChu (ORCPT ); Tue, 9 Aug 2016 22:37:50 -0400 Message-ID: <57AA936E.3080503@huawei.com> Date: Wed, 10 Aug 2016 10:37:34 +0800 From: zhong jiang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Andrew Morton CC: , Subject: Re: [PATCH] mm: optimize find_zone_movable_pfns_for_nodes to avoid unnecessary loop. References: <1470405847-53322-1-git-send-email-zhongjiang@huawei.com> <20160809162919.266e58ca0c33896dcf417a02@linux-foundation.org> In-Reply-To: <20160809162919.266e58ca0c33896dcf417a02@linux-foundation.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.29.68] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.57AA9378.003C,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 95d78e56b538bf2d7c9575552d6dd5d1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/8/10 7:29, Andrew Morton wrote: > On Fri, 5 Aug 2016 22:04:07 +0800 zhongjiang wrote: > >> when required_kernelcore decrease to zero, we should exit the loop in time. >> because It will waste time to scan the remainder node. > The patch is rather ugly and it only affects __init code, so the only > benefit will be to boot time. yes > Do we have any timing measurements which would justify changing this code? I am sorry for that. That is a only theoretical analysis. >