From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932817AbcHKIiL (ORCPT <rfc822;w@1wt.eu>);
	Thu, 11 Aug 2016 04:38:11 -0400
Received: from foss.arm.com ([217.140.101.70]:52467 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932418AbcHKIhs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 11 Aug 2016 04:37:48 -0400
Subject: Re: [Regression] "irqdomain: Don't set type when mapping an IRQ"
 breaks nexus7 gpio buttons
To: Linus Walleij <linus.walleij@linaro.org>,
        John Stultz <john.stultz@linaro.org>
References: <CALAqxLUMMc_3cnj_0q9-hr+0ZKQONNyJKynT3RtsvOy4JKsDgQ@mail.gmail.com>
 <a6b946bd-26f2-b257-aaa4-70018abe96f0@nvidia.com>
 <CALAqxLWgEdNhY7sH20H91VhQZd1UF5ONqUoqz_gHC-R-VMN6bQ@mail.gmail.com>
 <CACRpkdZB_A8Hv8owZV8Pi4VaxG6sa0iP_KuLmkBSexn1_s7Byw@mail.gmail.com>
Cc: Jon Hunter <jonathanh@nvidia.com>, Thomas Gleixner <tglx@linutronix.de>,
        lkml <linux-kernel@vger.kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
From: Marc Zyngier <marc.zyngier@arm.com>
X-Enigmail-Draft-Status: N1110
Organization: ARM Ltd
Message-ID: <57AC3959.2030404@arm.com>
Date: Thu, 11 Aug 2016 09:37:45 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.7.0
MIME-Version: 1.0
In-Reply-To: <CACRpkdZB_A8Hv8owZV8Pi4VaxG6sa0iP_KuLmkBSexn1_s7Byw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/08/16 22:48, Linus Walleij wrote:
> On Sat, Aug 6, 2016 at 1:45 AM, John Stultz <john.stultz@linaro.org> wrote:
> 
>> @@ -614,7 +615,11 @@ unsigned int irq_create_fwspec_mapping(struct
>> irq_fwspec *fwspec)
>>                  * it now and return the interrupt number.
>>                  */
>>                 if (irq_get_trigger_type(virq) == IRQ_TYPE_NONE) {
>> -                       irq_set_irq_type(virq, type);
>> +                       irq_data = irq_get_irq_data(virq);
>> +                       if (!irq_data)
>> +                               return 0;
>> +
>> +                       irqd_set_trigger_type(irq_data, type);
>>                         return virq;
>>                 }
>>
>> If I revert just that, it works again.
> 
> This makes my platform work too.
> Tested-by: Linus Walleij <linus.walleij@linaro.org>

Hmmm. I'm now booting your kernel on the APQ8060, and reverting this
hunk doesn't fix it for me. I'm confused...

The interesting part is this:
109:     100000          0   msmgpio  88 Level     (null)

which shows that the cascade interrupt has been disabled after 100000
unhandled interrupts. Somehow, this screams "misconfiguration"...

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...