From: Luis de Bethencourt <luisbg@osg.samsung.com>
To: Salah Triki <salah.triki@gmail.com>,
akpm@linux-foundation.org, viro@zeniv.linux.org.uk
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] befs: remove unnecessary initialization
Date: Thu, 11 Aug 2016 12:07:23 +0100 [thread overview]
Message-ID: <57AC5C6B.2090608@osg.samsung.com> (raw)
In-Reply-To: <9e9a627c26b78a273162f84afe4d2f6e22340e2c.1470867071.git.salah.triki@gmail.com>
On 10/08/16 23:12, Salah Triki wrote:
> There is no need to init block, since it will be overwitten later by
> iaddr2blockno().
>
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---
> fs/befs/io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/befs/io.c b/fs/befs/io.c
> index f9790f5..39d0dce 100644
> --- a/fs/befs/io.c
> +++ b/fs/befs/io.c
> @@ -27,7 +27,7 @@ struct buffer_head *
> befs_bread_iaddr(struct super_block *sb, befs_inode_addr iaddr)
> {
> struct buffer_head *bh;
> - befs_blocknr_t block = 0;
> + befs_blocknr_t block;
>
> befs_debug(sb, "---> Enter %s "
> "[%u, %hu, %hu]", __func__, iaddr.allocation_group,
>
Applied and merged to:
https://github.com/luisbg/linux-befs/commits/for-next
Thanks Salah :)
Luis
next prev parent reply other threads:[~2016-08-11 11:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 22:12 [PATCH 1/4] befs: check allocation_group number before use Salah Triki
2016-08-10 22:12 ` [PATCH 2/4] befs: check return value of iaddr2blockno Salah Triki
2016-08-10 22:12 ` [PATCH 3/4] befs: remove the validation of allocation group number Salah Triki
2016-08-10 22:12 ` [PATCH 4/4] befs: remove unnecessary initialization Salah Triki
2016-08-11 11:07 ` Luis de Bethencourt [this message]
2016-08-11 10:56 ` [PATCH 1/4] befs: check allocation_group number before use Luis de Bethencourt
2016-08-12 7:26 ` Salah Triki
2016-08-12 9:38 ` Luis de Bethencourt
2016-08-12 10:17 ` Salah Triki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57AC5C6B.2090608@osg.samsung.com \
--to=luisbg@osg.samsung.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=salah.triki@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).