From: Chris Zhong <zyw@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: zhengxing@rock-chips.com, yzq@rock-chips.com,
mturquette@baylibre.com, sboyd@codeaurora.org,
linux-kernel@vger.kernel.org, tfiga@chromium.org,
linux-rockchip@lists.infradead.org, dianders@chromium.org,
groeck@chromium.org, marcheu@chromium.org, wulf@rock-chips.com,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [v2 PATCH] clk: rockchip: mark rk3399 hdcp_noc and vio_noc as critical
Date: Fri, 12 Aug 2016 08:39:29 +0800 [thread overview]
Message-ID: <57AD1AC1.5080600@rock-chips.com> (raw)
In-Reply-To: <1721159.V5xB9fz0jT@diego>
Hi Heiko
On 08/12/2016 06:17 AM, Heiko Stübner wrote:
> Am Dienstag, 9. August 2016, 11:02:33 schrieb Chris Zhong:
>> Fix incorrect rk3399 aclk_vio gating bit, it should be 0, not 10. With
>> this modification, the aclk_vio_noc should be put into critical list,
>> since it is required by VOP.
>> And the Type-C DP need these clocks: aclk_hdcp_noc, hclk_hdcp_noc,
>> pclk_hdcp_noc. Mark them as critical to avoid someone close them.
>>
>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
> I've split that patch in two and applied them there:
> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.8-clk/fixes&id=a3f457d9636b3f5ae4fc6502cb0c95f60f5e342b
> (gate-bit-fix)
> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.9-clk/next&id=54479449c801e46ee2b6ba08e2f19cd810f74f94
> (critical clocks)
>
> with the provided Reviewed-bys.
with the "gate-bit-fix" patch, probably someone will find the panel can
not display, since the aclk_vio_noc would be disabled default, and this
noc clk is required by VOP.
So, if someone want to pick up "gate-bit-fix", please get the one
"critical clocks" firstly.
>
>
> Heiko
>
>
>
prev parent reply other threads:[~2016-08-12 0:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 18:02 [v2 PATCH] clk: rockchip: mark rk3399 hdcp_noc and vio_noc as critical Chris Zhong
2016-08-10 22:14 ` Guenter Roeck
2016-08-11 2:31 ` Xing Zheng
2016-08-11 7:07 ` Heiko Stübner
2016-08-11 22:17 ` Heiko Stübner
2016-08-12 0:39 ` Chris Zhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57AD1AC1.5080600@rock-chips.com \
--to=zyw@rock-chips.com \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=marcheu@chromium.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=tfiga@chromium.org \
--cc=wulf@rock-chips.com \
--cc=yzq@rock-chips.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox