From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751726AbcHLAjr (ORCPT ); Thu, 11 Aug 2016 20:39:47 -0400 Received: from regular1.263xmail.com ([211.150.99.131]:58250 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751088AbcHLAjp (ORCPT ); Thu, 11 Aug 2016 20:39:45 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 addr_info_check: 0 X-RL-SENDER: zyw@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 104.132.1.77 X-LOGIN-NAME: zyw@rock-chips.com X-UNIQUE-TAG: <3452da39d65afb1a507b4402ba36d00f> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [v2 PATCH] clk: rockchip: mark rk3399 hdcp_noc and vio_noc as critical To: =?UTF-8?Q?Heiko_St=c3=bcbner?= References: <1470765753-11619-1-git-send-email-zyw@rock-chips.com> <1721159.V5xB9fz0jT@diego> Cc: zhengxing@rock-chips.com, yzq@rock-chips.com, mturquette@baylibre.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, tfiga@chromium.org, linux-rockchip@lists.infradead.org, dianders@chromium.org, groeck@chromium.org, marcheu@chromium.org, wulf@rock-chips.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Chris Zhong Message-ID: <57AD1AC1.5080600@rock-chips.com> Date: Fri, 12 Aug 2016 08:39:29 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1721159.V5xB9fz0jT@diego> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko On 08/12/2016 06:17 AM, Heiko Stübner wrote: > Am Dienstag, 9. August 2016, 11:02:33 schrieb Chris Zhong: >> Fix incorrect rk3399 aclk_vio gating bit, it should be 0, not 10. With >> this modification, the aclk_vio_noc should be put into critical list, >> since it is required by VOP. >> And the Type-C DP need these clocks: aclk_hdcp_noc, hclk_hdcp_noc, >> pclk_hdcp_noc. Mark them as critical to avoid someone close them. >> >> Signed-off-by: Chris Zhong > I've split that patch in two and applied them there: > https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.8-clk/fixes&id=a3f457d9636b3f5ae4fc6502cb0c95f60f5e342b > (gate-bit-fix) > https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.9-clk/next&id=54479449c801e46ee2b6ba08e2f19cd810f74f94 > (critical clocks) > > with the provided Reviewed-bys. with the "gate-bit-fix" patch, probably someone will find the panel can not display, since the aclk_vio_noc would be disabled default, and this noc clk is required by VOP. So, if someone want to pick up "gate-bit-fix", please get the one "critical clocks" firstly. > > > Heiko > > >