From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752196AbcHLIkY (ORCPT ); Fri, 12 Aug 2016 04:40:24 -0400 Received: from bear.ext.ti.com ([198.47.19.11]:33849 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbcHLIkV (ORCPT ); Fri, 12 Aug 2016 04:40:21 -0400 Subject: Re: [PATCH RESEND] phy: brcm-sata: Return proper error if brcm_sata_phy_init fails To: Axel Lin References: <1470823484-18198-1-git-send-email-axel.lin@ingics.com> CC: Anup Patel , Florian Fainelli , From: Kishon Vijay Abraham I Message-ID: <57AD8B6E.5050009@ti.com> Date: Fri, 12 Aug 2016 14:10:14 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1470823484-18198-1-git-send-email-axel.lin@ingics.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 10 August 2016 03:34 PM, Axel Lin wrote: > Return proper error instead of 0 if brcm_sata_phy_init fails. merged now, thanks. -Kishon > > Signed-off-by: Axel Lin > --- > It was sent on https://lkml.org/lkml/2016/5/23/12 . > drivers/phy/phy-brcm-sata.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/phy-brcm-sata.c b/drivers/phy/phy-brcm-sata.c > index 18d6626..8ffc44a 100644 > --- a/drivers/phy/phy-brcm-sata.c > +++ b/drivers/phy/phy-brcm-sata.c > @@ -367,7 +367,7 @@ static int brcm_sata_phy_init(struct phy *phy) > rc = -ENODEV; > }; > > - return 0; > + return rc; > } > > static const struct phy_ops phy_ops = { >