From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752924AbcHOK1C (ORCPT ); Mon, 15 Aug 2016 06:27:02 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:58210 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752595AbcHOK1B (ORCPT ); Mon, 15 Aug 2016 06:27:01 -0400 Subject: Re: [PATCH 2/2] perf script: Don't disable use_callchain if input is pipe To: , , , References: <1470309943-153909-1-git-send-email-hekuang@huawei.com> <1470309943-153909-2-git-send-email-hekuang@huawei.com> CC: , From: Hekuang Message-ID: <57B1988B.3020806@huawei.com> Date: Mon, 15 Aug 2016 18:25:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1470309943-153909-2-git-send-email-hekuang@huawei.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.110.55.166] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.57B1989F.006E,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 20b84915ffd0d30b1e07408b6b2a50b5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping. ÔÚ 2016/8/4 19:25, He Kuang дµÀ: > Because perf data from pipe do not have a header with evsel attr, we > should not check that and disable symbol_conf.use_callchain. Otherwise, > perf script won't show callchains even if the data stream contains > callchain. > > Before: > $ perf record -g -o - uname |perf script > Linux > [ perf record: Woken up 1 times to write data ] > [ perf record: Captured and wrote 0.000 MB - ] > uname 1828 182630.186578: 250000 cpu-clock: ..b9499 setup_arg_pages > uname 1828 182630.186850: 250000 cpu-clock: ..83b20 ___might_sleep > uname 1828 182630.187153: 250000 cpu-clock: ..4b6be file_map_prot_ch > ... > > After: > $ perf record -g -o - uname |perf script > Linux > [ perf record: Woken up 1 times to write data ] > [ perf record: Captured and wrote 0.000 MB - ] > uname 1833 182675.927099: 250000 cpu-clock: > ba5520 _raw_spin_lock+0xfe200040 ([kernel.kallsyms]) > 389dd4 expand_downwards+0xfe200154 ([kernel.kallsyms]) > 389f34 expand_stack+0xfe200024 ([kernel.kallsyms]) > 3b957e setup_arg_pages+0xfe20019e ([kernel.kallsyms]) > 40c80f load_elf_binary+0xfe20042f ([kernel.kallsyms]) > ... > > Signed-off-by: He Kuang > --- > tools/perf/builtin-script.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c > index d47aef9..ec8df8f 100644 > --- a/tools/perf/builtin-script.c > +++ b/tools/perf/builtin-script.c > @@ -371,14 +371,16 @@ static int perf_session__check_output_opt(struct perf_session *session) > > if (!no_callchain) { > bool use_callchain = false; > + bool not_pipe = false; > > evlist__for_each_entry(session->evlist, evsel) { > + not_pipe = true; > if (evsel->attr.sample_type & PERF_SAMPLE_CALLCHAIN) { > use_callchain = true; > break; > } > } > - if (!use_callchain) > + if (not_pipe && !use_callchain) > symbol_conf.use_callchain = false; > } >