From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753178AbcHPCfH (ORCPT ); Mon, 15 Aug 2016 22:35:07 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:59811 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932343AbcHPCfF (ORCPT ); Mon, 15 Aug 2016 22:35:05 -0400 Subject: Re: [PATCH 1/4] net: hix5hd2_gmac: add tx scatter-gather feature To: Rob Herring References: <1470906115-155569-1-git-send-email-lidongpo@hisilicon.com> <1470906115-155569-2-git-send-email-lidongpo@hisilicon.com> <20160812184336.GA5706@rob-hp-laptop> <57B1664F.1090708@hisilicon.com> CC: Mark Rutland , Michael Turquette , Stephen Boyd , Russell King , Zhangfei Gao , Yisen Zhuang , , David Miller , Arnd Bergmann , Andrew Lunn , , , , netdev , "devicetree@vger.kernel.org" , linux-clk , "linux-kernel@vger.kernel.org" From: Dongpo Li Message-ID: <57B27A3C.5070403@hisilicon.com> Date: Tue, 16 Aug 2016 10:28:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.66.52.107] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.57B27A70.00A3,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: c2248f0c86d7eca29c613f39f8a679a8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/8/16 0:18, Rob Herring wrote: > On Mon, Aug 15, 2016 at 1:50 AM, Dongpo Li wrote: >> Hi Rob, >> Many thanks for your review. >> >> On 2016/8/13 2:43, Rob Herring wrote: >>> On Thu, Aug 11, 2016 at 05:01:52PM +0800, Dongpo Li wrote: >>>> From: Li Dongpo >>>> >>>> The "hix5hd2" is SoC name, add the generic ethernet driver name. >>>> The "hisi-gemac-v1" is the basic version and "hisi-gemac-v2" adds >>>> the SG/TXCSUM/TSO/UFO features. >>>> This patch only adds the SG(scatter-gather) driver for transmitting, >>>> the drivers of other features will be submitted later. >>> >>> The compatible string changes should probably be a separate patch. >>> >> ok, I will split this patch into two patches, one for compatible string changes, >> and one for driver feature implementation. >> >>>> Signed-off-by: Dongpo Li >>>> --- >>>> .../bindings/net/hisilicon-hix5hd2-gmac.txt | 9 +- >>>> drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 213 +++++++++++++++++++-- >>>> 2 files changed, 205 insertions(+), 17 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt b/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt >>>> index 75d398b..3c02fac 100644 >>>> --- a/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt >>>> +++ b/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt >>>> @@ -1,7 +1,12 @@ >>>> Hisilicon hix5hd2 gmac controller >>>> >>>> Required properties: >>>> -- compatible: should be "hisilicon,hix5hd2-gmac". >>>> +- compatible: should contain one of the following version strings: >>>> + * "hisilicon,hisi-gemac-v1" >>>> + * "hisilicon,hisi-gemac-v2" >>>> + and one of the following SoC string: >>>> + * "hisilicon,hix5hd2-gemac" >>>> + * "hisilicon,hi3798cv200-gemac" >>> >>> Make it clear what the order should be. >>> >> ok, I will put the SoC strings in alphabetical order. > > No, I mean the most specific string comes first. > ok, I will fix it in next patch version. Thank you. > Rob > > . > Regards, Dongpo .