From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753215AbcHPHZW (ORCPT ); Tue, 16 Aug 2016 03:25:22 -0400 Received: from sender153-mail.zoho.com ([74.201.84.153]:21343 "EHLO sender153-mail.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751226AbcHPHZU (ORCPT ); Tue, 16 Aug 2016 03:25:20 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=subject:to:references:cc:from:message-id:date:user-agent:mime-version:in-reply-to:content-type; b=KnlT1y27XhpsGJkq1x2zCwhX7RK0N5qCPIRGJn4JChP7sFnnfaC5YMsJG5Nq4rudCM5pSB4rfNf0 ENzB4AV80VhXjdv1uf9q262E94NXvRBvy/mxFqUBtNPucrtUQ6J2 Subject: Re: [PATCH 1/1] bitops.h: move out get_count_order[_long]() from __KERNEL__ scope To: Stephen Rothwell References: <57B2B238.3030709@zoho.com> <20160816165030.51141b60@canb.auug.org.au> Cc: Andrew Morton , linux-kernel@vger.kernel.org From: zijun_hu Message-ID: <57B2BFC7.8020709@zoho.com> Date: Tue, 16 Aug 2016 15:24:55 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160816165030.51141b60@canb.auug.org.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/16/2016 02:50 PM, Stephen Rothwell wrote: > Hi, > > On Tue, 16 Aug 2016 14:27:04 +0800 zijun_hu wrote: >> >> From: zijun_hu >> >> move out get_count_order[_long]() definitions from scope limited >> by macro __KERNEL__ > > Why do you need to do this? You say why in the commit message. > 1, it make both functions available in wider region regardless of whether macro __KERNEL__ is defined 2, get_count_order() locates out off region limited by macro __KERNEL__ before the recent commit c513b4cd2fe9 ("mm-vmalloc-fix-align-value-calculation-error-v2-fix-fix") it maybe more perfect to keep its original region and place its counterpart get_count_order_long() nearly thanks for your reply