* [PATCH] Input: tegra-kbc: fix inverted reset logic
@ 2016-08-16 2:59 Masahiro Yamada
2016-08-16 10:26 ` Thierry Reding
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Masahiro Yamada @ 2016-08-16 2:59 UTC (permalink / raw)
To: linux-input, Dmitry Torokhov
Cc: Masahiro Yamada, Thierry Reding, linux-kernel, Stephen Warren,
Rakesh Iyer, Laxman Dewangan, linux-tegra, Alexandre Courbot
Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
accidentally converted _deassert to _assert, so there is no code
to wake up this hardware.
Fixes: fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/input/keyboard/tegra-kbc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
index 7d61439..0c07e10 100644
--- a/drivers/input/keyboard/tegra-kbc.c
+++ b/drivers/input/keyboard/tegra-kbc.c
@@ -376,7 +376,7 @@ static int tegra_kbc_start(struct tegra_kbc *kbc)
/* Reset the KBC controller to clear all previous status.*/
reset_control_assert(kbc->rst);
udelay(100);
- reset_control_assert(kbc->rst);
+ reset_control_deassert(kbc->rst);
udelay(100);
tegra_kbc_config_pins(kbc);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Input: tegra-kbc: fix inverted reset logic
2016-08-16 2:59 [PATCH] Input: tegra-kbc: fix inverted reset logic Masahiro Yamada
@ 2016-08-16 10:26 ` Thierry Reding
2016-08-16 11:16 ` Laxman Dewangan
2016-08-22 21:20 ` Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2016-08-16 10:26 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-input, Dmitry Torokhov, linux-kernel, Stephen Warren,
Rakesh Iyer, Laxman Dewangan, linux-tegra, Alexandre Courbot
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
On Tue, Aug 16, 2016 at 11:59:23AM +0900, Masahiro Yamada wrote:
> Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
> accidentally converted _deassert to _assert, so there is no code
> to wake up this hardware.
>
> Fixes: fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/input/keyboard/tegra-kbc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Nice catch!
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Input: tegra-kbc: fix inverted reset logic
2016-08-16 2:59 [PATCH] Input: tegra-kbc: fix inverted reset logic Masahiro Yamada
2016-08-16 10:26 ` Thierry Reding
@ 2016-08-16 11:16 ` Laxman Dewangan
2016-08-22 21:20 ` Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Laxman Dewangan @ 2016-08-16 11:16 UTC (permalink / raw)
To: Masahiro Yamada, linux-input, Dmitry Torokhov
Cc: Thierry Reding, linux-kernel, Stephen Warren, Rakesh Iyer,
linux-tegra, Alexandre Courbot
On Tuesday 16 August 2016 08:29 AM, Masahiro Yamada wrote:
> Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
> accidentally converted _deassert to _assert, so there is no code
> to wake up this hardware.
>
> Fixes: fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Input: tegra-kbc: fix inverted reset logic
2016-08-16 2:59 [PATCH] Input: tegra-kbc: fix inverted reset logic Masahiro Yamada
2016-08-16 10:26 ` Thierry Reding
2016-08-16 11:16 ` Laxman Dewangan
@ 2016-08-22 21:20 ` Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2016-08-22 21:20 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-input, Thierry Reding, linux-kernel, Stephen Warren,
Rakesh Iyer, Laxman Dewangan, linux-tegra, Alexandre Courbot
On Tue, Aug 16, 2016 at 11:59:23AM +0900, Masahiro Yamada wrote:
> Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
> accidentally converted _deassert to _assert, so there is no code
> to wake up this hardware.
>
> Fixes: fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied, thank you.
> ---
>
> drivers/input/keyboard/tegra-kbc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
> index 7d61439..0c07e10 100644
> --- a/drivers/input/keyboard/tegra-kbc.c
> +++ b/drivers/input/keyboard/tegra-kbc.c
> @@ -376,7 +376,7 @@ static int tegra_kbc_start(struct tegra_kbc *kbc)
> /* Reset the KBC controller to clear all previous status.*/
> reset_control_assert(kbc->rst);
> udelay(100);
> - reset_control_assert(kbc->rst);
> + reset_control_deassert(kbc->rst);
> udelay(100);
>
> tegra_kbc_config_pins(kbc);
> --
> 1.9.1
>
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-22 21:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-16 2:59 [PATCH] Input: tegra-kbc: fix inverted reset logic Masahiro Yamada
2016-08-16 10:26 ` Thierry Reding
2016-08-16 11:16 ` Laxman Dewangan
2016-08-22 21:20 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox